Re: [PATCH 21/44] power/reset: gpio-poweroff: Register with kernel poweroff handler

would prefer to keep the warning traceback. We found on some hardware the GPIO transitions were too fast and it failed to power off. Seeing the traceback gives an idea where to go look for the problem. Other than that, Acked-by: Andrew Lunn and...@lunn.ch Cc: Sebastian Reichel s...@kernel.org Cc

Re: [PATCH 23/44] power/reset: qnap-poweroff: Register with kernel poweroff handler

registered when the driver is loaded. Cc: Sebastian Reichel s...@kernel.org Cc: Dmitry Eremin-Solenikov dbarysh...@gmail.com Cc: David Woodhouse dw...@infradead.org Signed-off-by: Guenter Roeck li...@roeck-us.net Acked-by: Andrew Lunn and...@lunn.ch Thanks Andrew --- drivers/power/reset

Re: [PATCH 20/44] power/reset: restart-poweroff: Register with kernel poweroff handler

, this is how it is designed to work. There is no way to turn the power off from with linux, it is designed that u-boot will put the hardware into minimal power consumption until the power button is pressed. Other than that, Acked-by: Andrew Lunn and...@lunn.ch Thanks Andrew Cc

Re: [PATCH 06/44] gpio-poweroff: Drop reference to pm_power_off from devicetree bindings

Signed-off-by: Guenter Roeck li...@roeck-us.net Acked-by: Andrew Lunn and...@lunn.ch Thanks Andrew --- Documentation/devicetree/bindings/gpio/gpio-poweroff.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/gpio/gpio

Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings

On Mon, Oct 06, 2014 at 10:28:09PM -0700, Guenter Roeck wrote: Replace reference to pm_power_off (which is an implementation detail) and replace it with a more generic description of the driver's functionality. Acked-by: Andrew Lunn and...@lunn.ch Thanks Andrew Cc: Rob Herring robh

Re: [PATCH v5 4/4] net: phy: leds: add support for led triggers on phy link state change

On Mon, Oct 17, 2016 at 10:49:55AM -0500, Zach Brown wrote: > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a > set of led triggers for each instantiated PHY device. There is one LED > trigger per link-speed, per-phy. > The triggers are registered during phy_attach and

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = { > + "rx_packets ", > + "rx_bytes ", > + "rx_multicasts ", > + "rx_errors ", > + "rx_buff_miss ", > + "rx_tp_csum ", > + "rx_tp_oflow", > + "rx_tp_hlen ", > + "rx_ip_csum

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

> The link state is retrieved by a command to the application processor that is > running > on the network card. Also the register to set the phy configuration is > write-only, so > it is not even possible to do the usual mdio bit-banging in the Phy read() > and write() > functions (however

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | > > +SLIC_PCR_AUTONEG_RST; > > + slic_write(sdev, SLIC_REG_WPHY, val); > Thats essentially what I meant by setting a flag in the irq handler. The mdio > function

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

> Andrew, are you happy with this implementation? Sorry, been to busy with other things to follow the discussion. What would be nice to see is a comment about how the link to LEDs in the PHYs is made. Often there is a couple of LEDs in the RJ45 socket driven by the PHY. They can show link,

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

> Do you have suggestions on how to better handle the choice of the array size > and the speeds? phydev->supported lists the speeds this phy supports. Andrew ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 0/6] staging: Introduce DPAA2 Ethernet Switch driver

On Tue, Sep 19, 2017 at 12:01:32PM +0300, Razvan Stefanescu wrote: > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > switch objects discovered on the fsl-mc bus. A description of the driver > can

Re: [PATCH 5/6] staging: fsl-dpaa2/ethsw: Add README

On Tue, Sep 19, 2017 at 12:01:37PM +0300, Razvan Stefanescu wrote: > +Driver uses the switch device driver model and exposes each switch port as > +a network interface, which can be included in a bridge. Traffic switched > +between ports is offloaded into the hardware. Exposed network interfaces >

Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

Hi Razvan > +static void ethsw_get_drvinfo(struct net_device *netdev, > + struct ethtool_drvinfo *drvinfo) > +{ > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > + u16 version_major, version_minor; > + int err; > + > +

Re: [PATCH 5/6] staging: fsl-dpaa2/ethsw: Add README

On Tue, Oct 03, 2017 at 10:07:41AM +, Razvan Stefanescu wrote: > > -Original Message- > > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] > > On Behalf Of Andrew Lunn > > Sent: Tuesday, September 19, 2017 3:18 PM > > To: Raz

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

On Fri, Aug 25, 2017 at 08:47:00AM -0500, Larry Finger wrote: > On 08/24/2017 08:54 PM, Andrew Lunn wrote: > >netdev frowns upon debugfs. You should try to keep this altogether, > >making it easy to throw away before the driver is moved out of > >staging. > > > >

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

On Thu, Aug 24, 2017 at 04:28:08PM -0500, Larry Finger wrote: > The changes in this commit are also being sent to the main rtlwifi > drivers in wireless-next; however, these changes will also be useful for > any debugging of r8822be before it gets moved into the main tree. > > Use debugfs to dump

Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging

On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: > diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dpmcp.h > rename to drivers/bus/fsl-mc/dpmcp.h > diff --git

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On Wed, Nov 29, 2017 at 04:00:01PM +0530, Souptick Joarder wrote: Hi Souptick Please trim the code when giving reviews. We don't want to have to page through 8K lines of code it find a few comments mixed in. Just keep the beginning of the function you are commented on to make the context clear.

Re: [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote: > From: Carlos Munoz > > Add bindings for Common Ethernet Interface (BGX) block. > > Acked-by: Rob Herring > Signed-off-by: Carlos Munoz > Signed-off-by: Steven J. Hill

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On Wed, Nov 29, 2017 at 10:11:38PM +0300, Dan Carpenter wrote: > On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote: > > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv, > > >> struct port_status status) > > >> +{ > > >> + u64 data; > > >> +

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote: > +static int bgx_probe(struct platform_device *pdev) > +{ > + struct mac_platform_data platform_data; > + const __be32 *reg; > + u32 port; > + u64 addr; > + struct device_node *child; > + struct platform_device

Re: [PATCH v3 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

> + if (link_changed != 0) { > + struct port_status status; > + > + if (link_changed > 0) { > + netdev_info(netdev, "Link is up - %d/%s\n", > + priv->phydev->speed, > +

Re: [PATCH v3 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

> + priv->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0); > + priv->phy_mode = of_get_phy_mode(pdev->dev.of_node); > + /* If phy-mode absent, default to SGMII. */ > + if (priv->phy_mode < 0) > + priv->phy_mode = PHY_INTERFACE_MODE_SGMII; > + > + if

Re: [PATCH net-next] [RFC] dpaa2-eth: Move DPAA2 Ethernet driver from staging to drivers/net

> +static int dpaa2_eth_probe(struct fsl_mc_device *dpni_dev) > +{ > + struct device *dev; > + struct net_device *net_dev = NULL; > + struct dpaa2_eth_priv *priv = NULL; > + int err = 0; > + > + dev = _dev->dev; > + > + /* Net device */ > + net_dev =

Re: [PATCH net-next v2 2/2] dpaa2-eth: Move DPAA2 Ethernet driver from staging to drivers/net

On Wed, Aug 29, 2018 at 03:50:02AM -0700, Joe Perches wrote: > On Wed, 2018-08-29 at 04:42 -0500, Ioana Radulescu wrote: > > The DPAA2 Ethernet driver supports Freescale/NXP SoCs with DPAA2 > > (DataPath Acceleration Architecture v2). The driver manages > > network objects discovered on the fsl-mc

Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

On Mon, Mar 12, 2018 at 03:49:51AM -0500, Razvan Stefanescu wrote: > +static irqreturn_t ethsw_irq0_handler(int irq_num, void *arg) > +{ > + return IRQ_WAKE_THREAD; > +} > + > +static int ethsw_setup_irqs(struct fsl_mc_device *sw_dev) > +{ > + struct device *dev = _dev->dev; > +

Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> +static int port_netdevice_event(struct notifier_block *unused, > + unsigned long event, void *ptr) > +{ > + struct net_device *netdev = netdev_notifier_info_to_dev(ptr); > + struct netdev_notifier_changeupper_info *info = ptr; > + struct net_device

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> +/* For the moment, only flood setting needs to be updated */ > +static int port_bridge_join(struct net_device *netdev, > + struct net_device *upper_dev) > +{ > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > + struct ethsw_core *ethsw =

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> Hello Andrew, > > The current driver implementation uses only a single FDB for the switch, > so it is not possible configure multiple flooding domains to accommodate > ports partitioning. Ah, O.K. Rather than break somebodies network by wrongly flooding, it would be better to return

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

On Thu, Mar 15, 2018 at 01:56:42PM +0300, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: > > On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > > > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoC

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > switch objects discovered on the fsl-mc bus. A description of the driver > can

Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

On Tue, Mar 27, 2018 at 08:10:50AM -0500, Razvan Stefanescu wrote: > Previous implementation overwrites PCP value, assuming the default value is > 0, instead of 7. > > Avoid this by modifying helper function ethsw_port_set_tci() to > ethsw_port_set_pvid() and make it update only the vlan_id of

Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/

> +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig > @@ -0,0 +1,15 @@ > +config FSL_DPAA2_ETH > + tristate "Freescale DPAA2 Ethernet" > + depends on FSL_MC_BUS && FSL_MC_DPIO Could you add in here COMPILE_TEST? > + depends on NETDEVICES && ETHERNET With the move out of staging, i

Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

On Thu, Sep 27, 2018 at 07:12:27PM +0800, Yangbo Lu wrote: > This patch is to move DPAA2 PTP driver out of staging/ > since the dpaa2-eth had been moved out. > > Signed-off-by: Yangbo Lu > --- > drivers/net/ethernet/freescale/Kconfig |9 + >

Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

> > struct dprtc_cmd_get_irq - Putting pad at the beginning of a struct seems > > very > > odd. And it is not the only example. > > [Y.b. Lu] This should depended on MC firmware and APIs I think. Once the MC > improves this, the APIs could be updated to fix this. That is going to be hard to

Re: [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support

> I'll change these two to to get memory from kernel allocators instead > of using the stack. Thanks for let me know this. There appear to be other cases as well. Please review the whole driver. Thanks Andrew ___ devel mailing

Re: [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support

On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote: > +static int ksz_i2c_read_reg(struct i2c_client *client, u32 reg, u8 *val, > + unsigned int len) > +{ > + struct i2c_adapter *adapter = client->adapter; > + struct i2c_msg msg[2]; > + u8

Re: [PATCH 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote: > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos > --- > .../devicetree/bindings/net/dsa/ksz.txt | 50 +++

Re: [PATCH v2 1/2] net: dsa: ksz9477: add I2C managed mode support

On Sun, Dec 16, 2018 at 10:49:52AM +0100, Sergio Paracuellos wrote: > In this mode the switch device and the internal phys will be managed via > I2C interface. > > Signed-off-by: Sergio Paracuellos > --- > Changes v2: > - Use dev->txbuf as transmition buffer which is allocated using >

Re: [PATCH] dt-bindings: net: dsa: ksz9477: fix indentation for switch spi bindings

On Tue, Dec 25, 2018 at 12:45:11PM +0100, Sergio Paracuellos wrote: > Hi David, > > On Mon, Dec 24, 2018 at 11:15 PM David Miller wrote: > > > > From: Sergio Paracuellos > > Date: Sat, 22 Dec 2018 08:39:09 +0100 > > > > > Switch bindings for spi managed mode are using spaces instead of tabs. >

Re: [PATCH] staging: octeon-ethernet: fix incorrect PHY mode

> -static void cvm_set_rgmii_delay(struct device_node *np, int iface, int port) > +static void cvm_set_rgmii_delay(struct octeon_ethernet *priv, int iface, > + int port) > { > + struct device_node *np = priv->of_node; > u32 delay_value; > + bool rx_delay;

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* > > It includes the SPDX expression for GPL-2.0 and corrects the comment

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

> See the patch about all of this from Thomas on lkml yesterday for > why this is the case. Hi Greg Thanks for the info. I had not seen this, and i guess other have not as well. So here is a link to the patch. https://lkml.org/lkml/2019/1/28/1975 Andrew

Re: [PATCH 02/20] staging: wfx: add support for I/O access

On Thu, Sep 19, 2019 at 10:52:35AM +, Jerome Pouiller wrote: > +static int wfx_sdio_copy_from_io(void *priv, unsigned int reg_id, > + void *dst, size_t count) > +{ > + struct wfx_sdio_priv *bus = priv; > + unsigned int sdio_addr = reg_id << 2; > + int

Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

On Mon, Nov 04, 2019 at 01:20:09PM +0100, Greg KH wrote: > On Mon, Nov 04, 2019 at 07:22:20PM +0800, Jack Ping CHNG wrote: > > This driver enables the Intel's LGM SoC GSWIP block. > > GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions. > > It allows CPUs and other

Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

On Wed, Dec 11, 2019 at 08:10:34AM +0100, Krzysztof Hałasa wrote: > Arnd, > > Arnd Bergmann writes: > > > - Most other supported HDLC hardware that we supoprt is for the ISA or > > PCI buses. > > I would be surprised if there is anybody left with ISA sync serial > stuff, but the PCI hardware

Re: FW: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

> > We are trying to upstream the datapath code for Intel new NoC gateway > > (please refer to intel-gwdpa.txt at the end of the patch). It consists of > > ethernet, WIFI and passive optics handling. Since the code is quite huge, we > > have broken it into parts for internal review. > > > > As we

Re: [PATCH v2 net] staging: octeon: repair "fixed-link" support

> + if (priv->of_node && > of_phy_is_fixed_link(priv->of_node)) { > + if (of_phy_register_fixed_link(priv->of_node)) { > + netdev_err(dev, "Failed to register > fixed link for interface %d, port %d\n", > +

Re: [PATCH v2 net] staging: octeon: repair "fixed-link" support

> --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -892,6 +893,14 @@ static int cvm_oct_probe(struct platform_device *pdev) >

Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error

> diff --git a/drivers/staging/octeon/ethernet-rx.c > b/drivers/staging/octeon/ethernet-rx.c > index 2c16230..9ebd665 100644 > --- a/drivers/staging/octeon/ethernet-rx.c > +++ b/drivers/staging/octeon/ethernet-rx.c > @@ -69,15 +69,17 @@ static inline int cvm_oct_check_rcv_error(struct cvmx_wqe >

Re: [PATCH] staging: mt7621-dts: remove obsolete switch node

On Fri, Jan 08, 2021 at 10:51:55AM +0800, DENG Qingfang wrote: > This was for OpenWrt's swconfig driver, which never made it upstream, > and was also superseded by MT7530 DSA driver. What about Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt ? Should that also be removed?