On Thursday 16 October 2014 14:47:41 Greg Kroah-Hartman wrote:
From: Greg Kroah-Hartman gre...@linuxfoundation.org
The Android binder code has been stable for many years now. No matter
what comes in the future, we are going to have to support this API, so
might as well move it to the real
On Tuesday 21 October 2014 12:36:22 Pavel Machek wrote:
On Fri 2014-10-17 01:12:21, Greg Kroah-Hartman wrote:
On Thu, Oct 16, 2014 at 10:09:04AM -0700, John Stultz wrote:
On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
From: Greg Kroah-Hartman
On Thursday 30 October 2014 10:23:31 Xiong Zhou wrote:
From: Xiong Zhou jencce.ker...@gmail.com
struct logger_entry can be returned to userspace via ioctl,
so it is wrong to have a kuid_t member, fixing it to uid_t.
This was introduced by commit bd471258f2, to pass uidguid
type checks :
On Saturday 08 November 2014, Darshana Padmadas wrote:
Patchset documents correct and the deprecated vendor-prefix found by
checkpatch
warning and also documents information of device isl29028 for compatibility.
Patchset also includes corrected vendor-prefix and device name in compatible
On Wednesday 20 November 2013, Stephen Warren wrote:
+- #iommu-cells : Must be 1. This dictates the length of DMA specifiers in
+ client nodes' dmas properties. The specifier represents the DMA request
+ select value for the peripheral. For more details, consult the Tegra
TRM's
+
.
I'm definitely happy for any patches to go into maintainer
trees right away. Obviously the final patch cannot go in
until everything else gets merged first and I suspect there
will be a series of patches for maintainerless drivers that
will go along with it.
Arnd
Arnd Bergmann (30
() to
avoid a small race.
Both call sites still look fishy and need more work.
Signed-off-by: Arnd Bergmann arndb.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: de...@driverdev.osuosl.org
Cc: Bill Pemberton wf...@virginia.edu
---
drivers/staging/serqt_usb2/serqt_usb2.c | 17 +++--
1
interruptible_sleep_on is racy and going away. This replaces the
use in the gdm72xx driver with the appropriate
wait_event_interruptible_lock_irq.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: de...@driverdev.osuosl.org
---
drivers/staging
interruptible_sleep_on is racy and going away. This replaces the one
caller in the panel driver with the appropriate wait_event_interruptible
variant.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: de...@driverdev.osuosl.org
Cc: Willy Tarreau wi...@meta-x.org
Cc: Greg Kroah-Hartman gre
The LIRC support for sa1100 appears to have never worked
because it relies on header files that have never been
present in git history. Actually trying to build the
driver on an ARM sa1100 kernel fails, so let's just remove
the broken support.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Jarod
If the USB code is a loadable module, this driver cannot
be built-in. This adds an explicit dependency on CONFIG_USB
so that Kconfig can force sn9c102 to be a module in this case.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Luca Risolia luca.riso...@studio.unibo.it
Cc: Mauro Carvalho Chehab
'ieee80211_get_hdrlen' which is not static [enabled
by default]
This changes the driver to use 'static inline' instead, which happens
to be the correct annotation anyway.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Florian Schilhabel florian.c.schilha...@googlemail.com
An obviously missing 'select' statement, without this we
get a link error
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Jonathan Cameron ji...@kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/staging/iio/Kconfig | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
'
rather than 'extern inline'.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Henk de Groot pe1...@amsat.org
---
drivers/staging/wlags49_h2/wl_internal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_internal.h
b/drivers/staging/wlags49_h2
Hi Greg,
Here are a couple of simple fixes from my backlog of ARM
randconfig bugs. Nothing urgent, they can probably all go
into next for 3.17 after the merge window, but see for
yourself.
Arnd
Arnd Bergmann (5):
staging: lirc: remove sa1100 support
staging/iio
The lustre virtual block device cannot handle 64K pages and fails at compile
time. To avoid running into this error, let's disable the Kconfig option
for this driver in cases it doesn't support.
Reported-by: Dann Frazier dann.fraz...@canonical.com
Signed-off-by: Arnd Bergmann a...@arndb.de
On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
gfp_t gfp_mask, unsigned int order);
extern void devm_free_pages(struct device *dev, unsigned long addr);
+#ifdef CONFIG_HAS_IOMEM
void __iomem *devm_ioremap_resource(struct device *dev, struct
On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote:
Am 17.07.2014 11:20, schrieb Arnd Bergmann:
On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
gfp_t gfp_mask, unsigned int
order);
extern void devm_free_pages(struct device *dev
On Thursday 17 July 2014 11:56:58 Thierry Reding wrote:
On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote:
[...]
score should set HAS_IOMEM and doesn't
even have public compilers
This begs an interesting question. Should it be made a requirement to
have
On Thursday 17 July 2014 17:29:31 Chen Gang wrote:
COMPILE_TEST is a great tool in general, but it has its limits.
In particular, the case for !CONFIG_IOMEM is completely obscure
and we won't find any bugs by allowing more drivers to be built
in those configurations, but attempting to
On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote:
On 07/17/2014 11:20 AM, Arnd Bergmann wrote:
On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
gfp_t gfp_mask, unsigned int
order);
extern void devm_free_pages(struct device *dev
On Thursday 17 July 2014 12:58:55 Richard Weinberger wrote:
This is what I got upon trying earlier. I have not attempted to look into
why this is happening. Note this is on linux-next from yesterday,
not mainline as I incorrectly stated above.
In file included from
On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote:
On 7/17/2014 7:28 AM, Chen Gang wrote:
On 07/17/2014 06:48 PM, Arnd Bergmann wrote:
AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take
a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff
On Sunday 20 July 2014 17:45:40 Chen Gang wrote:
Next, I shall:
- Remove HAS_IOMEM and NO_IOMEM from kernel, firstly.
- Try to make dummy IOMEM functions for score architecture.
- Continue discussing with UML for it.
Oh, sorry, I forgot, after remove IOMEM from kernel,
[hijacking the thread since it has the right Cc list already, sorry]
I stumbled over this doing randconfig builds on linux-next
8--
From c11f54f1e5ea0557e076867ca31c90bcb20e3e0c Mon Sep 17 00:00:00 2001
From: Arnd Bergmann a...@arndb.de
Date: Tue, 29 Apr 2014 11:41:40 +0200
Subject
On Tuesday 29 April 2014 13:05:15 Ulf Hansson wrote:
On 29 April 2014 11:45, Arnd Bergmann a...@arndb.de wrote:
drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove':
:(.text+0x806480): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function
by excluding such condition when defining macro RTSX_USB_USE_LEDS_CLASS.
Signed-off-by: Roger Tseng rogera...@realtek.com
Yes, that should work, too.
Acked-by: Arnd Bergmann a...@arndb.de
---
drivers/mmc/host/rtsx_usb_sdmmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
On Thursday 08 May 2014 16:08:15 Roger wrote:
Would this patch be merged into linux-next or Lee's mfd.git
ib-mfd-mmc-memstick-3.16 branch?
It should get merged into whatever tree holds the existing patches, yes
By the way, should I resend my version?
Actually I found another issue with it
-by: Roger Tseng rogera...@realtek.com
Signed-off-by: Arnd Bergmann a...@arndb.de
Acked-by: Ulf Hansson ulf.hans...@linaro.org
---
v2 by Arnd: change the second #ifdef as well.
diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c
b/drivers/mmc/host/rtsx_usb_sdmmc.c
index e11fafa..5d3766e 100644
On Wednesday 14 January 2015 09:20:42 Patrick Boettcher wrote:
diff --git a/drivers/staging/android/sync_debug.c
b/drivers/staging/android/sync_debug.c
index 1532a86..9a2aaf8 100644
--- a/drivers/staging/android/sync_debug.c
+++ b/drivers/staging/android/sync_debug.c
@@ -96,7 +96,8 @@
-by: Arnd Bergmann a...@arndb.de
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 3c7ea95dd9f9..dbbb2f879a29 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -1250,7 +1250,7 @@ err_enable:
return -ENODEV;
}
-static
interface calls.
Signed-off-by: Arnd Bergmann a...@arndb.de
Fixes: 99d56ff7c1c (staging/lustre: Always try kmalloc first for
OBD_ALLOC_LARGE)
diff --git a/drivers/staging/lustre/lustre/include/obd_support.h
b/drivers/staging/lustre/lustre/include/obd_support.h
index 379266d6bcd9..c0136ee778e3 100644
On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote:
On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote:
On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote:
/* WMM spec P.11: The minimum value for AIFSN shall be 2
*/
qos_param-aifs
On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote:
/* WMM spec P.11: The minimum value for AIFSN shall be 2 */
qos_param-aifs[aci] = (qos_param-aifs[aci] 2) ?
2:qos_param-aifs[aci];
- qos_param-cw_min[aci] = ac_params-ecw_min_max 0x0F;
+
.
Some minor changes are included that are necessary to remove
other code.
Signed-off-by: Arnd Bergmann a...@arndb.de
diff --git a/drivers/staging/wilc1000/Makefile
b/drivers/staging/wilc1000/Makefile
index 84bd975ff3be..4eda4cc69486 100644
--- a/drivers/staging/wilc1000/Makefile
+++ b/drivers
The EXPORT_SYMTAB symbol has not been used in Linux for a very
long time, the driver does not need to set it.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/Makefile
b
it with some normal kernel API.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_msgqueue.c | 9 -
drivers/staging/wilc1000/wilc_msgqueue.h | 30 --
drivers/staging/wilc1000/wilc_osconfig.h | 3 ---
drivers/staging/wilc1000
hangs after
receiving a signal, as the original code did by looping around
down_interruptible.
The semaphores still need to be turned into mutexes as a
follow-up step.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging
The driver provides wrappers for a lot of string operations.
Some of them are unused, while others should be replaced
with normal kernel functions.
This replaces the unused ones for now, and leaves the other
ones for a later cleanup.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers
On Sunday 31 May 2015 08:58:13 Greg KH wrote:
On Sat, May 30, 2015 at 12:09:23PM +0530, Sudip Mukherjee wrote:
On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
The abstraction for time in this driver is completely
unused, so remove it.
Signed-off-by: Arnd Bergmann
The driver has its own API for semaphores. This should
be replaced with mutexes and completions, but for the moment
we can start by removing the obviously unused parts.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000
and succeeding with that.
Arnd
Arnd Bergmann (12):
staging: wilc1000: remove time wrapper
staging: wilc1000: remove unused string functions
staging: wilc1000: simplify msgqueue code
staging: wilc1000: remove unused memory handling code
staging: wilc1000: simplify semaphore wrapper
I have crossed off one item on the list, but found a few others that should
not get lost, so here is an update of the wilc1000 list
Signed-off-by: Arnd Bergmann a...@arndb.de
diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
index 5dfeb3eda599..95199d80a3e4 100644
touching them anyway.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/host_interface.c | 32 ---
drivers/staging/wilc1000/host_interface.h | 24 -
drivers/staging/wilc1000/linux_mon.c | 2 +-
drivers/staging
The driver has a simple wrapper around msleep, as well as
a more advanced sleep function that is unused. This removes
the unused code and the options to turn the feature on or
off.
A follow-up should rework the code to use msleep directly.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers
All the remaining features from the OS abstraction layer
are not used at all in the driver, so we can just remove
the remaining references to them.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_errorsupport.h | 17
drivers/staging/wilc1000/wilc_event.h
The abstraction for time in this driver is completely
unused, so remove it.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000/wilc_oswrapper.h | 5 -
drivers/staging
This avoids the remaining warnings that one gets on a normal
build: unused variables, unused labels, and invalid printk
format strings.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/linux_wlan.c | 8 ++--
drivers/staging/wilc1000/linux_wlan_spi.c | 3
The driver contains its own abstraction for memory allocation,
most of it unused. This removes the unused parts, but the
rest should also be removed later.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_memory.c| 5 --
drivers/staging/wilc1000/wilc_memory.h
an interface that works. It also
adds all the missing dependencies for networking infrastructure
(cfg80211, wext, and ipv4).
In order to make it readable, I also took the liberty of re-indenting
the Kconfig file to the normal conventions.
Signed-off-by: Arnd Bergmann a...@arndb.de
diff --git
The driver contains its own abstraction for memory allocation,
most of it unused. This removes the unused parts, but the
rest should also be removed later.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_memory.c| 5 --
drivers/staging/wilc1000/wilc_memory.h
hangs after
receiving a signal, as the original code did by looping around
down_interruptible.
The semaphores still need to be turned into mutexes as a
follow-up step.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/coreconfigurator.c | 29 +---
drivers/staging
The driver has a simple wrapper around timer_list, and an
optional but unused feature to make the timer periodic.
This removes support for the periodic timer and simplifies
the code around timers.
A follow-up should replace the remaining wrapper with
open-coded timers.
Signed-off-by: Arnd
it with some normal kernel API.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_msgqueue.c | 9 -
drivers/staging/wilc1000/wilc_msgqueue.h | 30 --
drivers/staging/wilc1000/wilc_osconfig.h | 3 ---
drivers/staging/wilc1000
The driver provides wrappers for a lot of string operations.
Some of them are unused, while others should be replaced
with normal kernel functions.
This replaces the unused ones for now, and leaves the other
ones for a later cleanup.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers
The driver has a simple wrapper around msleep, as well as
a more advanced sleep function that is unused. This removes
the unused code and the options to turn the feature on or
off.
A follow-up should rework the code to use msleep directly.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers
The EXPORT_SYMTAB symbol has not been used in Linux for a very
long time, the driver does not need to set it.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/Makefile
b
The driver has its own API for semaphores. This should
be replaced with mutexes and completions, but for the moment
we can start by removing the obviously unused parts.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000
The driver version is meaningless, and in particular does not
have to be passed from the Makefile. This removes the macros,
but leaves the behavior of printing the 10.2 version untouched
for the moment.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/Makefile | 6
This avoids the remaining warnings that one gets on a normal
build: unused variables, unused labels, and invalid printk
format strings.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/linux_wlan.c | 8 ++--
drivers/staging/wilc1000/linux_wlan_spi.c | 3
touching them anyway.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/host_interface.c | 32 ---
drivers/staging/wilc1000/host_interface.h | 24 -
drivers/staging/wilc1000/linux_mon.c | 2 +-
drivers/staging
For code that is integrated into mainline Linux, checks for
the OS platform make no sense, because we know that we
are on Linux.
This removes all checks and the associated dead code.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/Makefile | 3 +--
drivers
For code that is integrated into mainline Linux, checks for
the kernel version make no sense, because we know which version
we are compiling against.
This removes all checks and the associated dead code.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/linux_wlan.c
Hi Greg,
This turned out to be more work than the first version, but I
think I've split it up enough sensibly to allow review, and
I've added a few more patches at the end.
Arnd
Arnd Bergmann (16):
staging: wilc1000: remove linux version checks
staging: wilc1000: remove platform
All the remaining features from the OS abstraction layer
are not used at all in the driver, so we can just remove
the remaining references to them.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_errorsupport.h | 17
drivers/staging/wilc1000/wilc_event.h
to replace that code with more appropriate types.
Here struct timeval is replaced with ktime_t.
Signed-off-by: Ksenija Stanojevic ksenija.stanoje...@gmail.com
Reviewed-by: Arnd Bergmann a...@arndb.de
___
devel mailing list
de...@linuxdriverproject.org
The patch to split out bus modules causes new valid build warnings without this.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index 8a5f4673c5d0..fe3b464f0d5c 100644
--- a/drivers/staging/wi
On Thursday 22 October 2015 16:59:01 Shraddha Barke wrote:
> On Thu, 22 Oct 2015, Arnd Bergmann wrote:
>
> > On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote:
> >> On Thu, 22 Oct 2015, Arnd Bergmann wrote:
> >>
> >>> On Thursday 22
On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote:
> On Thu, 22 Oct 2015, Arnd Bergmann wrote:
>
> > On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote:
> >> These patches remove the definitions of functions which are not used.
> >>
> >> Shr
On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote:
> These patches remove the definitions of functions which are not used.
>
> Shraddha Barke (2):
> Staging: lustre: ptlrpc: Remove unused functions
> Staging: lustre: obdclass: Remove unused functions
>
>
On Wednesday 21 October 2015 19:06:52 glen lee wrote:
> Hi arnd,
>
> Thanks for the all the patches.
> About the patch ( use proper naming for global symbols ),
> We are planning to use this driver not only for wilc1000 but also for
> other atmel wireless driver. I'd appreciate if you could use
On Wednesday 11 November 2015 09:54:57 Andy Shevchenko wrote:
> > diff --git a/drivers/staging/wilc1000/linux_wlan_common.h
> > b/drivers/staging/wilc1000/linux_wlan_common.h
> > index f2ea8280b8f8..72b524a98cba 100644
> > --- a/drivers/staging/wilc1000/linux_wlan_common.h
> > +++
On Tuesday 10 November 2015 15:47:02 Joe Perches wrote:
> On Wed, 2015-11-11 at 00:42 +0100, Arnd Bergmann wrote:
> > A recent cleanup added a reference to struct net_device, but
> > that structure is not always visible in the context of the
> > declaration, so we may get
inside
parameter list
s32 wilc_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
This adds a forward-declaration for the structure name to avoid
that error.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
Fixes: d5382219138d ("staging: wilc1000: host_int_init: add argument
The SPI and SDIO specific code is now separate enough that
we just need to restructure the Makefile and Kconfig logic
a bit and export a couple of symbols from the common module
to have separate bus glue drivers.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/K
modules.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++-
drivers/staging/wilc1000/linux_wlan_sdio.c| 3 ++-
drivers/staging/wilc1000/linux_wlan_spi.c | 2 +-
drivers/staging/wilc1000/wilc_sdio.c
also change arguments slightly to pass the device,
as we are already touching those lines and the change will be needed
later to remove the global variables.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c | 22 +-
drivers/s
of the driver
that does not have an instance pointer at hand. Changing those
would be a follow-up step.
There are a few other globals that will have to get moved
into struct wilc at a later point.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/host_interface.c
.
All other locations that check for the interrupt method are turned
into runtime checks based on the gpio number (>=0) or the interrupt
number (>0).
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/Makefile | 1 -
drivers/staging/wilc1000/
In order to avoid some of the #ifdefs, this passes the io_type
and device pointer as an argument to wilc_netdev_init.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c | 18 --
drivers/staging/wilc1000/linux_wlan_sdio.c
variables in favor of retrieving them from the wilc_dev
variable that will eventually get passed through all functions
instead of using a global.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c| 6 +-
drivers/staging/wilc1000/linux_wlan_common.h
struct wilc has two pointers to store the device, one for sdio_func
and one for spi_device. By changing the pointer to a 'struct device',
we can simplify the logic and avoid a few #ifdefs.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c
The last remaining user of WILC_SDIO macro checks for the correct
time to wait in an interrupt for the PLL to settle. We can
replace this with a runtime check and remove both WILC_SDIO and
WILC_SPI, as we no longer need conditional compilation based on
the hardware type.
Signed-off-by: Arnd
wilc_create_wiphy tries to get a pointer to a device from the
global wilc_sdio_func variable. This is a layering violation
and we can use the wilc_dev->dev pointer instead.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
driver
All symbols that are only referenced in the file that defines
them can be declared 'static' to avoid namespace pollution,
to produce better object code, and to make the source more
readable.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/Makefile
the respective
hardware specifics using device tree or platform data and make
the driver handle this is a more general way.
This removes the empty stubs.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c | 40 ---
1 file c
The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so
this is where the init and exit functions should be. Splitting this up
enables further cleanups, including eventually allowing both modules
to be built together.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
d
A number of symbols in the wilc1000 driver are completely unused
and can be removed.
This includes two variables that are only written but not read.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/host_interface.c | 295 --
drivers/s
, this
first changes over the only other user.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index f1e70b
that are also not needed here.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 84 +++
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 83 --
2 files changed, 84 insertions(+), 83 deletions(-)
diff
I have rebased the patches once more on top of a lot of renames,
and would prefer not to rebase them again. This is the series of
fixups that I've posted before, now for today's staging-testing
branch.
Please apply.
Arnd Bergmann (20):
staging/wilc1000: add struct net_device declaration
'extern' declarations belong into a header file rather than
a .c file, to ensure that the definition matches the declaration.
This moves all declarations into a header file that seems
most appropriate for it.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wi
wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c
to have knowledge of the specific sdio and spi front-ends. This
removes the structure and places io_type directly inside the struct wilc.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_
On Tuesday 10 November 2015 16:02:48 Greg Kroah-Hartman wrote:
> On Wed, Nov 11, 2015 at 12:42:21AM +0100, Arnd Bergmann wrote:
> I think this is already fixed in my staging-testing branch, right?
Ah right. I only got it with some rare randconfig builds, and assumed
the problem was
On Thursday 12 November 2015 19:05:41 glen lee wrote:
> Hi arnd,
>
> I appreciate the patches.
> I did test this patch series on h/w which is arm based MCU.
> From this patch wilc is not working properly. After downloading firmware,
> the firmware cannot start and it fails.
> I double check
On Friday 13 November 2015 16:49:22 glen lee wrote:
>
> Hi arnd,
>
> I found this. These should be like this. It works fine.
> + .hif_block_tx_ext = sdio_write,
> + .hif_block_rx_ext = sdio_read,
>
> also, wilc_hif_spi need to be fixed together like this.
> + .hif_block_tx_ext
of the driver
that does not have an instance pointer at hand. Changing those
would be a follow-up step.
There are a few other globals that will have to get moved
into struct wilc at a later point.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/host_interface.c
.
All other locations that check for the interrupt method are turned
into runtime checks based on the gpio number (>=0) or the interrupt
number (>0).
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/Makefile | 1 -
drivers/staging/wilc1000/
In order to avoid some of the #ifdefs, this passes the io_type
and device pointer as an argument to wilc_netdev_init.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/staging/wilc1000/linux_wlan.c | 18 --
drivers/staging/wilc1000/linux_wlan_sdio.c
that
Glen has successfully tested.
Please disregard the earlier version and apply this one.
Arnd
Arnd Bergmann (19):
staging/wilc1000: remove unused functions
staging/wilc1000: make symbols static if possible
staging/wilc1000: use proper naming for global symbols
staging/wilc
1 - 100 of 624 matches
Mail list logo
