[PATCH] staging:nvec:nvec_ps2.c: Prefering kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...)

Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...) as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/nvec/nvec_ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec

[PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

Macro argument 'a' may be better as '(a)' to avoid precedence issues as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/fwserial/fwserial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fwserial/fwserial.

[PATCH 1/2] staging: vt6656: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal --- drivers/staging/vt6656/firmware.c | 34 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/rf.c | 12 ++-- drive

[PATCH 2/2] staging: vt6656: Alignment match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal --- drivers/staging/vt6656/rxtx.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c

[PATCH] staging: xgifb: function definition argument should also have an identifier name

function definition argument 'struct vb_device_info *' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb

[PATCH] staging: xgifb: function definition argument should also have an identifier name

function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init

[PATCH] staging: xgifb: function definition argument should also have an identifier name

function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init

[PATCH] staging: xgifb: function definition argument should also have an identifier name'

function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init

[PATCH] staging: xgifb: function definition argument should also have an identifier name'

function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/xgifb

[PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/xgifb

[PATCH] staging: ks7010: Block comments use * on subsequent lines

Some of the block comments styles are not encouraged: for example: /* block comment without introductory * */ and /* * block comment with line terminating */ Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks7010_sdio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

Unnecessary parentheses as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index

[PATCH] Staging: ks7010: There should be no spaces at the start of a line

The following patch the checkpatch.pl warning: drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff

[PATCH v2 1/2] staging: ks7010: Unnecessary parentheses should be avoided

Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff

[PATCH v2 2/2] staging: ks7010: Unnecessary parentheses should be avoided

Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff

[PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed.

>bssid[0]), ETH_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff -

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed to make coder nicer.

>bssid[0]), ETH_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/k

[PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed to make coder nicer.

>bssid[0]), ETH_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/sta

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed.

>bssid[0]), ETH_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 20 insertions(+), 20 deletions(-) diff -

[PATCH v2 1/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

H_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- Changes in v2: - Make the commit message more clearer. - And correct the error on line number 116 in file drivers/staging/ks7010/ks_hostif.c changes:- ap = priv->current_ap;

[PATCH 1/1] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

H_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/k

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

H_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drive

[PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

Error was reported by checkpatch.pl as WARNING: Avoid multiple line dereference... if there is boolean operator then it is fixed by Splitting line at boolean operator. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/XGI_main_26.c | 15 +-- drivers/staging/xgifb/vb_setmode.c

[PATCH] staging: xgifb: function definition argument should have an identifier name

function definition argument like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_setmode.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/d

[PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

function definition argument like 'struct vb_device_info *','unsigned long' etc. should also have an identifier name. Signed-off-by: Arushi Singhal Changes in v2: - By mistake one irrelevant line was added which is removed in this patch. --- drivers/staging/xgi

[PATCH v3] staging: xgifb: function definition argument should also have an identifier name

function definition argument like 'struct vb_device_info *','unsigned long' etc. should also have an identifier name. Signed-off-by: Arushi Singhal --- Changes in v2: - By mistake one irrelevant line was added which is removed in this patch. - write the changes done

[PATCH] staging: xgifb: function prototype argument should have an identifier name

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal --- Changes in v3: - By mistake one irrelevant line was added which is removed in this patch. - write the changes done in

[PATCH v3 1/1] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

H_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- Changes in v3: - Commit message made more accurate and as per the changes. - previously versions were not marked. --- drivers/staging/ks7010/ks_hostif.c | 24 1 file

[PATCH v3 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

H_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- Changes in v3: - Commit message made more accurate and as per the changes. - previously versions were not marked. --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- drivers/stag

[PATCH v3] staging: xgifb: function prototype argument should also have an identifier name

function prototype argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- changes in v3 -make the subject title more relevant. -change the identifier of struct vb_device_info to XGI_Pr. --- drivers/sta

[PATCH] staging: ks7010: codes in the comments are removed

Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in thos patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH v2] staging: xgifb: correct the multiple line dereference

line exceeding 80 characters length. Signed-off-by: Arushi Singhal --- changes in v2 - changes done such that no other errors can generate. --- drivers/staging/xgifb/XGI_main_26.c | 21 + drivers/staging/xgifb/vb_setmode.c | 14 +++--- 2 files changed, 16 insertions

[PATCH v3] staging: xgifb: correct the multiple line dereference

Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal --- changes in v3 - changes done such that no other errors ca

[PATCH v2] staging: ks7010: remove code in comments.

Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH v4] staging: xgifb: correct the multiple line dereference

Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal --- changes in v4 - changes done such that no other errors ca

[PATCH v4 1/2] staging: ks7010: Unnecessary parentheses are removed.

H_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- Changes in v4: - Commit message made more accurate and as per the changes. drivers/staging/ks7010/ks_hostif.c | 24 1 file changed, 12 insertions(+), 12 deletions(-)

[PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

H_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- Changes in v4: - Commit message made more accurate and as per the changes. - previously versions were not marked. drivers/staging/ks7010/ks_hostif.c | 44 ++-

[PATCH v5] staging: xgifb: correct the multiple line dereference

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters. Signed-off-by: Arushi Singhal --- changes in v5

[PATCH v6] staging: xgifb: correct the multiple line dereference

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters. Signed-off-by: Arushi Singhal --- changes in v6

[PATCH v7] staging: xgifb: correct the multiple line dereference

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable. Signed-off-by: Arushi Singhal --- changes in v7 - Improve the coding style. - Introduced new variables. drivers/staging/xgifb/XGI_main

[PATCH] staging: ks7010: Unnecessary parentheses removed and improved coding style.

mcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index a533

[PATCH] staging: ks7010: Unnecessary parentheses removed and improved coding style.

mcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 23 +++ drivers/staging/ks7010/ks_wlan_net.c | 18 +- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/staging/

[PATCH] staging: xgifb: Improved coding style

New variable is added to make the code more readable. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/XGI_main_26.c | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26

[PATCH] staging: iio: ad9832: Move header file content to source file

The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: Arushi Singhal --- drivers/staging/iio/frequency/ad9832.c | 100 +- drivers/staging/iio/frequency/ad9832.h | 128

[PATCH] staging: speakup: Comparison to NULL could be written

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speakup/kobjects.c | 2 +- drivers/staging/speakup/main.c | 38

[PATCH] staging: speakup:indentation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index 1a3e34880ac1..11f1418b4006 100644 --- a

[PATCH] staging: speakup: Alignment match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 38 +++--- 2 files changed, 20 insertions(+), 20 deletions(-) di

[PATCH v2] staging: speakup: Comparison to NULL could be written

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal --- changes in v2 - fixed coding style error and upto the coding style. drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speakup

[PATCH] staging: speakup: Alignment match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- changes in v2 - Aligned the lines which are not aligned in previous patch. drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobje

[PATCH 1/4] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index

[PATCH 2/4] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-

[PATCH 3/4] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h index

[PATCH 4/4] staging: speakup: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/stagi

[PATCH 2/4] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-

[PATCH 0/4] Fix multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator staging: speakup: identation should use tabs staging: speakup: Alignment should match

[PATCH 1/4] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index

[PATCH 3/4] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h index

[PATCH 4/4] staging: speakup: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/stagi

[PATCH] staging: speakup: else is not generally useful after a break or return

fixed checkpatch.pl warning: else is not generally useful after a break or return. Removed the else without affecting the logic. Dead code is also eliminated. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/keyhelp.c | 53 ++- 1 file changed, 19

[PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c

[PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul

This patch fixes "simple_strtoul is obsolete, use kstrtoul instead" warning. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c| 4 ++-- drivers/staging/speakup/main.c| 2 +- drivers/staging/speakup/varhandlers.c | 2 +- 3 files changed, 4 insert

[PATCH 3/6] staging: speakup: Logical continuations should be on the previous line

This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/speakup

[PATCH 0/6] multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: Add blank line after function/struct/union/enum declarations staging: speakup: simple_strtoul is replaced with kstrtoul staging: speakup: Logical continuations should be

[PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement

This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH 4/6] staging: speakup: Blank lines removed after an open brace '{'

Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c ind

[PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/stagi

[PATCH 0/6] multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: Add blank line after function/struct/union/enum declarations staging: speakup: Logical continuations should be on the previous line staging: speakup: Blank lines removed

[PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c

[PATCH 6/6] staging: speakup: Comparison to NULL could be written

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/varhandlers.c | 6 +++--- 2 files changed, 4 insertions(+), 4

[PATCH 4/6] staging: speakup: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/stagi

[PATCH 5/6] staging: speakup: fixes braces {} should be used on all arms of this statement

This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 3/6] staging: speakup: Blank lines removed after an open brace '{'

Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c ind

[PATCH 2/6] staging: speakup: Logical continuations should be on the previous line

This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/speakup

[PATCH 0/6] multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues. Arushi Singhal (6): staging: speakup: fixes braces {} should be used on all arms of this statement staging: speakup: Avoid multiple assignments on same line staging: speakup: identation should use tabs staging: wilc1000

[PATCH 1/6] staging: speakup: fixes braces {} should be used on all arms of this statement

This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- drivers/staging/speakup/speakup_decext.c | 6 +++--- drivers/staging/speakup/speakup_decpc.c

[PATCH 2/6] staging: speakup: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/ma

[PATCH 4/6] staging: wilc1000: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_spi.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperati

[PATCH 5/6] staging: wilc1000: function prototype argument should have identifier name

function prototype argument should have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/wilc_wlan.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging

[PATCH 6/6] staging: wilc1000: Logical continuations should be on the previous line

This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/wilc_spi.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++-- 2 files changed, 8 insertions

[PATCH 3/6] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_decpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index

[PATCH 0/3] multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in sm750fb driver. Arushi Singhal (3): staging: sm750fb: fixes add blank line after function/struct/union/enum declarations staging: sm750fb: function prototype argument should have an identifier name staging: sm750fb: Alignment

[PATCH 2/3] staging: sm750fb: function prototype argument should have an identifier name

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/ddk750_mode.h| 2 +- drivers/staging/sm750fb/

[PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_display.h | 1 + drivers/staging/sm750fb/ddk750_mode.h| 2 ++ drivers/staging/sm750fb

[PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_mode.c | 69 +-- 1 file changed, 34 insertions(+), 35 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750

[PATCH] staging: ks7010: removed code in comments.

Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH 0/4] staging: speakup: checkpatch guided cleanups

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Comparison to NULL could be written staging: speakup:indentation should use tabs staging: speakup: Alignment match open parenthesis staging: speakup: Placed Logical on the

[PATCH 1/4] staging: speakup: Comparison to NULL could be written

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal --- changes in v2 - fixed coding style error and upto the coding style. --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging

[PATCH 2/4] staging: speakup:indentation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index 1a3e34880ac1..11f1418b4006 100644 --- a

[PATCH 3/4] staging: speakup: Alignment match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- changes in v2 - Aligned the lines which are not aligned in previous patch. --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobje

[PATCH 4/4] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index

[PATCH] staging: speakup: fix "Alignment match open parenthesis"

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 40 +++--- 2 files changed, 21 insertions(+), 21 deletions(-) di

[PATCH] staging: speakup: Simplify NULL comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +-

[PATCH 0/6] staging: speakup: multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: fix "Alignment match open parenthesis" staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator stagin

[PATCH 1/6] staging: speakup: fix "Alignment match open parenthesis"

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 40 +++--- 2 files changed, 21 insertions(+), 21 deletions(-) di

[PATCH 2/6] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index

[PATCH 3/6] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-

[PATCH 4/6] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h index

[PATCH 6/6] staging: speakup: Add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c

[PATCH 5/6] staging: speakup: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/stagi

  1   2   3   4   >