[PATCH 1/4] staging: gasket: add SPDX-License-Identifier tag

Use GPL-2.0 based on the license text in each of the files. Remove license "boiler-plate". Signed-off-by: Felix Siegel --- drivers/staging/gasket/apex.h | 1 + drivers/staging/gasket/apex_driver.c | 9 + drivers/staging/gasket/gasket.h

[PATCH 2/4] staging: gasket: Move open-curly brace to match kernel code style

Move open open-curly brace to the next line following function definition to match the kernel's coding style Signed-off-by: Felix Siegel --- drivers/staging/gasket/gasket_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_core.c b/dr

[PATCH 3/4] staging: gasket: fix multi line comments style

This patch fixes checkpatch.pl warnings: WARNING: Block comments should align the * on each line Signed-off-by: Felix Siegel --- drivers/staging/gasket/gasket_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers

[PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string - Style

Changed logging statements to use %s and __func__ instead of hard coding the function name in a string. Signed-off-by: Felix Siegel --- drivers/staging/gasket/apex_driver.c | 15 --- drivers/staging/gasket/gasket_core.c | 11 ++- drivers/staging/gasket

Re: [PATCH 1/4] staging: gasket: add SPDX-License-Identifier tag

On Thu, 12 Jul 2018 21:42:49 +0200 Greg Kroah-Hartman wrote: > On Thu, Jul 12, 2018 at 09:27:12PM +0200, Felix Siegel wrote: > > Use GPL-2.0 based on the license text in each of the files. > > Remove license "boiler-plate". > > > > Signed-off-by: Felix Sieg

Re: [PATCH 3/4] staging: gasket: fix multi line comments style

On Thu, 12 Jul 2018 21:53:54 +0200 Greg Kroah-Hartman wrote: > On Thu, Jul 12, 2018 at 09:27:14PM +0200, Felix Siegel wrote: > > This patch fixes checkpatch.pl warnings: > > > > WARNING: Block comments should align the * on each line > > Signed-off-by: Felix Sieg

Re: [PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string - Style

> Function calls that do nothing but log "Look at this function I just > entered/exited!" need to just be deleted entirely, as ftrace should be > used instead. > > Care to do that here, and then send a patch for the remaining messages > that do need __func__? Sure. I hope this is how you meant it.

[PATCH v2 1/2] staging: gasket: remove "function entered" log messages

Remove log messages that solely print the function's name everytime it is called. Signed-off-by: Felix Siegel --- drivers/staging/gasket/apex_driver.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c

[PATCH v2 2/2] staging: gasket: Use __func__ instead of hardcoded string - Style

Changed logging statements to use %s and __func__ instead of hard coding the function name in a string. Signed-off-by: Felix Siegel --- drivers/staging/gasket/apex_driver.c | 7 --- drivers/staging/gasket/gasket_core.c | 8 +--- drivers/staging/gasket/gasket_ioctl.c