Fix checkpatch warnings regarding the use of symbolic permissions.
Where the MOST_CHANNEL_ATTR macro is used, convert to octal
permissions over symbolic.
Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and
update the show/store function names appropriately.
Signed-off-by: Jason
Fix checkpatch warnings regarding the use of symbolic permissions.
Where the MOST_CHANNEL_ATTR macro is used, convert to octal permissions
over symbolic.
Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and
update the show/store function names appropriately.
Signed-off-by: Jason
On Thu, Nov 24, 2016 at 03:10:29PM -0700, Jason Litzinger wrote:
> Fix checkpatch warnings regarding the use of symbolic permissions.
>
> Where the MOST_CHANNEL_ATTR macro is used, convert to octal permissions
> over symbolic.
>
> Where _ATTR is used directly, replace with
> This is fine, but the fact that the most subsystem feels like it has to
> have its own attribute type is the big problem with this file, that
> should not be needed at all, and hopefully will be fixed up someday soon
> (i.e. it's a requirement before it can get out of staging...)
Ok, couple
value copy. Is there any reason not to embed a const
pointer?
Regards,
Jason Litzinger
Signed-off-by: Jason Litzinger <jlitzinger...@gmail.com>
---
Note this leaves in place three checkpatch warnings regarding CamelCase.
drivers/staging/wilc1000/host_interface.c
> + strStaParams.ht_capa = *params->ht_capa;
Doh, that's completely wrong. I had a few iterations of this and sent
the wrong version. There's an embedded array in that struct (not an
embedded struct as I though during one read through).
Will fix and re-send, sorry for the
On Tue, Apr 25, 2017 at 10:54:16PM -0600, Jason Litzinger wrote:
> > + strStaParams.ht_capa = *params->ht_capa;
> Doh, that's completely wrong. I had a few iterations of this and sent
No, it wasn't. The PATCH RFC I sent initally is correct. Apologies, had a
t sent out tonight (tomorrow
latest) after I update my trees and do the usual build/apply/test cycle.
Thanks,
-Jason Litzinger
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
-off-by: Jason Litzinger <jlitzinger...@gmail.com>
---
Note this leaves in place three checkpatch warnings regarding CamelCase.
This was originally presented as an RFC PATCH:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2017-April/105138.html
For completeness, with r
