[PATCH] Staging: comedi: ssv_dnp: fixed style line length warning

Fixed style line length warning detected by checkpatch.pl in the file ssv_dnp.c. Signed-off-by: Javier Martinez --- drivers/staging/comedi/drivers/ssv_dnp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c b/drivers/staging/comedi

[PATCH] Staging: comedi: ssv_dnp: fixed style line length warning

Fixed style line length warning detected by checkpatch.pl in the file ssv_dnp.c. Signed-off-by: Javier Martinez --- drivers/staging/comedi/drivers/ssv_dnp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c b/drivers/staging/comedi

[PATCH] Staging: octeon-usb: octeon-hcd.c: Remove boiler plate and add SPDX

Removed massive boiler plate text at top of the file and instead replaced it with a simple SPDX license identifier. Signed-off-by: Javier Martinez --- drivers/staging/octeon-usb/octeon-hcd.c | 47 ++--- 1 file changed, 2 insertions(+), 45 deletions(-) diff --git a/drivers

[PATCH] Staging: octeon-usb: octeon-hcd.c: style fix line length warning

Checkpatch.pl issued a warning in the top of the commment within octeon-hcd.c. This is a simple style fix for that. Signed-off-by: Javier Martinez --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon

[PATCH] Staging: comedi: ssv_dnp: Remove unnecessary comment

Removal of a comment that was not needed at all. We can clearly see that they are include/header files. Signed-off-by: Javier Martinez --- drivers/staging/comedi/drivers/ssv_dnp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c b/drivers/staging

[PATCH 0/4] [media] Media entity cleanups and build fixes

were build tested using allyesconfig and x-building the ARM Exynos and OMAP defconfigs + the needed media config options. Best regards, Javier [0]: http://www.mail-archive.com/linux-media@vger.kernel.org/msg91330.html Javier Martinez Canillas (4): [media] staging: omap4iss: get entity ID using

[PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

The struct media_entity does not have an .id field anymore since now the entity ID is stored in the embedded struct media_gobj. This caused the omap4iss driver fail to build. Fix by using the media_entity_id() macro to obtain the entity ID. Signed-off-by: Javier Martinez Canillas jav

[PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent

-graph_obj.mdev @@ struct media_entity *link; @@ - link-source-entity-parent + link-source-entity-graph_obj.mdev @@ struct exynos_video_entity *ve; @@ - ve-vdev.entity.parent + ve-vdev.entity.graph_obj.mdev Suggested-by: Mauro Carvalho Chehab mche...@osg.samsung.com Signed-off-by: Javier Martinez Canillas

[PATCH 06/18] staging: mt29f_spinand: Export OF module alias information

better to also export the OF table even when is unused now to prevent breaking module loading when the core changes. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

Hello Laurent, On 08/21/2015 02:15 AM, Laurent Pinchart wrote: Hi Javier, On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote: On 08/20/2015 08:37 PM, Laurent Pinchart wrote: On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: The struct media_entity does

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

Hello Laurent, On 08/20/2015 08:37 PM, Laurent Pinchart wrote: Hi Javier, Thank you for the patch. On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: The struct media_entity does not have an .id field anymore since now the entity ID is stored in the embedded struct

Re: [PATCH 0/4] [media] Media entity cleanups and build fixes

Hello Hans, On 08/20/2015 02:41 PM, Hans Verkuil wrote: On 08/19/15 17:35, Javier Martinez Canillas wrote: Hello, This series contains a couple of build fixes and cleanups for the Media Controller framework. The goal of the series is to get rid of the struct media_entity .parent member

Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers

Hello Brian, On 08/20/2015 11:11 PM, Brian Norris wrote: On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches ^^^ I'm dying to know how this sentence ends :) Sigh, I did some last minute restructuring

[PATCH] Staging: ste_rmi4: Remove unnecessary MODULE_ALIAS()

The driver has a I2C device id table that is used to create the modaliases which already contains synaptics_rmi4_ts. So the alias is not needed. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com --- drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 1 - 1 file changed, 1 deletion

Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information

Hello Jonathan, On 08/22/2015 07:59 PM, Jonathan Cameron wrote: > On 20/08/15 08:07, Javier Martinez Canillas wrote: >> The SPI core always reports the MODALIAS uevent as "spi:" >> regardless of the mechanism that was used to register the device >> (i.e:

[PATCH 1/5] [media] staging: omap4iss: separate links creation from entities init

are made after the entities registration. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/staging/media/omap4iss/iss.c | 101 ++- drivers/staging/media/omap4iss/iss_csi2.c| 35 +++--- drivers/staging/media/omap4iss/iss_

[PATCH 0/5] [media] Create pads links after entities registration

they were only build tested. So testing that I didn't introduce any regression will be highly appreciated. [0]: https://lkml.org/lkml/2015/8/26/453 [1]: http://www.spinics.net/lists/linux-samsung-soc/msg47089.html Best regards, Javier Javier Martinez Canillas (5): [media] staging: omap4iss: sepa

Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information

Hello Jonathan, On 09/05/2015 06:31 PM, Jonathan Cameron wrote: > On 01/09/15 00:09, Javier Martinez Canillas wrote: >> Hello Jonathan, >> >> On 08/22/2015 07:59 PM, Jonathan Cameron wrote: >>> On 20/08/15 08:07, Javier Martinez Canillas wrote: >>>> The S

Re: [PATCH v8 10/55] [media] media: rename the function that create pad links

nclude/ -name '*.h' > -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a > && mv a $i; done > > Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> > Acked-by: Hans Verkuil <hans.verk...@cisco.com> > Signed-off-by: Mauro C

Re: [PATCH] staging: dgap: fix returned errno code in dgap_parsefile()

Hello Sudip, On 09/22/2015 06:52 AM, Sudip Mukherjee wrote: > On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote: >> The driver is using -1 instead of the -ENOMEM defined macro to specify >> that a buffer allocation failed. Since the error number is propagated

[PATCH] staging: dgap: fix returned errno code in dgap_parsefile()

: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/staging/dgap/dgap.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/

[PATCH v2] staging: wicl1000: fix dereference after free in wilc_wlan_cleanup()

to avoid leaking the buffer memory. Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes in v2: - Change also the #ifdef MEMORY_DYNAMIC to #ifndef MEMORY_STATIC since buffer i

Re: [PATCH] staging: wicl1000: fix dereference after free in wilc_wlan_cleanup()

Hello Sudip, Thanks a lot for your feedback. On 09/22/2015 02:16 PM, Sudip Mukherjee wrote: > On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote: >> The wilc_wlan_cleanup() function iterates over the list of transmission >> buffers freeing all of them and the

[PATCH] staging: wicl1000: remove duplicated operand in OR operation

The IEEE80211_STYPE_PROBE_REQ flag appears twice in the expression and coccicheck complains with: wilc_wfi_cfgoperations.h:80:3-38: duplicated argument to & or | Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.

Re: [PATCH v8 02/55] [media] staging: omap4iss: get entity ID using media_entity_id()

Hello Laurent, On 12/06/2015 12:18 AM, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:13 Mauro Carvalho Chehab wrote: >> From: Javier Martinez Canillas <jav...@osg.samsung.com> >> >> Assessing media_e

Re: [PATCH 1/5] [media] staging: omap4iss: separate links creation from entities init

Hello Laurent, On 12/06/2015 12:10 AM, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > Thanks for your feedback. > On Thursday 03 September 2015 18:00:32 Javier Martinez Canillas wrote: >> The omap4iss driver initializes the entities and creates the

Re: [PATCH] [media] media: rename media unregister function

ing both unregister and cleanup in this function will make very clear that a single function is the counter part of the previous two operations. > thanks, > -- Shuah > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America __

Re: [PATCH] [media] media: rename media unregister function

Chehab <mche...@osg.samsung.com> The patch looks good and I agree that makes things more clear. Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America _

[PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/staging/octeon/ethernet.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: > From: Philipp Zabel [snip] > > +config VIDEO_MULTIPLEXER > + tristate "Video Multiplexer" > + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver can

Re: [PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

Hello Greg, On 08/21/2016 12:02 PM, Greg Kroah-Hartman wrote: > On Thu, Jul 14, 2016 at 01:06:09PM -0400, Javier Martinez Canillas wrote: >> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either >> built-in or as a module, use that macro instead of open

[RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Using the macro makes the code more readable by helping abstract away some of the Kconfig built-in and module enable details. Signed-off-by: Javier

[PATCH v2] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Using the macro makes the code more readable by helping abstract away some of the Kconfig built-in and module enable details. Signed-off-by: Javier

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

On 09/01/2016 05:32 PM, Greg Kroah-Hartman wrote: > On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote: >> Hello David, >> >> On 08/25/2016 12:01 PM, David Daney wrote: >>> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: >>>>

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

Hello David, On 08/25/2016 12:01 PM, David Daney wrote: > On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: >> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either >> built-in or as a module, use that macro instead of open coding the same. >> >

[PATCH 5/5] [media] st-cec: Fix module autoload

drivers/staging/media//st-cec/stih-cec.ko | grep alias $ After this patch: $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias alias: of:N*T*Cst,stih-cecC* alias: of:N*T*Cst,stih-cec Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/s

[PATCH 0/5] [media] Fix module autoload for media platform drivers

Hello Mauro, I noticed that module autoload won't be working in a bunch of media platform drivers because the module alias information is not filled in the modules. This patch series contains the fixes for them. Best regards, Javier Javier Martinez Canillas (5): [media] v4l: vsp1: Fix module

[PATCH 4/5] [media] s5p-cec: Fix module autoload

drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias $ After this patch: $ modinfo drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias alias: of:N*T*Csamsung,s5p-cecC* alias: of:N*T*Csamsung,s5p-cec Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- d

[PATCH] staging: fbtft: Fix module autoload

drivers/staging/fbtft/flexfb.ko | grep alias $ After this patch: $ modinfo drivers/staging/fbtft/flexfb.ko | grep alias alias: platform:flexpfb Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/staging/fbtft/flexfb.c | 1 + 1 file changed, 1 insertion(+)

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

Hello Philipp, On Wed, Apr 5, 2017 at 5:34 AM, Philipp Zabel wrote: > On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: [snip] > I think the output part is accurate, as the audio pad is an artifact of > an unrelated change. I'm not so sure about the VBI

[PATCH] staging: typec: fusb302: Fix module autoload

. Before this patch: $ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias $ After this patch: $ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias alias: of:N*T*Cfcs,fusb302C* alias: of:N*T*Cfcs,fusb302 alias: i2c:typec_fusb302 Signed-off-by: Javier

[PATCH] media: staging/imx: Allow driver to build if COMPILE_TEST is enabled

-by: Javier Martinez Canillas --- drivers/staging/media/imx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig index 36b276ea2ec..5045e24c470 100644 --- a/drivers/staging/media/imx/Kconfig +++ b/drivers