Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

Dne petek, 27. julij 2018 ob 16:03:41 CEST je Jernej Škrabec napisal(a): > Hi! > > Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul Kocialkowski napisal(a): > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engi

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

Hi! Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul Kocialkowski napisal(a): > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests).

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

Dne torek, 07. avgust 2018 ob 14:31:03 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Fri, 2018-07-27 at 16:58 +0200, Jernej Škrabec wrote: > > Dne petek, 27. julij 2018 ob 16:03:41 CEST je Jernej Škrabec napisal(a): > > > Hi! > > > > > > Dne sred

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

Hi! Dne petek, 23. november 2018 ob 14:02:08 CET je Paul Kocialkowski napisal(a): > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format provide > the required meta-data for decoding slices extracted from the

Re: [linux-sunxi] [PATCH v2 15/15] arm64: dts: allwinner: a64: Add Video Engine node

Hi! Dne sreda, 05. december 2018 ob 10:24:44 CET je Paul Kocialkowski napisal(a): > This adds the Video Engine node for the A64. Since it can map the whole > DRAM range, there is no particular need for a reserved memory node > (unlike platforms preceding the A33). > > Signed-off-by: Paul

Re: [PATCH v5 2/4] media: pixfmt: Add HEVC slice pixel format

Hi! Dne petek, 24. maj 2019 ob 11:36:33 CEST je Paul Kocialkowski napisal(a): > Introduce the V4L2_PIX_FMT_HEVC_SLICE pixel format, which currently > describes an output buffer with enough appended slice data for > producing one decoded frame with a stateless video decoder. > > This will need to

Re: [PATCH 3/7] media: cedrus: Fix decoding for some H264 videos

Dne ponedeljek, 03. junij 2019 ob 13:55:36 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, May 30, 2019 at 11:15:12PM +0200, Jernej Skrabec wrote: > > It seems that for some H264 videos at least one bitstream parsing > > trigger must be called in order to be decoded correctly. There is no > >

Re: [PATCH 2/7] media: cedrus: Fix H264 default reference index count

Dne ponedeljek, 03. junij 2019 ob 13:46:20 CEST je Maxime Ripard napisal(a): > On Thu, May 30, 2019 at 11:15:11PM +0200, Jernej Skrabec wrote: > > Reference index count in VE_H264_PPS reg should come from PPS control. > > However, this is not really important because reference index count is > >

Re: [PATCH 6/7] media: cedrus: Add infra for extra buffers connected to capture buffers

Dne ponedeljek, 03. junij 2019 ob 14:18:59 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, May 30, 2019 at 11:15:15PM +0200, Jernej Skrabec wrote: > > H264 and HEVC engines need additional buffers for each capture buffer. > > H264 engine has this currently solved by allocating fixed size

Re: [PATCH 7/7] media: cedrus: Improve H264 memory efficiency

Dne ponedeljek, 03. junij 2019 ob 14:23:28 CEST je Maxime Ripard napisal(a): > On Thu, May 30, 2019 at 11:15:16PM +0200, Jernej Skrabec wrote: > > H264 decoder driver preallocated pretty big worst case mv col buffer > > pool. It turns out that pool is most of the time much bigger than it > > needs

Re: [PATCH 6/7] media: cedrus: Add infra for extra buffers connected to capture buffers

Dne sreda, 05. junij 2019 ob 23:10:17 CEST je Paul Kocialkowski napisal(a): > Hi, > > Le lundi 03 juin 2019 à 17:48 +0200, Jernej Škrabec a écrit : > > Dne ponedeljek, 03. junij 2019 ob 14:18:59 CEST je Maxime Ripard napisal(a): > > > Hi, > > > > > >

Re: [PATCH 0/7] media: cedrus: Improvements/cleanup

Dne ponedeljek, 12. avgust 2019 ob 14:12:21 CEST je Hans Verkuil napisal(a): > On 5/30/19 11:15 PM, Jernej Skrabec wrote: > > Here is first batch of random Cedrus improvements/cleanups. Only patch 2 > > has a change which raises a question about H264 controls. > > > > Changes were tested on H3

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

Dne ponedeljek, 26. avgust 2019 ob 20:28:31 CEST je Boris Brezillon napisal(a): > Hi Jernej, > > On Thu, 22 Aug 2019 21:44:57 +0200 > > Jernej Skrabec wrote: > > When codec supports multiple slices in one frame, VPU has to know when > > first slice of each frame is being processed, presumably

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

Dne ponedeljek, 26. avgust 2019 ob 20:28:31 CEST je Boris Brezillon napisal(a): > Hi Jernej, > > On Thu, 22 Aug 2019 21:44:57 +0200 > > Jernej Skrabec wrote: > > When codec supports multiple slices in one frame, VPU has to know when > > first slice of each frame is being processed, presumably

Re: [PATCH 7/8] media: cedrus: Add support for holding capture buffer

Dne četrtek, 29. avgust 2019 ob 13:23:29 CEST je Hans Verkuil napisal(a): > On 8/22/19 9:44 PM, Jernej Skrabec wrote: > > When frame contains multiple slices and driver works in slice mode, it's > > more efficient to hold capture buffer in queue until all slices of a > > same frame are decoded. >

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

Dne torek, 01. oktober 2019 ob 00:43:34 CEST je Hans Verkuil napisal(a): > On 10/1/19 12:27 AM, Jernej Škrabec wrote: > > Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil > > > > napisal(a): > >> On 9/29/19 10:00 PM, Jernej Skrabec wrote:

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

Dne torek, 01. oktober 2019 ob 00:43:34 CEST je Hans Verkuil napisal(a): > On 10/1/19 12:27 AM, Jernej Škrabec wrote: > > Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil > > > > napisal(a): > >> On 9/29/19 10:00 PM, Jernej Skrabec wrote:

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil napisal(a): > On 9/29/19 10:00 PM, Jernej Skrabec wrote: > > This series adds support for decoding multi-slice H264 frames along with > > support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF. > > > > Code was

Re: [PATCH v2 6/6] media: cedrus: Add support for holding capture buffer

Dne ponedeljek, 30. september 2019 ob 10:14:32 CEST je Hans Verkuil napisal(a): > On 9/29/19 10:00 PM, Jernej Skrabec wrote: > > When frame contains multiple slices and driver works in slice mode, it's > > more efficient to hold capture buffer in queue until all slices of a > > same frame are

Re: [PATCH 1/3] media: cedrus: Properly signal size in mode register

Dne ponedeljek, 04. november 2019 ob 11:02:28 CET je Paul Kocialkowski napisal(a): > Hi Jernej, > > On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote: > > Mode register also holds information if video width is bigger than 2048 > > and if it is equal to 4096. > > > > Rework cedrus_engine_enable() to

Re: [PATCH 2/3] media: cedrus: Fix H264 4k support

Dne ponedeljek, 04. november 2019 ob 11:13:19 CET je Paul Kocialkowski napisal(a): > Hi, > > On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote: > > H264 decoder needs additional or bigger buffers in order to decode 4k > > videos. > > Thanks for the fixup, we hadn't looked into those bits at all

Re: [PATCH 1/3] media: cedrus: Properly signal size in mode register

Dne torek, 05. november 2019 ob 09:10:34 CET je Paul Kocialkowski napisal(a): > Hi, > > On Mon 04 Nov 19, 17:33, Jernej Škrabec wrote: > > Dne ponedeljek, 04. november 2019 ob 11:02:28 CET je Paul Kocialkowski > > > > napisal(a): > > > Hi Jernej, > >

Re: [linux-sunxi] [PATCH 4/4] media: cedrus: hevc: Add support for multiple slices

Dne sobota, 26. oktober 2019 ob 19:47:03 CET je Jernej Skrabec napisal(a): > Now that segment address is available, support for multi-slice frames > can be easily added. > > Signed-off-by: Jernej Skrabec > --- > .../staging/media/sunxi/cedrus/cedrus_h265.c | 21 +++ >

Re: [PATCH v2 1/3] media: cedrus: Fix decoding for some H264 videos

Hi! Sorry for late reponse, technical issues... Dne sreda, 02. oktober 2019 ob 23:54:47 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Wed 02 Oct 19, 21:35, Jernej Skrabec wrote: > > It seems that for some H264 videos at least one bitstream parsing > > trigger must be called in order to be

Re: [PATCH v2 3/6] media: v4l2-mem2mem: add stateless_(try_)decoder_cmd ioctl helpers

Dne petek, 04. oktober 2019 ob 11:21:12 CEST je Hans Verkuil napisal(a): > On 9/29/19 10:00 PM, Jernej Skrabec wrote: > > These helpers are used by stateless codecs when they support multiple > > slices per frame and hold capture buffer flag is set. It's expected that > > all such codecs will use

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

Dne ponedeljek, 07. oktober 2019 ob 12:44:24 CEST je Hans Verkuil napisal(a): > Hi Jernej, > > On 9/29/19 10:00 PM, Jernej Skrabec wrote: > > This series adds support for decoding multi-slice H264 frames along with > > support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF. > > >

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

Dne sreda, 09. oktober 2019 ob 12:18:45 CEST je Hans Verkuil napisal(a): > On 10/7/19 9:01 PM, Jernej Škrabec wrote: > > Dne ponedeljek, 07. oktober 2019 ob 12:44:24 CEST je Hans Verkuil napisal(a): > >> Hi Jernej, > >> > >> On 9/29/19 10:00 PM, Jernej S

Re: [PATCH v2 2/3] media: cedrus: Fix H264 default reference index count

Dne četrtek, 03. oktober 2019 ob 22:28:46 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Thu 03 Oct 19, 07:16, Jernej Škrabec wrote: > > Dne četrtek, 03. oktober 2019 ob 00:06:50 CEST je Paul Kocialkowski > > > > napisal(a): > > > Hi, > > >

Re: [PATCH v2 2/3] media: cedrus: Fix H264 default reference index count

Dne četrtek, 03. oktober 2019 ob 22:58:57 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Thu 03 Oct 19, 22:44, Jernej Škrabec wrote: > > Dne četrtek, 03. oktober 2019 ob 22:28:46 CEST je Paul Kocialkowski > > > > napisal(a): > > > Hi, > > >

Re: [PATCH v2 2/3] media: cedrus: Fix H264 default reference index count

Dne četrtek, 03. oktober 2019 ob 00:06:50 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Wed 02 Oct 19, 21:35, Jernej Skrabec wrote: > > Reference index count in VE_H264_PPS should come from PPS control. > > However, this is not really important, because reference index count is > > in our

Re: [PATCH v2 0/3] media: cedrus: improvements

Dne četrtek, 03. oktober 2019 ob 00:23:07 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Wed 02 Oct 19, 21:35, Jernej Skrabec wrote: > > This is continuation of https://lkml.org/lkml/2019/5/30/1459 with several > > patches removed (2 merged, others needs redesign) and one added. > > Thanks

Re: [PATCH 1/2] media: cedrus: Fix decoding for some HEVC videos

Hi! Dne sreda, 18. december 2019 ob 09:40:47 CET je Paul Kocialkowski napisal(a): > Hi, > > On Fri 13 Dec 19, 17:15, Jernej Skrabec wrote: > > It seems that for some HEVC videos at least one bitstream parsing > > trigger must be called in order to be decoded correctly. There is no > >

Re: [PATCH v2 3/4] media: uapi: hevc: Add segment address field

Hi! Dne sreda, 08. januar 2020 ob 15:31:26 CET je Mauro Carvalho Chehab napisal(a): > Em Fri, 13 Dec 2019 17:04:27 +0100 > > Jernej Skrabec escreveu: > > If HEVC frame consists of multiple slices, segment address has to be > > known in order to properly decode it. > > > > Add segment address

Re: [PATCH v2 2/4] media: cedrus: hevc: Add support for scaling matrix

Dne sreda, 08. januar 2020 ob 15:46:50 CET je Hans Verkuil napisal(a): > On 1/7/20 6:10 PM, Jernej Škrabec wrote: > > Hi! > > > > Dne torek, 07. januar 2020 ob 16:01:16 CET je Hans Verkuil napisal(a): > >> On 12/13/19 5:04 PM, Jernej Skrabec wrote: > >>>

Re: [PATCH v2 1/4] media: uapi: hevc: Add scaling matrix control

Hi! Dne sreda, 08. januar 2020 ob 15:43:36 CET je Paul Kocialkowski napisal(a): > Hi Mauro, > > On Wed 08 Jan 20, 15:11, Mauro Carvalho Chehab wrote: > > Em Fri, 13 Dec 2019 17:04:25 +0100 > > > > Jernej Skrabec escreveu: > > > HEVC has a scaling matrix concept. Add support for it. > > > > >

Re: [PATCH v2 2/4] media: cedrus: hevc: Add support for scaling matrix

Hi! Dne torek, 07. januar 2020 ob 16:01:16 CET je Hans Verkuil napisal(a): > On 12/13/19 5:04 PM, Jernej Skrabec wrote: > > HEVC frames may use scaling list feature. Add support for it. > > > > Signed-off-by: Jernej Skrabec > > --- > > > > drivers/staging/media/sunxi/cedrus/cedrus.c | 7 ++

Re: [PATCH] media: cedrus: Add support for VP8 decoding

Dne sreda, 20. maj 2020 ob 23:43:40 CEST je Nicolas Dufresne napisal(a): > Le mercredi 20 mai 2020 à 23:01 +0200, Jernej Skrabec a écrit : > > VP8 in Cedrus shares same engine as H264. > > > > Note that it seems necessary to call bitstream parsing functions, > > to parse frame header, otherwise

Re: [linux-sunxi] [PATCH 01/14] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes

Hi! Dne petek, 23. oktober 2020 ob 19:45:33 CEST je Paul Kocialkowski napisal(a): > As some D-PHY controllers support both Rx and Tx mode, we need a way for > users to explicitly request one or the other. For instance, Rx mode can > be used along with MIPI CSI-2 while Tx mode can be used with

Re: [PATCH 1/3] media: uapi: h264: update reference lists

Hi! Dne sreda, 08. julij 2020 ob 15:28:52 CEST je Ezequiel Garcia napisal(a): > Hello Jernej, > > I'd like to post a new H264 uAPI cleanup series soon, > would you mind resending this, or otherwise do you > mind if I include this patch in the series? I don't mind at all. Currently my focus was

Re: [PATCH 2/3] media: cedrus: h264: Properly configure reference field

Dne petek, 05. junij 2020 ob 19:16:35 CEST je Nicolas Dufresne napisal(a): > Le jeudi 04 juin 2020 à 20:57 +0200, Jernej Skrabec a écrit : > > When interlaced H264 content is being decoded, references must indicate > > which field is being referenced. Currently this was done by checking > >

Re: [PATCH 1/3] media: uapi: h264: update reference lists

Dne petek, 05. junij 2020 ob 19:13:24 CEST je Nicolas Dufresne napisal(a): > Sorry, missed one thing. > > Le vendredi 05 juin 2020 à 13:08 -0400, Nicolas Dufresne a écrit : > > Le jeudi 04 juin 2020 à 20:57 +0200, Jernej Skrabec a écrit : > > > When dealing with with interlaced frames, reference

Re: [PATCH v2] media: cedrus: Add support for VP8 decoding

Hi Ezequiel! Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a): > Hi Jernej, > > As you know, I'm not familiar with this hardware, > but I've tried to take a detailed look anyway. > Thanks, any review is welcome. > The driver looks mostly good to me, I just have > some

Re: Re: [PATCH v3] media: cedrus: Add support for VP8 decoding

Hi! Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a): > Hi Jernej, Emmanuel, > > Thanks for the patch. > > On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec wrote: > > VP8 in Cedrus shares same engine as H264. > > > > Note that it seems necessary to call bitstream