Re: [PATCH] staging:rtl8723au: core: Fix Warning reported by checkpatch.

"Sharma, Sanjeev" writes: > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 06, 2014 9:13 PM > To: Sharma, Sanjeev > Cc: larry.fin...@lwfinger.net; jes.soren...@redhat.com; > de...@driverdev.osuosl.org; linux-wirel...@vger.kernel.org; > li

Re: [PATCH] staging: rtl8723au: change typecast to match type returned by htons()

turned by htons(). > > Signed-off-by: Chris Ruffin > --- > drivers/staging/rtl8723au/core/rtw_xmit.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine to me Signed-off-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c >

Re: [PATCH] staging: rtl8723au: change typecast to match type returned by htons()

Arend van Spriel writes: > On 10-11-14 21:21, Jes Sorensen wrote: >> Chris Ruffin writes: >>> Using a u16 pointer typecast for a result from htons() results in >>> the following warning from sparse: >>> >>> drivers/staging/rtl8723au/core/rtw_x

[PATCH 00/10] staging: rtl8723au: Fixes and remove dead code

From: Jes Sorensen Hi, Here's a set of patches removing a pile of unused code from the rtl8723au drivers. It also includes an alignment issue pointed out by Arend van Spriel. Note this set goes on top of Chris Ruffin's patch: staging: rtl8723au: change typecast to match type returne

[PATCH 09/10] staging: rtl8723au: Remove no-op function Hal_InitChannelPlan23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 drivers/staging/rtl8723au/hal/usb_halinit.c | 4 drivers/staging/rtl8723au/include/rtl8723a_hal.h | 2 -- 3 files changed, 10 deletions(-) diff --git a/drivers/staging

[PATCH 01/10] staging: rtl8723au: Remove unused rtw_calculate_wlan_pkt_size_by_attribue23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c| 17 - drivers/staging/rtl8723au/include/rtw_xmit.h | 2 -- 2 files changed, 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au

[PATCH 05/10] staging: rtl8723au: portctrl(): Remove a pile of unnecessary clutter

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_recv.c | 40 --- 1 file changed, 4 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c index de98da5

[PATCH 07/10] staging: rtl8723au: pxmitframe->frame_tag is never set to a value > 8

From: Jes Sorensen No point of masking out high bits since we never set the value to anything exceeding bits 0-3. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +- drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 11 ++- 2 files changed, 7

[PATCH 04/10] staging: rtl8723au: rtw_put_snap23a(): Make it static

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c| 40 ++-- drivers/staging/rtl8723au/include/rtw_xmit.h | 1 - 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b

[PATCH 06/10] staging: rtl8723au: rtw_dump_xframe(): Use proper ETH_P_* types

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c index a67850f..cf31d29

[PATCH 03/10] staging: rtl8723au: rtw_put_snap23a(): Use put_unaligned to set protocol

From: Jes Sorensen Reported-by: Arend van Spriel Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c index 18a9f34

[PATCH 02/10] staging rtl8723au: rtw_put_smap23a(): Use common SNAP header defines

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c index b9ee983

[PATCH 08/10] staging: rtl8723au: Remove unused rtl8723a_update_txdesc() and child functions

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 248 -- drivers/staging/rtl8723au/include/rtl8723a_xmit.h | 1 - 2 files changed, 249 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b

[PATCH 10/10] staging: rtl8723au: Remove sw led handling

From: Jes Sorensen The rtl8723au relies on hw led support, so no point carrying a large unused sw led infrastructure around. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/Makefile |2 - drivers/staging/rtl8723au/core/rtw_cmd.c |6 - drivers/staging

Re: [PATCH 03/10] staging: rtl8723au: rtw_put_snap23a(): Use put_unaligned to set protocol

Dan Carpenter writes: > On Mon, Nov 10, 2014 at 06:11:39PM -0500, jes.soren...@redhat.com wrote: >> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c >> b/drivers/staging/rtl8723au/core/rtw_xmit.c >> index 18a9f34..f8b1243 100644 >> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c >> +++ b/dri

Re: [PATCH] staging: rtl8723au: fix sparse warning

runovich > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 78 > ------- > 1 file changed, 78 deletions(-) Looks good to me Signed-off-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > b/drivers/staging/rtl8723au/hal/rtl8723a_hal_in

Re: [PATCH] staging:rtl8723au: fix sparse warning: incorrect type in assignment

Kinka Huang writes: > Signed-off-by: Kinka Huang > --- > drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Eeeek, nice catch! Acked-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c > b/driv

Re: [PATCH] Drivers:staging:rtl8723au:core: Fixed checkpatch error

Athira Lekshmi writes: > Fixed the checkpatch error: > ERROR: spaces required around that '>' > > Signed-off-by: Athira Lekshmi > --- > drivers/staging/rtl8723au/core/rtw_cmd.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.

[PATCH 01/28] staging: rtl8723au: recv_priv.is_signal_dbg is never set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_recv.c| 104 --- drivers/staging/rtl8723au/include/rtw_recv.h | 2 - 2 files changed, 46 insertions(+), 60 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b

[PATCH 14/28] staging: rtl8723au: Fold _ps_open_RF23a() into rtl8723au_hal_init()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 6c66013..cd3f8ba

[PATCH 23/28] staging: rtl8723au: _DisableRFAFEAndResetBB8192C(): Reduce code obfuscation

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index d2b4fb0

[PATCH 06/28] staging: rtl8723au: Eliminate do_queue_select() functions

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c | 14 +- drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 14 +- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c

[PATCH 24/28] staging: rtl8723au: Remove unnecessary wrapper _DisableRFAFEAndResetBB()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 3aa20f6

[PATCH 10/28] staging: rtl8723au: _InitPowerOn(): Don't zero init variables unnecessarily

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index b8d5040..3b09dc2 100644

[PATCH 02/28] staging: rtl8723au: recv_priv->rssi is not used for anything

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c| 6 ++ drivers/staging/rtl8723au/core/rtw_recv.c| 10 -- drivers/staging/rtl8723au/include/rtw_recv.h | 1 - 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a

[PATCH 20/28] staging: rtl8723au: rtl8723a_update_ramask(): Fix up some bad formatting

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index

[PATCH 11/28] staging: rtl8723au: Fold _InitNormalChipQueuePriority() into _InitQueuePriority()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 3b09dc2..4cc0a0f 100644

[PATCH 00/28] staging: rtl8723au: Lazy Sunday fixes

From: Jes Sorensen Hi, Pleased find attached a couple of fixes and cleanups for the rtl8723au staging driver. One serious bug fixe in 13/28, but follow-on changes showed the code was never actually called. Should be good for staging-next, don't think any of it is more urgent than that. C

[PATCH 17/28] staging: rtl8723au: rtl8723au_read_port() addr argument wasn't used

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 3 +-- drivers/staging/rtl8723au/hal/usb_ops_linux.c | 19 --- drivers/staging/rtl8723au/include/rtl8723a_recv.h | 1 - drivers/staging/rtl8723au/include/usb_ops_linux.h

[PATCH 05/28] staging: rtl8723au: Fold rtw_ack_tx_done23a() into rtw23a_sctx_done_err()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/Makefile| 1 - drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 15 +++ drivers/staging/rtl8723au/hal/rtl8723a_xmit.c | 31 --- drivers/staging/rtl8723au/include

[PATCH 12/28] staging: rtl8723au: Remove no-op _InitHWLed() function

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 4cc0a0f..762c514 100644 --- a/drivers/staging

[PATCH 28/28] staging: rtl8723au: Hal_InitPGData() avoid unnecessary typecasts

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index

[PATCH 09/28] staging: rtl8723au: Fold rtl8723au_set_queue_pipe_mapping into rtl8723au_chip_configure()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 27 --- drivers/staging/rtl8723au/include/usb_ops.h | 2 +- drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 ++- 3 files changed, 11 insertions(+), 21 deletions(-) diff

[PATCH 21/28] staging: rtl8723au: Fold _BlockWrite() into _PageWrite()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c

[PATCH 04/28] staging: rtl8732au: Partial clean up of rtl8723a_rf6052.c

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 229 +--- 1 file changed, 123 insertions(+), 106 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052

[PATCH 19/28] staging: rtl8723au: Remove unused slimcombo debug flag

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 11 --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 4 2 files changed, 15 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging

[PATCH 03/28] staging: rtl8723au: Fold ODM_PhyStatusQuery23a_92CSeries() into ODM_PhyStatusQuery23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging/rtl8723au/hal/odm_HWConfig.c index 29d844d..fb3cc87

[PATCH 16/28] staging: rtl8723au: Use a local variable to state if MAC was already powered on

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 15 --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 2 -- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b

[PATCH 27/28] staging: rtl8723au: _DisableAnalog(): Avoid zero-init variables unnecessarily

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index

[PATCH 15/28] staging: rtl8723au: phy_SsPwrSwitch92CU() was never called with bRegSSPwrLvl != 1

From: Jes Sorensen Get rid of the alternate code paths since these weren't used and have never been tested according to the in-code comments. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 322 1 file changed, 84 insertions(+)

[PATCH 08/28] staging: rtl8723au: Remove write only struct hal_data_8723a.interfaceIndex

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 2 -- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal

[PATCH 07/28] staging: rtl8723au: Remove unused rtw_sctx_done23a() function

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c| 5 - drivers/staging/rtl8723au/include/rtw_xmit.h | 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c

[PATCH 26/28] staging: rtl8723au: Remove unnecessary wrapper _ResetDigitalProcedure1()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index

[PATCH 22/28] staging: rtl8723au: _DisableRFAFEAndResetBB8192C(): Use correct enum value

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 267a80b

[PATCH 25/28] staging: rtl8723au: _ResetDigitalProcedure1_92C() reduce code obfuscation

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 62 +++ 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal

[PATCH 18/28] staging: rtl8723au: rtl8723au_read_interrupt() addr argument wasn't used

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++-- drivers/staging/rtl8723au/hal/usb_ops_linux.c | 2 +- drivers/staging/rtl8723au/include/rtl8723a_recv.h | 2 -- drivers/staging/rtl8723au/include/usb_ops_linux.h | 2 +- 4 files

[PATCH 13/28] staging: rtl8723au: Do not write garbage to REG_SPS0_CTRL

From: Jes Sorensen Use a separate variable to hold the value of REG_SPS0_CTRL to avoid it getting clobbered and writing out garbage to it, for the case of eRFPowerState == rf_sleep/rf_off && bRegSSPwrLvl == 1. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halini

[PATCH 0/1] staging: rtl8188eu: Fixup USB endpoint parsing

From: Jes Sorensen Hi, This removes a pointless NULL pointer check in the USB endpoint parsing code, allowing for some cleaning up. I have made the same change to the rtl8723au driver, which I will push out with the next set of fixes. Cheers, Jes Jes Sorensen (1): staging: rtl8188eu

[PATCH 1/1] staging: rtl8188eu: usb_dvobj_init(): A NULL pointer check for usb_host_endpoints makes no sense

From: Jes Sorensen struct usb_host_interface points to an array of struct usb_host_endpoints - it makes no sense to do a NULL pointer check for each pointer. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 33 + 1 file changed, 15

[PATCH 07/12] staging: rtl8723au: There is no 11N pseudo PHY here

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c| 12 drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 1 - 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c b/drivers/staging

[PATCH 03/12] staging: rtl8723au: Use proper enum defines

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index ee17b2c..adbf1c2 100644

[PATCH 02/12] staging: rtl8723au: Use correct register names to set parameters to reduce 80M spur

From: Jes Sorensen Use the correct register names when setting parameters to reduce 80M spur. In addition apply updated 80M spur reduction parameters. Original patch supplied by Andrew Chang Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 8 1 file

[PATCH 10/12] staging: rtl8723au: Hal8723PwrSeq.h: Remove PCI specific entries from the power sequence tables

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/Hal8723PwrSeq.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/include/Hal8723PwrSeq.h b/drivers/staging/rtl8723au/include/Hal8723PwrSeq.h index 4a1f58f

[PATCH 04/12] staging: rtl8723au: Use enum for counter and avoid ugly typecast

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c index 88e91cd..e0fff53

[PATCH 08/12] staging: rtl8723au: Hal8723APhyCfg.h: Remove more unused #defines

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/Hal8723APhyCfg.h b/drivers/staging/rtl8723au/include/Hal8723APhyCfg.h index fa6f4ae..2247d98

[PATCH 01/12] staging: rtl8723au: usb_dvobj_init(): A NULL pointer check for usb_host_endpoints makes no sense

From: Jes Sorensen struct usb_host_interface points to an array of struct usb_host_endpoints - it makes no sense to do a NULL pointer check for each pointer. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_intf.c | 72 + 1 file changed, 33

[PATCH 09/12] staging: rtl8723au: HalPwrSeqCmdParsing23a(): Avoid unnecessary variable inits

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalPwrSeqCmd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/HalPwrSeqCmd.c b/drivers/staging/rtl8723au/hal/HalPwrSeqCmd.c index 1da4eec..33777d2 100644

[PATCH 11/12] staging: rtl8723au: Hal8723PwrSeq.h: Remove SDIO specific entries

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/Hal8723PwrSeq.h | 40 +++ 1 file changed, 11 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8723au/include/Hal8723PwrSeq.h b/drivers/staging/rtl8723au/include

[PATCH 00/12] staging: rtl8723au: Further cleanups

From: Jes Sorensen Hi, This set removes a bunch of unused code, in addition it includes a fix for using the right register definitions to when setting parameters to reduce 80M spur. This set should apply cleanly to staging-next as of today. Cheers, Jes Jes Sorensen (12): staging: rtl8723au

[PATCH 12/12] staging: rtl8723au: Hal8723PwrSeq.h: Use BIT() define to match mask value

From: Jes Sorensen This is a no-op change, but it improves consistency. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/Hal8723PwrSeq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/Hal8723PwrSeq.h b/drivers/staging

[PATCH 06/12] staging: rtl8723au: Baseband is always configured through PHY regs

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c| 19 --- drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 5 - 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723au/hal

[PATCH 05/12] staging: rtl8723au: Hal8723APhyCfg.h: Remove some undefined structs and enums

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 39 -- 1 file changed, 39 deletions(-) diff --git a/drivers/staging/rtl8723au/include/Hal8723APhyCfg.h b/drivers/staging/rtl8723au/include/Hal8723APhyCfg.h index

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

Krzysztof Konopko writes: > On 12/12/14 00:53, Larry Finger wrote: >> In RTL8188EU, both BA_starting_seqctrl and TXOP_limit are unsigned short. >> > > That's not quite the case. `TXOP_limit` is __le16 in RTL8188EU [1]. > It's __le16 even in your GitHub repo [2]. And that made me thinking > that

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

Krzysztof Konopko writes: > Some struct fields in wifi.h are meant to be __le16 bu were declared as > unsigned short. This was reported by sparse: > > rtw_wlan_util.c:538:24: warning: cast to restricted __le16 > rtw_wlan_util.c:1544:29: warning: cast to restricted __le16 > rtw_wlan_util.c:1

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

Larry Finger writes: > On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: >> I was hunting particularly for inconsistencies with `sparse` and came >> across this one. But I dug a bit further and I wonder why the driver is >> not using standard stuff like the one in `include/linux/ieee80211.h` >> wh

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

Krzysztof Konopko writes: > On 12/12/14 19:52, Jes Sorensen wrote: >> Larry Finger writes: >>> On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: >>>> I was hunting particularly for inconsistencies with `sparse` and came >>>> across this one. But I dug a

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

of Konopko > --- > drivers/staging/rtl8723au/include/wifi.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Looks OK Signed-off-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/include/wifi.h > b/drivers/staging/rtl8723au/include/wifi.h &

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

vers/staging/rtl8723au/include/wifi.h | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Well the u8 change is really in the nit picking space, but I am fine with that too. Signed-off-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/include/wifi.h &

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

Dan Carpenter writes: > On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: >> There is otherwise a risk of a possible null pointer dereference. >> >> Was largely found by using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist >> --- >>

Re: [PATCH] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"

Asaf Vertz writes: > Fixed a coding style error, "foo * bar" should be "foo *bar" > > Signed-off-by: Asaf Vertz > --- > drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) If you want to fix the 'error' here, include it with a clean

Re: [PATCH v2] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"

+- > 1 files changed, 7 insertions(+), 25 deletions(-) Signed-off-by: Jes Sorensen > diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c > b/drivers/staging/rtl8723au/core/rtw_efuse.c > index 81960e7..a6deddc 100644 > --- a/drivers/staging/rtl8723au/core/rtw

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Remove some unused functions

s/staging/rtl8723au/include/osdep_intf.h |3 - > drivers/staging/rtl8723au/os_dep/usb_intf.c| 100 > > 2 files changed, 103 deletions(-) Signed-off-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/include/osdep_intf.h > b/drivers/s

Re: [PATCH] staging: rtl8723au: changes stop ap mode to use reset function

Matthew Emerson writes: > Changes stop_ap_mode23a() to use rtw_reset_securitypriv23a. This makes > the code cleaner and fixes two checkpatch.pl errors, one line over 80 > characters, and one spacing issue. > > Signed-off-by: Matthew Emerson > --- > drivers/staging/rtl8723au/core/rtw_ap.c | 6 ++-

Re: [PATCH] drivers: staging: rtl8723au: get rid of unneeded memset/memcpy

Greg Kroah-Hartman writes: > On Sun, Dec 07, 2014 at 03:37:20PM +0100, Emil Renner Berthing wrote: >> This also fixes a sparse warning. > > What sparse warning? What's wrong with the original code? Unless Jes > resends this to me, I don't see the need to apply it, sorry. I agree, I cannot see w

[PATCH 18/19] staging: unisys: visorchipset: Don't include timskmod.h

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/parser.h | 1 - drivers/staging/unisys/visorchipset/visorchipset.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/parser.h b

[PATCH 00/19] staging: unisys: visorchipset: Cleanups

From: Jes Sorensen Hi, I did some cleanups of drivers/staging/unisys/visorchipset. There is more to come, but this should improve the code, and also get rid of some dead code that is no longer needed. Thanks for Benjamin Romer @ Unisys for testing the changes. Cheers, Jes Jes Sorensen (19

[PATCH 11/19] staging: unisys: visorchipset: Fix up a few cases of bad formatting

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c index

[PATCH 05/19] staging: unisys: visorchipset: Use correct type for dev_no

From: Jes Sorensen visorchipset_bus_info.dev_no is only assigned the value of controlvm_message_packet.create_bus.dev_count, which is a u32. No point promoting it to a u64. Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 3 +-- 1

[PATCH 01/19] staging: unisys: visorchipset: Remove unused NONULLSTR()

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset

[PATCH 12/19] staging: unisys: visorchipset: Remove some unnecessary parenthesis

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_umode.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_umode.h b/drivers/staging/unisys

[PATCH 14/19] staging: unisys: visorchipset: Don't zero struct elements which will be memset away

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset

[PATCH 07/19] staging: unisys: visorchipset: Get rid of ulong usage

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 6 +++--- drivers/staging/unisys/visorchipset/parser.c | 16 drivers/staging/unisys/visorchipset/parser.h | 2 +- 3 files changed, 12 insertions

[PATCH 03/19] staging: unisys: visorchipset: Get rid of ugly BOOL/TRUE/FALSE usage

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/parser.c | 24 +++--- drivers/staging/unisys/visorchipset/parser.h | 8 +- drivers/staging/unisys/visorchipset/visorchipset.h | 10 +-- .../unisys/visorchipset

[PATCH 04/19] staging: unisys: visorchipset: Do not use confuse size of long with size of u32

From: Jes Sorensen struct visorcipset_device_info defines bus_no and dev_no as u32, while the deprecated ulong type is 64 bits. Hence avoid promoting the values to 64 bit just to truncate them again later. Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys

[PATCH 13/19] staging: unisys: visorchipset: Remove unncessary parenthesis

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys

[PATCH 17/19] staging: unisys: visorchipset: Remove unused cache object counter

From: Jes Sorensen kmem_cache statistics are available through SLAB anyway Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/visorchipset

[PATCH 15/19] staging: unisys: visorchipset: Do not initialize variables unnecessarily

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- .../unisys/visorchipset/visorchipset_main.c| 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers

[PATCH 02/19] staging: unisys: visorchipset: Avoid struct typedef abuse

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- .../staging/unisys/visorchipset/visorchipset_main.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers

[PATCH 19/19] staging: unisys: visorchipset: Remove a couple of unnecessary blank lines

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h b/drivers/staging/unisys/visorchipset/visorchipset.h index

[PATCH 16/19] staging: unisys: visorchipset: Get rid of uint usage

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys

[PATCH 08/19] staging: unisys: visorchipset: Move module paramters around and mark static

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/globals.h | 11 .../unisys/visorchipset/visorchipset_main.c| 33 +++--- 2 files changed, 17 insertions(+), 27 deletions(-) diff --git a

[PATCH 09/19] staging: unisys: visorchipset: Move MYDRVNAME to visorchipset.h

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/globals.h | 2 -- drivers/staging/unisys/visorchipset/visorchipset.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset

[PATCH 10/19] staging: unisys: visorchipset: Eliminate globals.h

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 6 +++-- drivers/staging/unisys/visorchipset/file.h | 2 -- drivers/staging/unisys/visorchipset/globals.h | 29 -- .../unisys

[PATCH 06/19] staging: unisys: visorchipset: Remove unused get_channel_info notifier

From: Jes Sorensen Signed-off-by: Jes Sorensen Tested-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/visorchipset.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h b/drivers/staging/unisys/visorchipset/visorchipset.h index

Re: Anybody working on rtl8712?

Xose Vazquez Perez writes: > On 06/20/2014 10:52 PM, Christian Lamparter wrote: > >> rtl8192su development is chugging along. It just doesn't take place on >> driverdev list. The driver reached "feature parity" with rtl8192cu for >> some time ago. But as with rtl8192cu, I would recommend adding ju

Re: [PATCH 079/141] staging: unisys: visorchannel_write(): Handle partial channel_header writes

Dan Carpenter writes: > On Tue, May 05, 2015 at 06:36:56PM -0400, Benjamin Romer wrote: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> Signed-off-by: Benjamin Romer >> --- >> drivers/staging/unisys/visorbus/visorchannel.c | 9 ++---

Re: Anybody working on rtl8712?

Christian Lamparter writes: > On Tue, May 5, 2015 at 7:23 PM, Jes Sorensen wrote: >> Xose Vazquez Perez writes: >>> On 06/20/2014 10:52 PM, Christian Lamparter wrote: >>> >>>> rtl8192su development is chugging along. It just doesn't take place on >

Re: [PATCH] staging: rtl8723au : remove goto & return error directly

"Gujulan Elango, Hari Prasath (H.)" writes: > Remove the goto and return error directly thereby removing a variable > > Signed-off-by: Hari Prasath Gujulan Elango > --- > drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) NACK! The

Re: [PATCH] staging: rtl8723au : remove goto & return error directly

Dan Carpenter writes: > On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote: >> "Gujulan Elango, Hari Prasath (H.)" writes: >> > Remove the goto and return error directly thereby removing a variable >> > >> > Signed-off-by: Hari Prasath

Re: [PATCH] staging: rtl8723au : remove goto & return error directly

"Gujulan Elango, Hari Prasath (H.)" writes: > On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote: >> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote: >> > "Gujulan Elango, Hari Prasath (H.)" writes: >> > > Remove the

  1   2   3   4   5   6   7   8   >