On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote:
> Convert the GPIO driver to use the GPIO irqchip library
> GPIOLIB_IRQCHIP instead of reimplementing the same.
Thanks for picking this up. Linus W took a stab at it a couple of years
ago, but it was never completed. You may want to ta
On Sun, Nov 11, 2018 at 11:14:14AM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> drivers/staging/greybus/arche-apb-ctrl.c | 158 ++-
> 1 file changed, 65 insertions(+),
On Tue, Nov 13, 2018 at 11:48:09PM +0530, Nishad Kamdar wrote:
> On Mon, Nov 12, 2018 at 04:15:09PM +0100, Johan Hovold wrote:
> > On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote:
> > > @@ -40,8 +38,6 @@ struct gb_gpio_controller {
> > > s
On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated
> old non-descriptor interface.
>
> Signed-off-by: Nishad Kamdar
> ---
Always include a change log here after the cut-off line so we know what
changed since previous versions.
Also
On Sat, Nov 17, 2018 at 12:41:11PM +0530, Nishad Kamdar wrote:
> On Fri, Nov 16, 2018 at 05:06:22PM +0100, Johan Hovold wrote:
> > On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote:
> > > Use the gpiod interface instead of the deprecated
> > > o
On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote:
> Fixed the spelling of 'transfered' to 'transferred'.
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/greybus/hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/hid.c
On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:17, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > > This change fixes a checkpatch CHECK style issue for "Alignment should
> > >
On Fri, Feb 12, 2021 at 03:25:29PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:52, Johan Hovold wrote:
> > But what will the checkpatch crew then work on?
>
> Lol..
>
> > Better staging than the rest of the kernel.
>
> [ /me wondering on who stops them from s
On Tue, Apr 27, 2021 at 11:22:50AM +0200, Mauro Carvalho Chehab wrote:
> Hi Dmitry,
>
> Em Sat, 24 Apr 2021 10:35:22 +0300
> Dmitry Osipenko escreveu:
>
> > 24.04.2021 09:44, Mauro Carvalho Chehab пишет:
> > > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal
> > > with u
On Wed, Apr 28, 2021 at 04:51:41PM +0200, Mauro Carvalho Chehab wrote:
> The pm_runtime_get_sync() internally increments the
> dev->power.usage_count without decrementing it, even on errors.
> Replace it by the new pm_runtime_resume_and_get(), introduced by:
> commit dd8088d5a896 ("PM: runtime: Add
On Wed, Apr 28, 2021 at 04:51:21PM +0200, Mauro Carvalho Chehab wrote:
> During the review of the patches from unm.edu, one of the patterns
> I noticed is the amount of patches trying to fix pm_runtime_get_sync()
> calls.
>
> After analyzing the feedback from version 1 of this series, I noticed
>
On Thu, Apr 29, 2021 at 12:18:16PM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 28 Apr 2021 17:50:08 +0200
> Johan Hovold escreveu:
>
> > On Wed, Apr 28, 2021 at 04:51:21PM +0200, Mauro Carvalho Chehab wrote:
>
> > > 1. despite its name, this is actually a PM runtim
On Fri, Apr 30, 2021 at 06:03:38PM +0100, Jonathan Cameron wrote:
> On Wed, 28 Apr 2021 16:51:44 +0200
> Mauro Carvalho Chehab wrote:
>
> > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal
> > with usage counter")
> > added pm_runtime_resume_and_get() in order to automati
On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> Add the missing unlock before return from function
> gbaudio_dapm_free_controls() in the error handling case.
>
> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic
> audio module")
> Reported-by: Hulk Robot
> Si
On Fri, Dec 04, 2020 at 05:19:25PM +0800, wanghai (M) wrote:
>
> 在 2020/12/4 16:40, Johan Hovold 写道:
> > On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> >> Add the missing unlock before return from function
> >> gbaudio_dapm_free_controls() in the error
found\n",
> widget->name);
> - return -EINVAL;
> + widget++;
> + continue;
> }
> widget++;
> #ifdef CONFIG_DEBUG_FS
Not sure if
On Fri, Dec 04, 2020 at 07:33:35PM +0100, Uwe Kleine-König wrote:
> drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
> should stick to the atomic API instead.
> ---
No sign off?
Please also add a staging prefix since this part of greybus still lives
there.
> drivers/s
On Tue, Dec 08, 2020 at 11:16:07AM +0100, Uwe Kleine-König wrote:
> drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
> should stick to the atomic API instead.
>
> Signed-off-by: Uwe Kleine-König
> ---
> On 12/8/20 10:39 AM, Johan Hovold wrot
On Fri, Dec 11, 2020 at 08:29:22PM +0800, wanghai (M) wrote:
>
> 在 2020/12/8 17:35, Johan Hovold 写道:
> > On Sat, Dec 05, 2020 at 06:38:27PM +0800, Wang Hai wrote:
> >> In gbaudio_dapm_free_controls(), if one of the widgets is not found, an
> >> error
> >>
On Mon, Dec 21, 2020 at 09:02:46PM +0800, Zheng Yongjun wrote:
> Fix a missing unlock in the error branch.
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/staging/greybus/audio_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/audio_helper.c
> b/drivers
On Mon, Jan 04, 2021 at 03:34:10PM +0300, Dan Carpenter wrote:
> There is a Smatch warning for this, but I hadn't looked at the results
> in a while. :/ I'm not sure how many are valid. Some kind of
> annotation would be nice.
> drivers/usb/class/usblp.c:593 usblp_ioctl() error: doing dma on th
iver so that it
> hooks up to the kernel and userspace correctly.
>
> Cc: Johan Hovold
> Cc: Alex Elder
> Signed-off-by: Greg Kroah-Hartman
> ---
> drivers/staging/greybus/vibrator.c | 59 ++
> 1 file changed, 59 insertions(+)
>
> di
On Wed, Jan 06, 2021 at 01:04:04PM +0100, Johan Hovold wrote:
> On Tue, Jan 05, 2021 at 04:19:02PM +0100, Greg Kroah-Hartman wrote:
> > The correct user/kernel api for vibrator devices is the Input rumble
> > api, not a random sysfs file like the greybus vibrator driver cur
On Thu, Nov 22, 2018 at 10:37:16PM +0530, Nishad Kamdar wrote:
> Convert the GPIO driver to use the GPIO irqchip library
> GPIOLIB_IRQCHIP instead of reimplementing the same.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v2:
> - Retained irq.h and irqdomain.h headers.
> - Dropped function
On Thu, Nov 22, 2018 at 10:38:18PM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v2:
> - Resolved compilation errors.
> ---
> drivers/staging/greybus/arche-apb-ctrl.c | 159
On Thu, Nov 22, 2018 at 10:39:24PM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated
> old non-descriptor interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v2:
> - Move comment to the same line as to what it applies to.
> ---
> drivers/staging/greybus/
On Sat, Dec 22, 2018 at 08:17:02PM +0530, Nishad Kamdar wrote:
> Convert the GPIO driver to use the GPIO irqchip library
> GPIOLIB_IRQCHIP instead of reimplementing the same.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v4:
> - Remove changes related to conversion to gpiochip_get_data() t
On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote:
> This patch drops gpio_chip_to_gb_gpio_controller(),
> and uses gpiochip_get_data() to retrieve the container
> of struct gpio_chip.
So this will break the driver, since gpiochip_add() sets the data
pointer to NULL.
These kind of cha
On Sat, Dec 22, 2018 at 08:22:09PM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v4:
> - Use gpiod_set_raw_value() for deassert_reset() and
>assert_reset() as gpiod_set_value
On Sat, Dec 22, 2018 at 08:23:02PM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated
> old non-descriptor interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v4:
> - Move 'gpio_desc *svc_sysboot' below the reset flag
>as it is more logical to have res
s in v3:
> - Combine patches as into a patch series.
> Changes in v2:
> - Retained irq.h and irqdomain.h headers.
> - Dropped function gb_gpio_irqchip_add() and
>called gpiochip_irqchip_add() from probe().
> - Referred
> https://lkml.kernel.org/r/1476054589-28422-1-git-send-ema
> - Add this patch in a patchset.
> Changes in v2:
> - Resolved compilation errors.
> ---
Also looks good now. You can add my
Reviewed-by: Johan Hovold
Found one really minor nit below, which doesn't really need to be fixed,
but since you may need to update the third patch, you mi
or
messages. The issues are there in the current code, but since you modify
these messages anyway you might as well fix them up. Please fix that and
resend with my
Reviewed-by: Johan Hovold
Really good job with this!
> @@ -435,6 +428,7 @@ static int arche_platform_probe(struct platform_d
On Fri, Jan 11, 2019 at 09:03:16PM +0530, Nishad Kamdar wrote:
> This patch series converts uses of the old GPIO API to the GPIO
> descriptor API. It also converts the GPIO driver to use the
> GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing
> the same.
>
> Changes in v6:
> - Patch
On Mon, Jan 14, 2019 at 08:25:07PM +0530, Nishad Kamdar wrote:
> This patch series converts uses of the old GPIO API to the GPIO
> descriptor API. It also converts the GPIO driver to use the
> GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing
> the same.
>
> Chnages in v7:
> - Combi
hawaja
Cc: Samuel Thibault
Signed-off-by: Johan Hovold
---
drivers/staging/speakup/spk_ttyio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/spk_ttyio.c
b/drivers/staging/speakup/spk_ttyio.c
index c92bbd05516e..005de0024dd4 100644
--- a/drive
On Mon, Jan 28, 2019 at 02:29:22PM -0700, shuah wrote:
> On 1/25/19 9:14 PM, Al Viro wrote:
> > On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote:
> >> tty_set_termios() has the following WARMN_ON which can be triggered with a
> >> syscall to invoke TIOCGETD __NR_ioctl.
You meant TIOCSETD
On Thu, Jan 31, 2019 at 04:18:33PM +0100, Marcel Holtmann wrote:
> > I agree with Al that this change doesn't make much sense. The WARN_ON
> > is there to catch any bugs leading to the termios being changed for a
> > master side pty. Those should bugs should be fixed, and not worked
> > around in
this could still cause trouble on the remote end due to the
unexpected message size.
Fixes: 9d15134d067e ("greybus: power_supply: rework get descriptors")
Cc: stable # 4.9
Cc: Rui Miguel Silva
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/power_supply.c | 2 +-
1 file
On Wed, Apr 03, 2019 at 03:58:01PM -0500, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, replace code of the following form:
On Thu, Apr 04, 2019 at 08:09:51AM +0100, Rui Miguel Silva wrote:
> Hi Gustavo,
> Thanks a lot for the patch.
>
> On Wed 03 Apr 2019 at 21:58, Gustavo A. R. Silva wrote:
> > Make use of the struct_size() helper instead of an open-coded
> > version
> > in order to avoid any potential type mistakes
On Wed, Aug 28, 2019 at 11:28:59AM +0100, Rui Miguel Silva wrote:
> More headers needed to be fixed when moving greybus out of staging and
> enabling the COMPILE_TEST option.
>
> Reported-by: kbuild test robot
> Signed-off-by: Rui Miguel Silva
> ---
> include/linux/greybus/operation.h | 1 +
>
ed-off-by: Rui Miguel Silva
> ---
> v1->v2:
> Johan Hovold:
> - use forward declarations instead including all headers
Reviewed-by: Johan Hovold
> include/linux/greybus/operation.h | 2 +-
> include/linux/greybus/svc.h | 2 ++
> 2 files changed, 3 insertions(+),
On Wed, Sep 04, 2019 at 08:55:58PM +, joahannes wrote:
> Fix checkpatch error
> "CHECK: Blank lines aren't necessary after an open brace '{'"
> in loopback_test.c:742.
Please fix up all of the blank lines before/after closing/opening brace
checkpatch CHECKs in one go. There appears to be many
On Wed, Sep 04, 2019 at 08:32:09PM +, Julio Faracco wrote:
> Inside a block of if..else conditional, else structure does not contain
> brackets. This is not following regular policies of good coding style.
s/good/kernel/ ?
> All parts of this conditional blocks should respect brackets inclusi
On Wed, Sep 04, 2019 at 09:05:47PM +, Pedro Chinen wrote:
> Fix following checkpath warnings in multiple lines:
> CHECK: Please don't use multiple blank lines
Checkpatch reports five instances of this CHECK, please fix them all in
one go.
> Signed-off-by: Pedro Chinen
> ---
> drivers/stagin
On Sun, Mar 31, 2019 at 01:30:40AM -0400, Will Cunningham wrote:
> Line was >80 characters.
>
> Signed-off-by: Will Cunningham
> ---
> drivers/staging/greybus/usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greyb
On Fri, Apr 05, 2019 at 05:50:10PM -0500, Alex Elder wrote:
> On 4/5/19 3:53 PM, Dan Carpenter wrote:
> > On Fri, Apr 05, 2019 at 03:00:46PM -0500, Madhumitha Prabakaran
> > wrote:
> >> Fix spinlock_t definition without comment.
> >>
> >> Signed-off-by: Madhumitha Prabakaran
>
> Madhumitha, the
On Fri, Apr 05, 2019 at 03:14:37PM -0500, Madhumitha Prabakaran wrote:
> Fix a blank line after function/struct/union/enum
> declarations. Also, convert to_gb_control() macro into an inline
> function in order to maintain Linux kernel coding style based
> on which the inline function is preferable
On Mon, Apr 15, 2019 at 04:33:57PM +0300, Dan Carpenter wrote:
> On Mon, Apr 15, 2019 at 03:10:02PM +0200, Johan Hovold wrote:
> > On Fri, Apr 05, 2019 at 03:14:37PM -0500, Madhumitha Prabakaran wrote:
> > > Fix a blank line after function/struct/union/enum
> > >
On Mon, Apr 15, 2019 at 05:40:16PM +0300, Dan Carpenter wrote:
> What I'm saying is that if we just apply it then we avoid the long
> discussion forever. The macro is OK, sure, but it's not like anyone is
> going to come back later and argue that macros are better or preferred.
That may be a vali
On Wed, Apr 17, 2019 at 06:19:50AM -0500, Alex Elder wrote:
> I'm not completely sure about the inline function, but on the no blank
> lines thing (and many other minor issues) "checkpatch.pl" is to blame.
> There are lots of examples of issues that checkpatch points out that are
> matters of opin
in v2:
> - Rebase on top of 47830c1127ef ("staging: greybus: power_supply: fix
> prop-descriptor request size")
Thanks for rebasing.
Reviewed-by: Johan Hovold
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greg Kroah-Hartman
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/spilib.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
index e97b19148497..1e7321a1404c 100644
--- a/drivers/staging/greybu
On Sun, Oct 29, 2017 at 06:13:28PM +0530, Viresh Kumar wrote:
> On 29-10-17, 13:01, Johan Hovold wrote:
> > Remove erroneous spi_master_put() after controller deregistration which
> > would access the already freed spi controller.
> >
> > Note that spi_unregis
to pass the timer pointer explicitly.
> >
> > Cc: Greg Kroah-Hartman
> > Cc: "Bryan O'Donoghue"
> > Cc: Johan Hovold
> > Cc: Alex Elder
> > Cc: greybus-...@lists.linaro.org
> > Cc: de...@driverdev.osuosl.org
> >
the new timer_setup() and from_timer()
> > to pass the timer pointer explicitly.
> >
> > Cc: Greg Kroah-Hartman
> > Cc: "Bryan O'Donoghue"
> > Cc: Johan Hovold
> > Cc: Alex Elder
> > Cc: greybus-...@lists.linaro.org
> > Cc: de...@driv
On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote:
> On 30/10/17 11:32, Johan Hovold wrote:
> > The right thing to do here is to respin your patch from last year which
> > converts the loopback driver to use the timeout handling in greybus
> > core.
>
On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote:
>
>
> On 30/10/17 11:38, Johan Hovold wrote:
> > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote:
> >> On 30/10/17 11:32, Johan Hovold wrote:
> >>> The right thing to
h and get/set
As I mentioned in my review of v3 (back in January), this should be
s/operation.h/struct gb_operation/.
> methods to access that pointer.
>
> Signed-off-by: Bryan O'Donoghue
Reviewed-by: Johan Hovold
> --- a/drivers/staging/greybus/operation.h
> +++ b/drivers/
hanks for respinning this one, Bryan. Nice diff stat too.
Note however that this patch depends on Arnd's
[PATCH 2/2] staging: greybus/loopback: use ktime_get() for time
intervals
which hasn't been applied yet.
> Signed-off-by: Bryan O'Donoghue
> Cc: Johan Hovold
&g
mmit d9fb3754ecf8 ("greybus: loopback: Relax locking during
> loopback operations").
>
> Fixes: 8e1d6c336d74 ("greybus: loopback: drop bus aggregate calculation")
>
> Signed-off-by: Bryan O'Donoghue
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: Greg Kroah-H
at it neglects to do though is increment the per-connection
> gb->iteration_count on an asynchronous operation error. This patch fixes
> that omission.
>
> Fixes: 12927835d211 ("greybus: loopback: Add asynchronous bi-directional
> support")
>
> Signed-off-by: Br
>
> Signed-off-by: Bryan O'Donoghue
Reviewed-by: Johan Hovold
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ntifier based on the license text in the file itself. The
> SPDX identifier is a legally binding shorthand, which can be used
> instead of the full boiler plate text.
>
> This work is based on a script and data from Thomas Gleixner, Philippe
> Ombredanne, and Kate Stewart.
>
>
text was removed.
>
> Cc: Vaibhav Hiremath
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: Greg Kroah-Hartman
> Cc: Vaibhav Agarwal
> Cc: Mark Greer
> Cc: Viresh Kumar
> Cc: Rui Miguel Silva
> Cc: David Lin
> Cc: "Bryan
On Fri, Aug 24, 2018 at 12:07:11AM -0400, Ding Xiang wrote:
> If fw is null then fw->size will trigger null pointer dereference
>
> Signed-off-by: Ding Xiang
> ---
> drivers/staging/greybus/bootrom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus
On Thu, Feb 09, 2017 at 05:30:12PM +0100, Gioh Kim wrote:
> Fix "Octal permissions are preffered than symbolic ones" issues.
>
> Signed-off-by: Gioh Kim
Acked-by: Johan Hovold
___
devel mailing list
de...@linuxdri
On Thu, Feb 09, 2017 at 05:30:11PM +0100, Gioh Kim wrote:
> This patch fixes only obvious lines.
> There are still more issues.
Please make this commit message self-contained (e.g. mention what you
are doing here and why).
> Signed-off-by: Gioh Kim
> ---
> drivers/staging/greybus/arche-apb-ctrl
[+CC: greybus and staging lists]
On Sat, Feb 18, 2017 at 01:47:38PM +0530, sayli karnik wrote:
> Change array index from the loop bound variable to loop index.
> The open_poll_files() functions attempts to open poll files of devices
> numbered from 0 to device_count. If the open() function inside
x2; ex1++) { <...
> arr[
> - ex2
> + ex1
> ]
> ...> }
>
> Signed-off-by: sayli karnik
> ---
> v2:
> Made the subject and changelog more concise
Thanks for the update.
Reviewed-by: Johan Hovold
Johan
___
devel mailing list
de...@l
On Tue, Feb 21, 2017 at 02:20:50PM +0100, Julia Lawall wrote:
>
>
> On Tue, 21 Feb 2017, simran singhal wrote:
>
> > This patch removes braces for single statement blocks. The warning
> > was detected using checkpatch.pl.
> > Coccinelle was used to make the change.
> >
> > @@
> > expression e,e1
On Mon, Feb 27, 2017 at 12:52:17PM -0800, Jonathan Bowie wrote:
> fixed a simple style issue in tools/loopback_test.c
Please mention what kind of style issue you're addressing.
Also make sure your patch summary (Subject) is on the format
staging: greybus: loopback_test: add missing space
On Wed, Mar 01, 2017 at 02:30:02AM -0800, Jonathan Bowie wrote:
> Fixed incosistent spacing around arithmetic operator.
>
> v2
> -fixed subject, added changelog
> v3
> -CC:ed linux-next incorrectly, added proper summary
> v4
> -CC:ed staging mailing list, moved changelog to summary body
As I ment
> -CC:ed correct mailing list, moved changelog to summary body
> v5
> -correctly placed changelog
All good now!
Thanks for sticking to it (and nevermind the changelog typo ;) ).
Reviewed-by: Johan Hovold
Johan
___
devel mailing li
; avoid busy waiting.
>
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
>
> Signed-off-by: Jia-Ju Bai
This all looks good (also note the call to usb_control_msg(), which may
sleep, j
() to busily wait.
> This is not necessary and can be replaced with usleep_range() to
> avoid busy waiting.
>
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
>
> Signed-off-by: Jia-Ju Bai
Reviewed-by: Johan Hovold
On Thu, Apr 19, 2018 at 04:06:17PM +0200, Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Acked-by: Johan Hovold
_
On Thu, Apr 19, 2018 at 10:41:15AM +0200, Linus Walleij wrote:
> To make sure that these drivers do not leave staging before they
> are properly converted to use the new GPIO descriptor API, and the
> GPIOLIB_IRQCHIP helper library, create the TODO file with these work
> items.
&g
On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote:
> Replace the manual validity checks for the GPIO with the
> gpio_is_valid().
>
> Signed-off-by: Arvind Yadav
> ---
> chnage in v2 :
> Returning invalid gpio as error instead of -ENODEV.
>
> drivers/staging/greybus/arche
On Wed, May 02, 2018 at 03:15:05PM +0530, Arvind Yadav wrote:
> On Wednesday 02 May 2018 02:13 PM, Johan Hovold wrote:
> > On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote:
> >> Replace the manual validity checks for the GPIO with the
> >> gpio_is_valid
rror after removing this, i.e "reset set but unused" ? Or
> the sizeof() operation on that suppresses those warnings ..
That was my initial reaction as well, but I failed to notice the sizeof
which prevents the new warning.
> Acked-by: Viresh Kumar
Acked-by: Johan Hovold
Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
amera driver by not caring about the value of
> debugfs calls. This ends up removing a number of lines of code that
> are not needed.
>
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: Greg Kroah-Hartman
> Cc: greybus-...@lists.linaro.org
> Signed-off-by: Greg
On Tue, Jun 05, 2018 at 11:02:36AM +0530, Viresh Kumar wrote:
> On 03-06-18, 08:52, Janani Sankara Babu wrote:
> > This patch replaces comparison of var to NULL with !var
> >
> > Signed-off-by: Janani Sankara Babu
> > ---
> > drivers/staging/greybus/core.c | 2 +-
> > 1 file changed, 1 insertion
Fix a file entry typo and drop the obsolete timesync entries, which were
all caught by:
scripts/get_maintainer.pl --self-test=patterns
Reported-by: Joe Perches
Signed-off-by: Johan Hovold
---
This has been reported and at least partially fixed in the past, but due
to various other
dt
Signed-off-by: Johan Hovold
---
drivers/staging/isdn/gigaset/usb-gigaset.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c
b/drivers/staging/isdn/gigaset/usb-gigaset.c
index 5e393e7dde45..a84722d83bc6 100644
--- a/drivers/st
emens Gigaset drivers - M105 USB
DECT adapter")
Cc: stable # 2.6.17
Cc: Hansjoerg Lipp
Cc: Tilman Schmidt
Signed-off-by: Johan Hovold
---
drivers/staging/isdn/gigaset/usb-gigaset.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c
b/drive
Rename an endpoint-descriptor pointer to shut up a checkpatch warning
about a line being over 80 columns, which is bound to generate a bunch
of clean up patches otherwise.
Signed-off-by: Johan Hovold
---
drivers/staging/isdn/gigaset/usb-gigaset.c | 20 ++--
1 file changed, 10
Add endpoint type-sanity checks to prevent a warning in USB core on URB
submission.
Signed-off-by: Johan Hovold
---
drivers/staging/isdn/gigaset/usb-gigaset.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c
b/drivers/staging/isdn
the crashes have been fixed.
And while I hate playing checkpatch games, the final patch addresses a
checkpatch warning introduced on purpose by the third patch.
Johan
Johan Hovold (4):
staging: gigaset: fix general protection fault on probe
staging: gigaset: fix illegal free on probe errors
On Fri, Nov 29, 2019 at 02:32:39PM +0100, Greg Kroah-Hartman wrote: > On Fri,
Nov 29, 2019 at 11:17:49AM +0100, Johan Hovold wrote:
> > Syzbot has been reporting a GPF on probe in the gigaset ISDN driver,
> > which have since been moved to staging.
> >
> > The first
On Sun, Dec 01, 2019 at 01:41:56PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 01, 2019 at 01:30:42PM +0100, Tilman Schmidt wrote:
> > Hi Johan,
> >
> > this is probably caused by the move of the driver to staging in
> > kernel release 5.3 half a year ago. If you want your patches to
> > apply
Add missing endpoint-type sanity checks to probe.
This specifically prevents a warning in USB core on URB submission when
fuzzing USB descriptors.
Signed-off-by: Johan Hovold
---
drivers/staging/isdn/gigaset/usb-gigaset.c | 12
1 file changed, 12 insertions(+)
diff --git a
dt
Signed-off-by: Johan Hovold
---
drivers/staging/isdn/gigaset/usb-gigaset.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c
b/drivers/staging/isdn/gigaset/usb-gigaset.c
index 5e393e7dde45..a84722d83bc6 100644
--- a/drivers/st
the crashes have been fixed.
Johan
Changes in v2
- use usb_endpoint_is_bulk_out() and friends in patch 3/3, and drop
patch 4/4 which only renamed an identifier.
Johan Hovold (3):
staging: gigaset: fix general protection fault on probe
staging: gigaset: fix illegal free on probe errors
emens Gigaset drivers - M105 USB
DECT adapter")
Cc: stable # 2.6.17
Cc: Hansjoerg Lipp
Cc: Tilman Schmidt
Signed-off-by: Johan Hovold
---
drivers/staging/isdn/gigaset/usb-gigaset.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c
b/drive
("staging: r8188eu: Add files for new driver - part 20")
Cc: stable # 3.12
Signed-off-by: Johan Hovold
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging
("staging: r8712u: Add the new driver to the mainline
kernel")
Cc: stable # 2.6.37
Signed-off-by: Johan Hovold
---
drivers/staging/rtl8712/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/usb_intf.c
b/drivers/staging/rtl8712/
yzbot), I've marked these for stable as well.
Johan
Johan Hovold (2):
staging: rtl8188eu: fix interface sanity check
staging: rtl8712: fix interface sanity check
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
drivers/staging/rtl8712/usb_intf.c | 2 +-
2 files changed, 2
On Sat, Dec 14, 2019 at 05:05:58PM -0600, Navid Emamdoost wrote:
> In the implementation of alloc_rtllib() the allocated dev is leaked in
> case of ieee->pHTInfo allocation failure. Release via free_netdev(dev).
>
> Fixes: 6869a11bff1d ("Staging: rtl8192e: Use !x instead of x == NULL")
This is no
1 - 100 of 223 matches
Mail list logo
