Re: [RFC][PATCH 2/6] staging: android: ion: Switch to using an idr to manage heaps

2016-06-08 Thread Liviu Dudau
unc__, heap->id, ret); > + up_write(>lock); > + return ret < 0 ? ret : -EINVAL; > + } > + > debug_file = debugfs_create_file(heap->name, 0664, > dev->heaps_debug_root, heap, >

Re: [RFC][PATCH 1/6] staging: android: ion: return error value for ion_device_add_heap

2016-06-08 Thread Liviu Dudau
On Mon, Jun 06, 2016 at 11:23:28AM -0700, Laura Abbott wrote: > From: Laura Abbott <labb...@fedoraproject.org> > > > ion_device_add_heap doesn't return an error value. Change it to return > information to callers. > > Signed-off-by: Laura Abbott <labb...@redhat.

Re: [RFC][PATCH 4/6] staging: android: ion: Pull out ion ioctls to a separate file

2016-06-08 Thread Liviu Dudau
On Mon, Jun 06, 2016 at 11:23:31AM -0700, Laura Abbott wrote: > > The number of Ion ioctls may continue to grow along with necessary > validation. Pull it out into a separate file for easier management > and review. > > Signed-off-by: Laura Abbott <labb...@redhat.com>

Re: [RFC][PATCH 6/6] staging: android: ion: Introduce new ioctls for dynamic heaps

2016-06-08 Thread Liviu Dudau
On Mon, Jun 06, 2016 at 11:23:33AM -0700, Laura Abbott wrote: > From: Laura Abbott > > > The Ion ABI for heaps is limiting to work with for more complex systems. > Heaps have to be registered at boot time with known ids available to > userspace. This becomes a tight

Re: [RFC][PATCH 1/3] staging: ion: Move away from the DMA APIs for cache flushing

2016-05-26 Thread Liviu Dudau
On Wed, May 25, 2016 at 12:48:02PM -0700, Laura Abbott wrote: > > Ion is currently using the DMA APIs in non-compliant ways for cache > maintaince. The issue is Ion needs to do cache operations outside of > the regular DMA model. The Ion model matches more closely with the > DRM model which calls