[PATCH] staging/lustre/lnet: Fix allocation size for sv_cpt_data

2017-02-19 Thread Oleg Drokin
ned-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/selftest/rpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c b/drivers/staging/lustre/lnet/selftest/rpc.c index 92cd411..87fe366 100644 --- a/drivers/staging/lustre/lnet/self

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

2017-02-24 Thread Oleg Drokin
gt; time. >> >> Signed-off-by: Alex Zhuravlev >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6838 >> Reviewed-on: https://review.whamcloud.com/18028 >> Reviewed-by: Andreas Dilger >> Reviewed-by: wangdi >> Reviewed-by: Mike Pershin >> Review

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

2017-02-24 Thread Oleg Drokin
gt; time. >> >> Signed-off-by: Alex Zhuravlev >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6838 >> Reviewed-on: https://review.whamcloud.com/18028 >> Reviewed-by: Andreas Dilger >> Reviewed-by: wangdi >> Reviewed-by: Mike Pershin >> Review

Re: [lustre-devel] [PATCH] staging: lustre: fix sparse warning about different address spaces

2017-03-06 Thread Oleg Drokin
On Mar 1, 2017, at 6:57 PM, Mario Bambagini wrote: > fixed the following sparse warning by adding proper cast: > drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: > incorrect type in argument 2 (different address spaces) > drivers/staging//lustre/lustre/obdclass/obd_config.c

[PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-17 Thread Oleg Drokin
Ever since sysfs migration, class_process_proc_param stopped working correctly as all the useful params were no longer present as lvars. Replace all the nasty fake proc writes with hopefully less nasty kobject attribute search and then update the attributes as needed. Signed-off-by: Oleg Drokin

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Oleg Drokin
On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace al

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Oleg Drokin
On Mar 19, 2017, at 12:29 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 11:17:55AM -0400, Oleg Drokin wrote: >> >> On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: >> >>> On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: &

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Oleg Drokin
On Mar 19, 2017, at 12:41 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace al

Re: [PATCH 1/1] Staging: lustre: lnet: libcfs: Fixed checkpatch.pl coding style errors

2017-03-28 Thread Oleg Drokin
On Mar 28, 2017, at 6:10 AM, wrote: > From: Vaibhav Kothari > > Shifted open brace { to previous line for 8 functions as indicated by > checkpatch.pl > > Signed-off-by: Vaibhav Kothari > --- > drivers/staging/lustre/lnet/libcfs/hash.c | 43 +++ > 1 file changed,

Re: [PATCH] staging: lustre: delete the filesystem from the tree.

2018-06-01 Thread Oleg Drokin
/staging/lustre/lustre/obdclass/lustre_handles.c >> delete mode 100644 drivers/staging/lustre/lustre/obdclass/lustre_peer.c >> delete mode 100644 drivers/staging/lustre/lustre/obdclass/obd_config.c >> delete mode 100644 drivers/staging/lustre/lustre/obdclass/obd_mount.c >> de

Re: [PATCH] staging/lustre: Always try kmalloc first for OBD_ALLOC_LARGE

2015-05-03 Thread Oleg Drokin
re any anymore. This is what Julia is doing. I am providing the stub for her wonderful scripts to unwrap per her request. >> + */ >> +/* >> + * Copyright (c) 2015, Oleg Drokin > > I think your employer would like a different line here...

Re: [RFC PATCH 0/3] Moving lustre procfs stuff to sysfs & questions.

2015-05-03 Thread Oleg Drokin
On May 3, 2015, at 2:15 PM, Greg Kroah-Hartman wrote: >> Also I found that cgroup does calls into kernfs directly, gaining >> ability to register seq_file files and otherwise do all sorts of >> stuff that would be cool to do from lustre too ;) > If you want to make lustrefs, be my guest, you can

Re: [PATCH 2/3] staging/lustre: Move /proc/fs/lustre root level files to sysfs

2015-05-03 Thread Oleg Drokin
On May 3, 2015, at 2:13 PM, Greg Kroah-Hartman wrote: >> >> -#if defined (CONFIG_PROC_FS) >> -static int obd_proc_version_seq_show(struct seq_file *m, void *v) >> +static ssize_t version_show(struct kobject *kobj, char *buf) >> { >> -seq_printf(m, "lustre: %s\nkernel: %s\nbuild: %s\n", >> -

Re: [PATCH 00/25] Start of removal of lustre procfs support

2015-05-17 Thread Oleg Drokin
Hm, Actually please don't merge this one yet. I have a better one in the works that I'll hopefully send in the next couple of days. Thanks. On May 16, 2015, at 3:30 AM, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > This is beginning of work in the area. It take

Re: [PATCH 54/58] staging/lustre/obd: remove unused proc_lustre_root

2015-05-30 Thread Oleg Drokin
On May 30, 2015, at 10:22 PM, Greg Kroah-Hartman wrote: > On Thu, May 21, 2015 at 03:32:28PM -0400, gr...@linuxhacker.ru wrote: >> From: Dmitry Eremin >> >> Signed-off-by: Dmitry Eremin >> --- >> drivers/staging/lustre/lustre/include/lprocfs_status.h | 3 --- >> .../lustre/lustre/obdclass/linu

Re: [staging:staging-testing 524/578] drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:721:343: warning: (near initialization for 'lustre_attr_recalc_period.store')

2015-05-30 Thread Oleg Drokin
On May 31, 2015, at 2:32 AM, Greg Kroah-Hartman wrote: > On Sun, May 31, 2015 at 11:59:50AM +0800, kbuild test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >> staging-testing >> head: 895875a3d85596e3e2e46aeb382bf14f1419de82 >> commit: 24b8c88a7122df

[PATCH 0/5] Lustre fixes

2014-02-08 Thread Oleg Drokin
This is a set of patches that eliminates rest of crashes and most leaks hit during standard lustre regression testing for me. This serie + O_LOV_DELAY_CREATE patch from Andreas (that was submitted separately and needs separate approval: http://www.spinics.net/lists/linux-fsdevel/msg72386.html ) ma

[PATCH 5/5] lustre: don't leak llog handle in llog_cat_process_cb()

2014-02-08 Thread Oleg Drokin
eas Dilger Reviewed-by: jacques-Charles Lafoucriere Reviewed-by: Mike Pershin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/llog_cat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/llog_cat.c b/drivers/stag

[PATCH 1/5] lustre/lov: avoid subobj's coh_parent race

2014-02-08 Thread Oleg Drokin
the lovsub device reference > 0 during its finalization phase. Signed-off-by: Bobi Jam Reviewed-on: http://review.whamcloud.com/6105 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1480 Reviewed-by: Lai Siyao Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin Signed-off-by: Oleg

[PATCH 4/5] lustre/xattr: separate ACL and XATTR caches

2014-02-08 Thread Oleg Drokin
: Nathaniel Clark Reviewed-on: http://review.whamcloud.com/7208 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3669 Reviewed-by: Andreas Dilger Reviewed-by: John L. Hammond Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 1 - drivers/staging/lustre/lustre

[PATCH 3/5] lustre: instantiate negative dentry

2014-02-08 Thread Oleg Drokin
Reviewed-by: James Simmons Reviewed-by: Bob Glossman Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/namei.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite

[PATCH 2/5] lustre: Unsafe error handling around ll_splice_alias

2014-02-08 Thread Oleg Drokin
. Signed-off-by: Swapnil Pimpale Reviewed-on: http://review.whamcloud.com/7460 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3807 Reviewed-by: Fan Yong Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/namei.c | 9

[PATCH 05/17] lustre/mdc: use ibits_known mask for lock match

2014-02-28 Thread Oleg Drokin
: http://review.whamcloud.com/8636 Xyratex-bug-id: MRP-1583 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4405 Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_export.h | 8 drivers/staging/lustre/lustre

[PATCH 10/17] lustre/ldlm: set l_lvb_type coherent when layout is returned

2014-02-28 Thread Oleg Drokin
Reviewed-by: Johann Lombardi Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 1 + drivers/staging/lustre/lustre/mdc/mdc_locks.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/staging/lustre/lustre

[PATCH 03/17] lustre/llite: Do not send parent dir fid in getattr by fid

2014-02-28 Thread Oleg Drokin
Sending getattr by fid in this case is pointless, as the parent might havelong changed and we have no control over it, but it's irrelevant anyway, since we already have the child fid. Signed-off-by: Oleg Drokin Reviewed-on: http://review.whamcloud.com/7910 Intel-bug-id:

[PATCH 02/17] lustre/mdc: Check for all attributes validity in revalidate

2014-02-28 Thread Oleg Drokin
GETATTR needs to return attributes protected by different bits, so we need to ensure all we have locks with all of those bits, not just UPDATE bit Signed-off-by: Alexey Lyashkov Signed-off-by: Oleg Drokin Reviewed-on: http://review.whamcloud.com/6460 Xyratex-bug-id: MRP-1052 Intel-bug-id: https

[PATCH 06/17] lustre/clio: honor O_NOATIME

2014-02-28 Thread Oleg Drokin
ng O_NOATIME to open() is honored. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/7442 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3832 Reviewed-by: Jinshan Xiong Reviewed-by: Lai Siyao Tested-by: Maloo Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin ---

[PATCH 04/17] lustre/mdc: comments on LOOKUP and PERM lock

2014-02-28 Thread Oleg Drokin
From: wang di Add more comments for MDS_INODELOCK_PERM and MDS_INODELOCK_LOOKUP Signed-off-by: wang di Reviewed-on: http://review.whamcloud.com/7937 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3240 Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin

[PATCH 07/17] lustre/mdc: fix bad ERR_PTR usage in mdc_locks.c

2014-02-28 Thread Oleg Drokin
L. Hammond Reviewed-on: http://review.whamcloud.com/7886 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4078 Reviewed-by: Andreas Dilger Reviewed-by: Nathaniel Clark Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 20 ++-- 1 file changed, 10 inserti

[PATCH 01/17] staging/lustre/llite: fix open lock matching in ll_md_blocking_ast()

2014-02-28 Thread Oleg Drokin
es in both functions. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/8718 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4429 Reviewed-by: Niu Yawei Reviewed-by: Jinshan Xiong Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ll

[PATCH 00/17] Lustre stability patches

2014-02-28 Thread Oleg Drokin
x bad ERR_PTR usage in mdc_locks.c Lai Siyao (1): lustre/llite: simplify dentry revalidate Liang Zhen (2): lustre/ptlrpc: rq_commit_cb is called for twice lustre/ptlrpc: re-enqueue ptlrpcd worker Niu Yawei (1): lustre/quota: improper assert in osc_quota_chkdq() Oleg Drokin (3): lustre/mdc:

[PATCH 08/17] lustre/recovery: free open/close request promptly

2014-02-28 Thread Oleg Drokin
-2613 Reviewed-by: Alex Zhuravlev Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 6 +- .../staging/lustre/lustre/include/lustre_export.h | 9 +++ .../staging/lustre/lustre/include/lustre_import.h | 11 +++ drivers/staging/lustre

[PATCH 14/17] lustre/ptlrpc: re-enqueue ptlrpcd worker

2014-02-28 Thread Oleg Drokin
ttp://review.whamcloud.com/8922 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4509 Reviewed-by: Jinshan Xiong Reviewed-by: Bobi Jam Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/client.c | 64 +-- 1 file changed, 40 insertion

[PATCH 12/17] lustre/ptlrpc: skip rpcs that fail ptl_send_rpc

2014-02-28 Thread Oleg Drokin
://jira.hpdd.intel.com/browse/LU-3698 Reviewed-by: Mike Pershin Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/client.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre

[PATCH 11/17] lustre/ptlrpc: rq_commit_cb is called for twice

2014-02-28 Thread Oleg Drokin
ug-id: https://jira.hpdd.intel.com/browse/LU-3618 Reviewed-by: Alex Zhuravlev Reviewed-by: Bobi Jam Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/client.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/l

[PATCH 15/17] lustre/osc: Don't flush active extents.

2014-02-28 Thread Oleg Drokin
ritten out. Signed-off-by: Ann Koehler Reviewed-on: http://review.whamcloud.com/8278 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4253 Reviewed-by: Jinshan Xiong Reviewed-by: Alex Zhuravlev Reviewed-by: Alexey Lyashkov Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/stag

[PATCH 17/17] lustre/libcfs: warn if all HTs in a core are gone

2014-02-28 Thread Oleg Drokin
dreas Dilger Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/libcfs/linux/linux-cpu.c| 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-

[PATCH 09/17] lustre/llite: simplify dentry revalidate

2014-02-28 Thread Oleg Drokin
http://review.whamcloud.com/7475 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3544 Reviewed-by: Peng Tao Reviewed-by: Bob Glossman Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 2 +- drivers/staging/l

[PATCH 16/17] lustre/quota: improper assert in osc_quota_chkdq()

2014-02-28 Thread Oleg Drokin
Lombardi Reviewed-by: Fan Yong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/osc_quota.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_quota.c b/drivers/staging/lustre/lustre/osc/osc_quota.c index 6045a78..f395ae4

[PATCH 13/17] lustre/ptlrpc: fix 'data race condition' issues

2014-02-28 Thread Oleg Drokin
From: Sebastien Buisson Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by: Sebastien Buisson Reviewed-on: http://review.whamcloud.com/6

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-03-26 Thread Oleg Drokin
Hello! On Mar 26, 2014, at 4:44 AM, Geert Uytterhoeven wrote: >>> and http://kisskb.ellerman.id.au/kisskb/buildresult/10508264/ >>> will turn green again? >> I certainly hope so. > Ping? > We got a new "fix" for this in due to https://lkml.org/lkml/2014/2/13/479 Well, I certainly hoped for some b

[PATCH 02/47] staging/lustre/ptlrpc: Remove log message about export timer update

2014-04-27 Thread Oleg Drokin
-733 Signed-off-by: Cheng Shao Reviewed-on: http://review.whamcloud.com/9147 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4590 Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/service.c | 3 --- 1 file changed, 3 deletions(-) diff --git a

[PATCH 06/47] staging/lustre/lnet: Dropped messages are not accounted correctly

2014-04-27 Thread Oleg Drokin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4577 Reviewed-by: James Nunez Reviewed-by: James Simmons Reviewed-by: Isaac Huang Reviewed-by: Liang Zhen Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 01/47] staging/lustre/ptlrpc: Fix assertion failure of null_alloc_rs()

2014-04-27 Thread Oleg Drokin
Signed-off-by: Patrick Farrell Reviewed-on: http://review.whamcloud.com/8200 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3680 Reviewed-by: John L. Hammond Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 1 + drivers/staging/lustre/lustre/ptlrpc/sec.c

[PATCH 09/47] staging/lustre/ptlrpc: don't try to recover no_recov connection

2014-04-27 Thread Oleg Drokin
https://jira.hpdd.intel.com/browse/LU-4413 Reviewed-by: Nathaniel Clark Reviewed-by: wangdi Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/import.c | 29 +- drivers/staging/lustre/lustre/ptlrpc/recover.c | 5 - 2 files changed, 23 insertions(+

[PATCH 04/47] staging/lustre/gss: Shared key mechanism & flavors

2014-04-27 Thread Oleg Drokin
Reviewed-by: Ken Hornstein Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_sec.h | 17 ++ drivers/staging/lustre/lustre/ptlrpc/gss/Makefile | 3 +- .../lustre/lustre/ptlrpc/gss/gss_internal.h| 3 + .../staging/lustre/lustre/ptlrpc/gss/gss_sk_mech.c | 226

[PATCH 03/47] staging/lustre/gss: gssnull security flavor

2014-04-27 Thread Oleg Drokin
Korty Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3289 Reviewed-on: http://review.whamcloud.com/8475 Reviewed-by: Andreas Dilger Reviewed-by: Thomas Stibor Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_sec.h | 8 + drivers/staging/lustre/lustre/ptlrp

[PATCH 08/47] staging/lustre/clio: clear nowait flag agl lock re-enqueue

2014-04-27 Thread Oleg Drokin
https://jira.hpdd.intel.com/browse/LU-4597 Reviewed-by: Bobi Jam Reviewed-by: Jinshan Xiong Reviewed-by: Ned Bass Reviewed-by: Fan Yong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/osc_lock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/osc/osc_l

[PATCH 05/47] staging/lustre/osc: don't activate deactivated obd_import

2014-04-27 Thread Oleg Drokin
: http://review.whamcloud.com/8747 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4386 Reviewed-by: Andreas Dilger Reviewed-by: Fan Yong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/import.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/

[PATCH 00/47] Lustre fixes and cleanups

2014-04-27 Thread Oleg Drokin
Zhen (1): staging/lustre/lnet: NI shutdown may loop forever Matt Ezell (1): staging/lustre/lnet: Dropped messages are not accounted correctly Niu Yawei (1): staging/lustre/clio: clear nowait flag agl lock re-enqueue Oleg Drokin (1): staging/lustre: Fix unsafe userspace access in many proc

[PATCH 12/47] staging/lustre: restore __GFP_WAIT flag to memalloc calls

2014-04-27 Thread Oleg Drokin
://review.whamcloud.com/9223 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4357 Reviewed-by: Liang Zhen Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- .../staging/lustre/include/linux/libcfs/libcfs_private.h| 4 ++-- drivers/staging/lustre/lnet/klnds

[PATCH 13/47] staging/lustre/gss: fix uninitialized variable

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin 'sg->page_link' is used uninitialized in many functions. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/9325 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: James Simmons Reviewed-by: John L. Hammond Signed-off-by

[PATCH 14/47] staging/lustre: quiet console permission error messages

2014-04-27 Thread Oleg Drokin
: Faccini Bruno Reviewed-by: Bob Glossman Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c| 7 --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 5 - 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b

[PATCH 17/47] staging/lustre/hsm: count NULL terminator in hai_zero/hal_size

2014-04-27 Thread Oleg Drokin
: https://jira.hpdd.intel.com/browse/LU-4689 Reviewed-by: Andreas Dilger Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre

[PATCH 15/47] staging/lustre/lov: remove unused lov llog code

2014-04-27 Thread Oleg Drokin
y: Andreas Dilger Reviewed-by: Mike Pershin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/Makefile | 2 +- drivers/staging/lustre/lustre/lov/lov_internal.h | 4 - drivers/staging/lustre/lustre/lov/lov_log.c | 272 --- drivers/staging/lustre/

[PATCH 11/47] staging/lustre/ptlrpc: add rpc_cache

2014-04-27 Thread Oleg Drokin
: Lai Siyao Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/client.c | 42 ++ drivers/staging/lustre/lustre/ptlrpc/events.c | 2 +- .../staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 4 +++ .../staging/lustre/lustre/ptlrpc/ptlrpc_module.c | 32

[PATCH 07/47] staging/lustre/ldlm: Hold lock when clearing flag

2014-04-27 Thread Oleg Drokin
com/browse/LU-4269 Reviewed-by: Andreas Dilger Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c b/drivers/staging/lus

[PATCH 20/47] staging/lustre/llite: issue OST_SYNC for fsync()

2014-04-27 Thread Oleg Drokin
-id: https://jira.hpdd.intel.com/browse/LU-4388 Reviewed-by: Andreas Dilger Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/stag

[PATCH 18/47] staging/lustre/hsm: HSM requests not delivered

2014-04-27 Thread Oleg Drokin
ohn L. Hammond Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_net.h | 2 ++ drivers/staging/lustre/lustre/llite/dir.c | 5 + 2 files changed, 7 insertions(+) diff --git a/drivers/staging/lustre/lustre/include/lustre_net.h b/dr

[PATCH 24/47] staging/lustre/llite: Avoid statahead thread start/stop deadlocks

2014-04-27 Thread Oleg Drokin
se/LU-4624 Reviewed-by: Lai Siyao Reviewed-by: Fan Yong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/statahead.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/statahead.c b/drivers/stag

[PATCH 21/47] staging/lustre/llite: deadlock taking lli_trunc_sem during file write

2014-04-27 Thread Oleg Drokin
iewed-by: Lai Siyao Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_lib.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c index 7c4fd97..373a24f 1

[PATCH 10/47] staging/lustre/gss: fix few issues found by Klocwork Insight tool

2014-04-27 Thread Oleg Drokin
com/9274 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: James Simmons Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/gss/gss_bulk.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/stag

[PATCH 28/47] staging/lustre/ldlm: fix NULL pointer dereference

2014-04-27 Thread Oleg Drokin
/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: James Simmons Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lib.c b/drivers/staging/lustre/lustre/ldlm/ldlm

[PATCH 32/47] staging/lustre/lnet: NI shutdown may loop forever

2014-04-27 Thread Oleg Drokin
iewed-by: Isaac Huang Reviewed-by: Bobi Jam Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/api-ni.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c index f5a9ae3..3f

[PATCH 26/47] staging/lustre/llite: access layout version under a lock

2014-04-27 Thread Oleg Drokin
-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 22 --- .../staging/lustre/lustre/llite/llite_internal.h | 21 ++- drivers/staging/lustre/lustre/llite/llite_lib.c| 3 ++- drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +- drivers

[PATCH 37/47] staging/lustre/llite: Do not rate limit dirty page discard warning

2014-04-27 Thread Oleg Drokin
/9752 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4799 Reviewed-by: Cory Spitz Reviewed-by: Ann Koehler Reviewed-by: Chris Horn Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_lib.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --

[PATCH 25/47] stagaing/lustre: Improve statahead debug messages

2014-04-27 Thread Oleg Drokin
review.whamcloud.com/9360 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4624 Reviewed-by: Fan Yong Reviewed-by: Lai Siyao Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/statahead.c | 38 + 1 file changed, 20 insertions(+), 18 deletions(-)

[PATCH 34/47] staging/lustre/libcfs: add CPU table functions for uniprocessor

2014-04-27 Thread Oleg Drokin
Reviewed-by: Liang Zhen Reviewed-by: Oleg Drokin --- .../lustre/include/linux/libcfs/libcfs_cpu.h| 5 + .../lustre/include/linux/libcfs/linux/linux-mem.h | 5 + drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c | 21 + 3 files changed, 31 insertions(+) diff

[PATCH 38/47] staging/lustre/lloop: avoid panic during blockdev_info

2014-04-27 Thread Oleg Drokin
: Nathaniel Clark Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/lloop.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/lloop.c b/drivers/staging/lustre/lustre/llite/lloop.c index f78eda2

[PATCH 23/47] staging/lustre: Limit reply buffer size

2014-04-27 Thread Oleg Drokin
by: Brian Behlendorf Signed-off-by: Lai Siyao Reviewed-on: http://review.whamcloud.com/6339 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3338 Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Reviewed-by: Bob Glossman Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/

[PATCH 39/47] staging/lustre/clio: Solve a race in cl_lock_put

2014-04-27 Thread Oleg Drokin
Bobi Jam Reviewed-by: Lai Siyao Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/cl_lock.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c index

[PATCH 35/47] staging/lustre: replace semaphores with mutexes

2014-04-27 Thread Oleg Drokin
nce Lustre 1.6. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/9294 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4588 Reviewed-by: Andreas Dilger Reviewed-by: John L. Hammond Reviewed-by: James Simmons Reviewed-by: Alex Zhuravlev Signed-off-by: Oleg Drokin --

[PATCH 16/47] staging/lustre/obdclass: remove uses of lov_stripe_md

2014-04-27 Thread Oleg Drokin
d.com/8545 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-by: Bobi Jam Reviewed-by: Mike Pershin Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 26 + .../staging/lustre/lustre/include/lustre_debug.h | 1 - drivers/staging/lustre/lust

[PATCH 33/47] staging/lustre: remove lustre/include/ioctl.h

2014-04-27 Thread Oleg Drokin
From: "John L. Hammond" Remove the nowhere included header lustre/include/ioctl.h. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/9757 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-by: Bob Glossman Reviewed-by: Dmitry Eremin Signed-of

[PATCH 36/47] staging/lustre/clio: replace semaphore with mutex

2014-04-27 Thread Oleg Drokin
d.com/9095 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4257 Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_internal.h | 10 -- drivers/staging/lustre/lustre/llite/llite_lib.c | 12 +++-

[PATCH 44/47] staging/lustre: Always clamp cdls_delay between min and max

2014-04-27 Thread Oleg Drokin
://review.whamcloud.com/9503 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4711 Reviewed-by: Chris Horn Reviewed-by: Ann Koehler Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/tracefile.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 31/47] staging/lustre/libcfs: fix issues found by Klocwork Insight tool

2014-04-27 Thread Oleg Drokin
l.com/browse/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: James Simmons Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c | 2 +- drivers/staging/lustre/lustre/libcfs/nidstrings.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) di

[PATCH 46/47] staging/lustre: Fix unsafe userspace access in many proc files

2014-04-27 Thread Oleg Drokin
Apparently we are pretty bad about verifying our buffers passed from userspace. Signed-off-by: Oleg Drokin Reviewed-on: http://review.whamcloud.com/9059 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4563 Reviewed-by: Dmitry Eremin Reviewed-by: James Simmons --- drivers/staging/lustre

[PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-27 Thread Oleg Drokin
-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-by: Lai Siyao Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 4 +- drivers/staging/lustre/lustre/llite/dcache.c | 26 ++-- drivers/staging/lustre/lustre/l

[PATCH 19/47] staging/lustre: fix permission problem of setfacl

2014-04-27 Thread Oleg Drokin
/browse/LU-4704 Reviewed-by: Andreas Dilger Reviewed-by: Bob Glossman Reviewed-by: John L. Hammond Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/xattr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging

[PATCH 30/47] staging/lustre/mdc: fix issue found by Klocwork Insight tool

2014-04-27 Thread Oleg Drokin
eviewed-by: Fan Yong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_reint.c b/drivers/staging/lustre/lustre/mdc/mdc_reint.c index 19f20c1..08e8094 100644 ---

[PATCH 40/47] staging/lustre/mdc: use cl_max_mds_md to pack getattr RPC

2014-04-27 Thread Oleg Drokin
-by: Oleg Drokin --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c index 41a18f5..1a8cd98 100644 --- a/drivers/staging

[PATCH 45/47] staging/lustre: pass fsync() range through RPC/IO stack

2014-04-27 Thread Oleg Drokin
l.com/browse/LU-4388 Reviewed-by: Bobi Jam Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/dt_object.h | 9 + drivers/staging/lustre/lustre/llite/file.c| 5 ++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/st

[PATCH 27/47] staging/lustre: shrink lu_object_header by 8 bytes on x86_64

2014-04-27 Thread Oleg Drokin
Zhuravlev Reviewed-by: Liang Zhen Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lu_object.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/staging/lustre/lustre/include/lu_object.h

[PATCH 42/47] staging/lustre: remove assertion of spin_is_locked()

2014-04-27 Thread Oleg Drokin
: https://jira.hpdd.intel.com/browse/LU-4199 Reviewed-by: Alexey Lyashkov Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/libcfs/linux/linux-lock.h | 2 +- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +- drivers/staging/lustre

[PATCH 47/47] staging/lustre/llite: prevent buffer overflow in fiemap

2014-04-27 Thread Oleg Drokin
write issue when the fiemap call is only for detecting the number of existing extent. Signed-off-by: Bobi Jam Reviewed-on: http://review.whamcloud.com/9834 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4619 Reviewed-by: Fan Yong Reviewed-by: Patrick Farrell Signed-off-by: Oleg Drokin

[PATCH 43/47] staging/lustre/osc: Update inode timestamp for lockless IO as well

2014-04-27 Thread Oleg Drokin
://review.whamcloud.com/8797 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3868 Reviewed-by: John L. Hammond Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/osc_io.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff

[PATCH 22/47] staging/lustre/lov: to not hold sub locks at initialization

2014-04-27 Thread Oleg Drokin
From: Jinshan Xiong Otherwise, it will cause deadlock because it essentially holds some sub locks and then to request others in an arbitrary order. Signed-off-by: Jinshan Xiong Reviewed-on: http://review.whamcloud.com/9152 Reviewed-by: Lai Siyao Reviewed-by: Bobi Jam Signed-off-by: Oleg

[PATCH 29/47] staging/lustre/lnet: lnet: fix issues found by Klocwork Insight tool

2014-04-27 Thread Oleg Drokin
referenced at line 572. Local variable 'hash' is never used. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/9386 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: Isaac Huang Signed-off-by: Oleg Drokin --- drivers

Re: [PATCH 00/47] Lustre fixes and cleanups

2014-04-27 Thread Oleg Drokin
Hello! On Apr 27, 2014, at 1:33 PM, Greg Kroah-Hartman wrote: > I've applied these, except for the 3 gss patches. Thanks. gss stuff was kind of totally separate, tso I thought it was not so bad idea to include them, but they are definitely not required. > Also, there is now a build warning in

[PATCH] staging/lustre/llite: Fix a compile warning.

2014-04-27 Thread Oleg Drokin
ymname’ was declared here char *symname; ^ Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/symlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/symlink.c b/drivers/staging/lustre/lustre/llite/symlink.c

[PATCH 3/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: Isaac Huang Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/selftest/framework.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/fr

[PATCH 0/5] Lustre Klocwork fixes

2014-04-27 Thread Oleg Drokin
This is just splitting big lnet fixes patch from Klocwork static analysis tool into smaller bits. Dmitry Eremin (5): staging/lustre/lnet: fix potential null pointer dereference staging/lustre/lnet: remove unused variable staging/lustre/lnet: fix potential null pointer dereference staging/l

[PATCH 2/5] staging/lustre/lnet: remove unused variable

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin Local variable 'hash' is never used found by Klocwork Insight tool Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/9386 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: Isaac Huang Signed-of

[PATCH 5/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
review.whamcloud.com/9386 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: Isaac Huang Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/router.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/stag

[PATCH 4/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
L. Hammond Reviewed-by: Isaac Huang Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2

[PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
by: John L. Hammond Reviewed-by: Isaac Huang Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/sockl

Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
On Apr 27, 2014, at 6:05 PM, One Thousand Gnomes wrote: >> Reviewed-by: John L. Hammond >> Reviewed-by: Isaac Huang >> Signed-off-by: Oleg Drokin >> --- >> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++-- >> 1 file changed, 2 insertions(+)

Re: [PATCH 5/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
Hello! On Apr 27, 2014, at 6:39 PM, Greg Kroah-Hartman wrote: >> >> -lnet_ni_notify_locked(ni, lp); >> +if (ni != NULL) >> +lnet_ni_notify_locked(ni, lp); > > Why can't lnet_ni_notify_locked() accept NULL as an input? It makes no sense, because then there is nowhere to send

[PATCH] staging/lustre: Replace jobid acquiring with per node setting

2014-04-27 Thread Oleg Drokin
Insted of meddling directly in process environment variables (which is also not possible on certain platforms due to not exported symbols), create jobid_name proc file to represent this info (to be filled by job scheduler epilogue). Signed-off-by: Oleg Drokin CC: Andreas Dilger --- .../staging

  1   2   3   4   5   >