Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform

2014-11-04 Thread Russell King - ARM Linux
On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote: From: Andy yan andy@rock-chips.com We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly difference, such as phy pll

Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform

2014-11-06 Thread Russell King - ARM Linux
On Thu, Nov 06, 2014 at 05:35:40PM +0800, Kuankuan.Yang wrote: I'm working on Designware hdmi-audio, also add it as a standard ALSA device. Before I saw this email, I also planed to submit my patchs to upsteam. I'm very grateful if you can email those patchs to us. I've attached the set of

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-15 Thread Russell King - ARM Linux
On Sat, Nov 15, 2014 at 06:07:50PM +0800, Daniel Kurtz wrote: On Fri, Nov 14, 2014 at 7:13 PM, Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: On 14/11/14 11:08, Andy Yan wrote: On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote: On 14/11/14 10:53, Andy Yan wrote:

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-15 Thread Russell King - ARM Linux
On Sat, Nov 15, 2014 at 10:12:18AM +, Russell King - ARM Linux wrote: Once the wranglings on the patch series are complete, I do intend to test it on the platforms I have - and remember that I do have the ALSA based audio and CEC bits as well, some of which will probably need a little bit

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: +int imx_hdmi_bind(struct device *dev, struct device *master, + void *data, struct drm_encoder *encoder, + const struct imx_hdmi_plat_data *plat_data) { struct platform_device *pdev =

Re: [PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-12-03 Thread Russell King - ARM Linux
On Wed, Dec 03, 2014 at 11:32:12PM +0800, Andy Yan wrote: diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 884923f..26162ef 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -3,3 +3,8 @@ config DRM_PTN3460 depends on

Re: [PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:01:25AM +0800, Andy Yan wrote: Hi Russell: Do you mean I just neet to do like bellow? + +config DRM_DW_HDMI + bool + depends on DRM + select DRM_KMS_HELPER Yep. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:04:37AM +0800, Andy Yan wrote: Hi Russell: On 2014年12月03日 23:38, Russell King - ARM Linux wrote: On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: +int imx_hdmi_bind(struct device *dev, struct device *master, + void *data, struct drm_encoder

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Wed, Dec 03, 2014 at 05:20:15PM +0100, Philipp Zabel wrote: Hi Andy, It would be better if the bind function would not have to care about platform resources, that should be handled in the probe function. I had a patch to move them:

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:30:23AM +0800, Andy Yan wrote: On 2014年12月04日 00:11, Russell King - ARM Linux wrote: I meant that imx_hdmi_bind should be passed these, so that it needs to know nothing about the struct device beyond the generic device structure. In other words, the dw-hdmi core

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:56:24AM +0800, Andy Yan wrote: Hi Russell: On 2014年12月04日 00:33, Russell King - ARM Linux wrote: On Thu, Dec 04, 2014 at 12:30:23AM +0800, Andy Yan wrote: On 2014年12月04日 00:11, Russell King - ARM Linux wrote: I meant that imx_hdmi_bind should be passed these, so

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-04 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 09:40:10AM +0100, Philipp Zabel wrote: You are right, no I don't want this. When I initially wrote this patch I was under the impression that the memory allocated by devm_kzalloc in bind() wouldn't be freed on unbind(). Resources claimed inside bind() will be freed in

Re: [PATCHv3 1/8] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-11-13 Thread Russell King - ARM Linux
On Wed, Nov 13, 2013 at 08:53:18AM +0100, Eric Bénard wrote: Hi Russell, Le Tue, 12 Nov 2013 17:04:55 +, Russell King - ARM Linux li...@arm.linux.org.uk a écrit : On Tue, Nov 12, 2013 at 05:49:18PM +0100, Denis Carikli wrote: diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm

Re: [PATCHv4][ 3/7] staging: imx-drm: Add RGB666 support for parallel display.

2013-11-13 Thread Russell King - ARM Linux
On Wed, Nov 13, 2013 at 11:43:44AM -0700, Troy Kisky wrote: On 11/13/2013 2:23 AM, Denis Carikli wrote: + /* rgb666 */ +ipu_dc_map_clear(priv, IPU_DC_MAP_RGB666); +ipu_dc_map_config(priv, IPU_DC_MAP_RGB666, 2, 17, 0xfc); /* red */ +ipu_dc_map_config(priv, IPU_DC_MAP_RGB666, 1,

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-02 Thread Russell King - ARM Linux
On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API. I still say that not even this should be part of the DRM mode API to userspace. The hint that

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-03 Thread Russell King - ARM Linux
On Tue, Dec 03, 2013 at 07:44:52PM +0800, Shawn Guo wrote: On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API. Signed-off-by: Marek Vasut

[PATCH 0/4] Fix some bugs/races in imx-drm

2013-12-16 Thread Russell King - ARM Linux
The following patch series fixes some bugs and races in the imx-drm code, which should probably be applied to an -rc kernel. drivers/staging/imx-drm/imx-drm-core.c | 21 - drivers/staging/imx-drm/ipu-v3/ipu-common.c | 32 +-

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-16 Thread Russell King - ARM Linux
On Mon, Dec 16, 2013 at 11:33:01AM +, Russell King - ARM Linux wrote: The following patch series fixes some bugs and races in the imx-drm code, which should probably be applied to an -rc kernel. drivers/staging/imx-drm/imx-drm-core.c | 21 - drivers/staging/imx

Re: [PATCH 3/4] imx-drm: fix missing symbol exports

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 12:28:37PM +0800, Shawn Guo wrote: On Mon, Dec 16, 2013 at 11:34:05AM +, Russell King wrote: Trying to build a modular imx-drm results in a number of missing symbol exports, caused by the recent changes to this driver. Add the necessary exports, and the missing

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: Russell King (8): imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() imx-drm: imx-drm-core: fix DRM cleanup paths imx

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: Russell King

[PATCH RFC 00/46] Preview of imx-drm cleanup series

2014-01-02 Thread Russell King - ARM Linux
Here is my large patch series which cleans up imx-drm, and gets it ready to move out of drivers/staging. This is a preview only. One of these patches introduces a generic helper in drivers/base which can be used by any subsystem to assemble a sub-devices together and complete the probe of a

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: Subsystems such as ALSA, DRM and others require a single card-level device structure to represent a subsystem. However, firmware tends to describe the

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 12:58:16PM +0100, Rafael J. Wysocki wrote: On Friday, January 03, 2014 11:00:30 AM Russell King - ARM Linux wrote: On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: Subsystems

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 02:24:26PM +0100, Rafael J. Wysocki wrote: On Friday, January 03, 2014 12:18:13 PM Russell King - ARM Linux wrote: I'm not sure what I'm looking for. I've tried looking at the results of searching your linux-next branch for container but I don't see anything

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:05:46PM +0100, David Herrmann wrote: Hi On Thu, Jan 2, 2014 at 10:27 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: The encoder possible_crtcs mask identifies which CRTCs can be bound to a particular encoder. Each bit from bit 0 defines an index in the

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:26:14PM +0100, David Herrmann wrote: Hi On Fri, Jan 3, 2014 at 5:13 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: I'm not so sure - since the only place this mask gets used is with the possible_crtcs field. It's got nothing to do

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: Hi Russell, I've tested this series on a BD-SL (SabreLite) with HDMI. Right now the HPD signal doesn't seem to work, but after overwriting the connection check, I got a stable and correct picture on the monitor: Hmm. Does this

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 06:26:44PM +0100, Philipp Zabel wrote: Am Freitag, den 03.01.2014, 17:07 + schrieb Russell King - ARM Linux: On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: Hi Russell, I've tested this series on a BD-SL (SabreLite) with HDMI. Right now

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-06 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 06:41:28PM +0100, Philipp Zabel wrote: Hi Eric, Am Freitag, den 03.01.2014, 12:14 -0700 schrieb Eric Nelson: This is an issue we've seen before. The SABRE Lite board has a voltage divider on the HPD pins and some monitors (esp. DVI monitors) either don't drive

Re: [PATCH RFC 24/46] imx-drm: provide common connector mode validation function

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 02:38:05PM +0800, Shawn Guo wrote: On Thu, Jan 02, 2014 at 09:27:48PM +, Russell King wrote: diff --git a/drivers/staging/imx-drm/imx-drm.h b/drivers/staging/imx-drm/imx-drm.h index 5649f180dc44..4eb594ce9cff 100644 --- a/drivers/staging/imx-drm/imx-drm.h

Re: [PATCH RFC 30/46] imx-drm: remove separate imx-fbdev

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 02:49:50PM +0800, Shawn Guo wrote: On Thu, Jan 02, 2014 at 09:28:19PM +, Russell King wrote: @@ -449,6 +458,24 @@ static int imx_drm_driver_load(struct drm_device *drm, unsigned long flags) } } + /* +* All components are now

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 04:59:35PM +0800, Shawn Guo wrote: On Thu, Jan 02, 2014 at 09:28:03PM +, Russell King wrote: diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index e75e11b36dff..0e005f21d241 100644 ---

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 05:29:55PM +0100, Philipp Zabel wrote: Thanky you. This is what I came up with so far: From: Philipp Zabel p.za...@pengutronix.de Subject: [PATCH 1/2] staging: imx-hdmi: use RX_SENSE0 for plug detection if HPD is unreliable On some boards HPD might not reliably

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-09 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 11:25:38PM +0800, Shawn Guo wrote: Yea, adding all four into imx-drm crtcs works for imx6q, but it doesn't for imx6dl, because ipu2 is unavailable for imx6dl at all. Here is how I get around it. Thanks, I've rolled your change into this commit now. -- FTTC broadband

Re: [RFC PATCH v2] staging: imx-hdmi: use rx sense status for plug detection if hpd is unreliable

2014-01-10 Thread Russell King - ARM Linux
On Fri, Jan 10, 2014 at 03:22:24PM +0100, Philipp Zabel wrote: Due to the voltage divider on the HPD line, the HDMI connector on imx6q-sabrelite doesn't reliably detect connected DVI monitors. This patch allows to use the RX_SENSE0 signal as a workaround when enabled by a boolean device tree

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-10 Thread Russell King - ARM Linux
On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: Subsystems such as ALSA, DRM and others require a single card-level device structure to represent a subsystem. However, firmware tends to describe the

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-10 Thread Russell King - ARM Linux
On Fri, Jan 10, 2014 at 07:07:02AM -0800, Greg Kroah-Hartman wrote: On Fri, Jan 10, 2014 at 02:54:44PM +, Russell King - ARM Linux wrote: Greg, Not sure if you saw the outcome to your comment above. My conclusion was: Yes, I'm coming to that conclusion as well. It looks like

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-10 Thread Russell King - ARM Linux
On Fri, Jan 10, 2014 at 12:42:59PM -0800, Greg Kroah-Hartman wrote: On Fri, Jan 10, 2014 at 07:30:21PM +0100, Robert Schwebel wrote: On Fri, Jan 10, 2014 at 07:35:30AM -0800, Greg Kroah-Hartman wrote: I'll sort out a new set of patches today, along with a branch to pull if you wish to

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-11 Thread Russell King - ARM Linux
On Sat, Jan 11, 2014 at 12:31:19PM +0100, Robert Schwebel wrote: On Fri, Jan 10, 2014 at 11:23:37PM +, Russell King - ARM Linux wrote: We do this in DT by providing a superdevice node which specifies the components, eg: imx-drm { compatible = fsl,drm

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2014-02-05 Thread Russell King - ARM Linux
On Wed, Feb 05, 2014 at 12:02:49PM -0800, Greg Kroah-Hartman wrote: On Tue, Dec 17, 2013 at 05:13:48PM -0800, Greg Kroah-Hartman wrote: I'll apply these after the first round goes into Linus's tree to make the merging easier (i.e. after the next -rc). Now applied. Thanks. I'll see about

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 10:04:30AM +0100, Daniel Vetter wrote: I've chatted a bit with Hans Verkuil about this topic at fosdem and apparently both v4l and alsa have something like this already in their helper libraries. Adding more people as fyi in case they want to switch to the new driver

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 12:57:21PM +0100, Jean-Francois Moine wrote: I started to use your code (which works fine, thanks), and it avoids a lot of problems, especially, about probe_defer in a DT context. I was wondering if your componentised mechanism could be extended to the devices defined

Re: [PATCH RFC 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote: Some simple components don't need to do any specific action on bind to / unbind from a master component. This patch permits such components to omit the bind/unbind operations. Signed-off-by: Jean-Francois Moine

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a DT, and are not using the component bin/unbind functions. I wonder - I said earlier today

Re: [PATCH RFC 2/2] drivers/base: declare phandle DT nodes as components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 05:53:27PM +0100, Jean-Francois Moine wrote: At system startup time, some devices depends on the availability of some other devices before starting. The infrastructure for componentised subsystems permits to handle this dependence, each driver defining its own role.

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 07:42:04PM +0100, Jean-Francois Moine wrote: On Fri, 7 Feb 2014 17:33:26 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a DT, and are not using the component bin/unbind functions. Here's my changes to the TDA998x

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:59:11PM +, Russell King - ARM Linux wrote: Sorry. Deferred probe does work, it's been tested with imx-drm, not only from the master component but also the sub-components. There's no problem here. Here's the proof that it also works with the Cubox, and armada

Re: [PATCH] imx-drm: imx-drm-core: Remove unused 'imxdrm' variable

2014-02-08 Thread Russell King - ARM Linux
On Sat, Feb 08, 2014 at 06:49:49PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Since commit 020a9ea7c2 (imx-drm: imx-drm-core: avoid going the long route round for drm_device) the 'imxdrm' variable is not used anymore, which causes the following build

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-09 Thread Russell King - ARM Linux
On Sun, Feb 09, 2014 at 10:22:19AM +0100, Jean-Francois Moine wrote: On Fri, 7 Feb 2014 20:23:51 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: Here's my changes to the TDA998x driver to add support for the component helper. The TDA998x driver retains support for the old way

Re: [PATCH] staging: drm/imx: remove an unnecessary local variable

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote: This patch removes an unnecessary local variable defined in the function imx_drm_driver_unload() so as to fix the following build warning. drivers/staging/imx-drm/imx-drm-core.c: \ In function ‘imx_drm_driver_unload’:

Re: [PATCH] staging: drm/imx: remove an unnecessary local variable

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 06:42:57PM +0800, Liu Ying wrote: On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote: On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote: This patch removes an unnecessary local variable defined in the function imx_drm_driver_unload() so as to fix

Re: [PATCH v3 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 01:53:08PM +0100, Thierry Reding wrote: On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote: Some simple components don't need to do any specific action on bind to / unbind from a master component. This patch permits such components to omit the

Re: [PATCH v3 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 03:35:51PM +0100, Jean-Francois Moine wrote: On Mon, 10 Feb 2014 13:12:33 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: I've NAK'd these patches already - I believe they're based on a mis-understanding of how this should be used. I believe Jean

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 04:12:19PM +0100, Philipp Zabel wrote: Am Montag, den 10.02.2014, 12:28 + schrieb Russell King - ARM Linux: This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated

Re: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-02-10 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 03:52:01PM +0100, Philipp Zabel wrote: @@ -438,24 +453,21 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, struct drm_encoder *encoder, struct device_node *np) { struct imx_drm_device *imxdrm = drm-dev_private; + struct device_node *ep, *last_ep

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 06:37:26PM +0100, Philipp Zabel wrote: I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 12:28:03PM +, Russell King - ARM Linux wrote: This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2. Since the last round of patches were posted

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Russell King - ARM Linux
On Wed, Feb 12, 2014 at 01:04:30PM +0100, Christian Gmeiner wrote: 2014-02-12 12:53 GMT+01:00 Fabio Estevam feste...@gmail.com: On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: This is the latest revision of my series cleaning up imx-drm

[PATCH] hostap: fix hostap: proc: Use remove_proc_subtree()

2014-02-12 Thread Russell King - ARM Linux
remove_proc_subtree() doesn't work here as local-ddev has already been removed, and NULLed out. Use proc_remove() instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Tested-by: Russell King rmk+ker...@arm.linux.org.uk --- I would include an oops, however the machine I discovered

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-18 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 12:45:09PM +0100, Philipp Zabel wrote: Thanks for your comments there. I have just updated and resent this series ([RFC PATCH v3 0/9] imx-drm dt bindings), still with a temporary local copy of the v4l2_of functions, as long as the final resting place of the

Re: [RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of

2014-02-24 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 12:36:02PM +0100, Philipp Zabel wrote: From: Lucas Stach l.st...@pengutronix.de Since imx_drm_encoder_parse_of is called from the encoder bind callbacks, it is too late to request probe deferral. Rather the core should make sure that the crtcs are bound before the

Re: [RFC PATCH v3 2/9] staging: imx-drm: Add temporary copies of v4l2-of parsing functions

2014-02-24 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 12:36:03PM +0100, Philipp Zabel wrote: From: Philipp Zabel philipp.za...@gmail.com The existing v4l2-of parser functions for the video interface bindings described in Documentation/device-tree/bindings/media/video-interfaces.txt are useful for DRM drivers, too. They

Re: [RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of

2014-02-24 Thread Russell King - ARM Linux
On Mon, Feb 24, 2014 at 05:56:38PM +0100, Philipp Zabel wrote: Am Montag, den 24.02.2014, 15:49 + schrieb Russell King - ARM Linux: One issue was that the DT parsing code would try to add the imx-ldb component right after the first crtc, and then its bind would fail

Re: [GIT PULL] imx-drm conversion to component support

2014-02-24 Thread Russell King - ARM Linux
On Mon, Feb 24, 2014 at 12:41:41PM -0800, Greg KH wrote: On Mon, Feb 24, 2014 at 02:20:20PM +, Russell King wrote: Greg, Please incorporate the latest imx-drm updates into staging, which can be found at: git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging with

Re: [RFC PATCH 0/5] Move IPUv3 core out of staging, add CSI support

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 11:39:03AM +0300, Dan Carpenter wrote: Please fix the following static checker complaints before moving out of staging: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Note that

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 10:00:25PM +0100, Guennadi Liakhovetski wrote: Hi Russell (I suspect this my email will be rejected by ALKML too like other my recent emails, but at least other MLs will pick it up and individual CCs too, so, if replying, maybe it would be good to keep my entire

Re: [PATCH 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 06:44:36PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is

Re: [PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 07:44:33PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote: For the i.MX6 display subsystem there is no clear single master device, and the physical configuration changes across the SoC family. The i.MX6Q/i.MX6D SoCs have two separate display controller devices IPU1 and IPU2, with two

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 03:16:03PM +0200, Tomi Valkeinen wrote: On 27/02/14 13:56, Russell King - ARM Linux wrote: Is there even need for such a master device? You can find all the connected display devices from any single display device, by just following the endpoint links. Please

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index abf8517..daa54df 100644 --- a/drivers/staging/imx-drm/imx-ldb.c +++

Re: [PATCH 2/3] imx-drm: ipu-dc: Use usleep_range instead of msleep

2014-02-28 Thread Russell King - ARM Linux
On Tue, Feb 25, 2014 at 12:43:42PM +0100, Philipp Zabel wrote: Since msleep(2) can sleep up to 20ms anyway, make this explicit by using usleep_range(2000, 2). Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 2 +- 1 file changed, 1

Re: [PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-03-05 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 10:20:52AM +0100, Philipp Zabel wrote: +struct imx_drm_component { + struct device_node *of_node; + struct list_head list; +}; + The only thing this structure appears to be doing is ensuring that a single component doesn't get added twice - is that correct?

Re: [patch] iio: mxs-lradc: use helper functions to simplify the code

2013-09-06 Thread Russell King - ARM Linux
On Thu, Sep 05, 2013 at 05:15:02PM -0300, Fabio Estevam wrote: Looks good, just one minor suggestion: On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter dan.carpen...@oracle.com wrote: +static void lradc_reg_set(struct mxs_lradc *lradc, u32 val, size_t chan) +{ + writel(val,

[PATCH 00/51] DMA mask changes

2013-09-19 Thread Russell King - ARM Linux
This started out as a request to look at the DMA mask situation, and how to solve the issues which we have on ARM - notably how the DMA mask should be setup. However, I started off reviewing how the dma_mask and coherent_dma_mask was being used, and what I found was rather messy, and in some

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-20 Thread Russell King - ARM Linux
On Fri, Sep 20, 2013 at 07:16:52AM -0500, Tejun Heo wrote: On Fri, Sep 20, 2013 at 12:11:38AM +0100, Russell King wrote: The correct way for a driver to specify the coherent DMA mask is not to directly access the field in the struct device, but to use dma_set_coherent_mask(). Only arch and

Re: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

2013-09-21 Thread Russell King - ARM Linux
On Fri, Sep 20, 2013 at 07:26:27PM +0200, Heiko Stübner wrote: Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: The DMA API requires drivers to call the appropriate dma_set_mask() functions before doing any DMA mapping. Add this required call to the AMBA PL08x driver.

Re: [PATCH 00/51] DMA mask changes

2013-09-27 Thread Russell King - ARM Linux
On Thu, Sep 26, 2013 at 10:23:08PM +0200, Rafał Miłecki wrote: 2013/9/19 Russell King - ARM Linux li...@arm.linux.org.uk: This email is only being sent to the mailing lists in question, not to anyone personally. The list of individuals is far to great to do that. I'm hoping no mailing

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-14 Thread Russell King - ARM Linux
On Thu, Oct 03, 2013 at 03:51:26PM -0300, Fabio Estevam wrote: diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 9e8ae11..65e54b4 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi +++ b/arch/arm/boot/dts/imx6dl.dtsi @@ -88,3 +88,7 @@ crtcs = ipu1 0, ipu1

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-14 Thread Russell King - ARM Linux
On Mon, Oct 14, 2013 at 06:40:30PM +0100, Russell King - ARM Linux wrote: Another thing that my build testing (and use on cubox-i) picked up: On Thu, Oct 03, 2013 at 03:51:26PM -0300, Fabio Estevam wrote: diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Russell King - ARM Linux
On Mon, Oct 14, 2013 at 11:47:17PM -0300, Fabio Estevam wrote: On Mon, Oct 14, 2013 at 2:38 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Shouldn't the above be in patch 1 (or 1.5) rather than patch 2? Patch 2 advertises itself as adding support for the wandboard

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-15 Thread Russell King - ARM Linux
Another point on patch 1. Sorry, I don't have patch 1 to reply to, it seems it was deleted from linux-arm-kernel's moderation queue. drm_mode_connector_attach_encoder() is called too early, before the base.id field in the encoder has been initialised. This causes the connectors encoder array to

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-16 Thread Russell King - ARM Linux
On Tue, Oct 15, 2013 at 10:17:07AM -0300, Fabio Estevam wrote: On Tue, Oct 15, 2013 at 10:10 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Another point on patch 1. Sorry, I don't have patch 1 to reply to, it seems it was deleted from linux-arm-kernel's moderation queue

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-16 Thread Russell King - ARM Linux
On Wed, Oct 16, 2013 at 12:37:42PM -0700, Troy Kisky wrote: On 10/16/2013 10:03 AM, Russell King - ARM Linux wrote: On Tue, Oct 15, 2013 at 10:17:07AM -0300, Fabio Estevam wrote: On Tue, Oct 15, 2013 at 10:10 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Another point on patch 1

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-16 Thread Russell King - ARM Linux
On Wed, Oct 16, 2013 at 02:03:17PM -0700, Troy Kisky wrote: Freescale's kernel(imx_3.0.35_4.1.0) has this code video/mxc_hdmi.c-/* Workaround to clear the overflow condition */ video/mxc_hdmi.c-static void mxc_hdmi_clear_overflow(void) video/mxc_hdmi.c-{ video/mxc_hdmi.c- int count;

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-17 Thread Russell King - ARM Linux
Okay, next problem... As I described via the Cubox-i community last night on google+... I'm now at the point where certain resolutions and refreshes work fine (eg, 720p @ 50 or 60Hz, 1366x768, 1024x768). Others either don't display (1080p, 800x600, 848x480, 640x480), or have speckles, a line of

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-19 Thread Russell King - ARM Linux
On Wed, Oct 16, 2013 at 11:31:07AM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 16, 2013 at 07:07:35PM +0100, Russell King - ARM Linux wrote: Sorry, but I don't think imx-drm is driving the hardware correctly, and I know that Greg wants it moved out of drivers/staging, but frankly it seems

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
Another problem. After performing several modesets, the IPU seems to lock up and produce no syncs or output data. I've seen this many times over the last week while testing out various aspects of imx-drm, and had put it down to problems with the clocking arrangement getting its settings wrong.

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
On Sun, Oct 20, 2013 at 02:00:57PM +0100, Russell King - ARM Linux wrote: As for imx-drm, there was a warning which preceded that oops. Here's the full log, below the - marker - this is from unbinding the imx-drm module, and then trying to reboot. imx-drm is really very broken

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
On Sun, Oct 20, 2013 at 05:31:56PM +0100, Russell King - ARM Linux wrote: On Sun, Oct 20, 2013 at 02:00:57PM +0100, Russell King - ARM Linux wrote: As for imx-drm, there was a warning which preceded that oops. Here's the full log, below the - marker - this is from unbinding the imx

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-28 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com This is based on the initial work done by Sascha Hauer and Tony Prisk. It looks like you've also taken some of the suggestions I've made too - like the voltage drive and symbol

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 01:45:50PM -0200, Fabio Estevam wrote: On Tue, Oct 29, 2013 at 1:00 PM, Fabio Estevam feste...@gmail.com wrote: Today I was able to get access to a wandboard solo and the HDMI image does look different compared to a wandboard quad board: - The Linux logo penguins

Re: [PATCH] imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 07:42:22PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com sig_cfg.clk_pol controls the 'di0_polarity_disp_clk' bit of register IPUx_DI0_GENERAL through the following code in imx-drm/ipu-v3/ipu-di.c: if (!sig-clk_pol)

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 08:01:46PM -0200, Fabio Estevam wrote: Hi Greg, On Mon, Oct 28, 2013 at 7:03 PM, Greg KH gre...@linuxfoundation.org wrote: And why is new support being added to this driver instead of working to get it out of staging? Philipp Zabel mentioned that he will submit

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-30 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: + /*Wait for PHY PLL lock */ + msec = 4; + val = hdmi_readb(hdmi, HDMI_PHY_STAT0) HDMI_PHY_TX_PHY_LOCK; + while (!val) { + udelay(1000); + if (msec-- == 0) { +

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-10-31 Thread Russell King - ARM Linux
On Thu, Oct 31, 2013 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote: Hi Russell, Em Mon, 30 Sep 2013 13:57:47 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 09/19/2013 11:44 PM, Russell King wrote: Replace the following sequence: dma_set_mask(dev, mask);

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Russell King - ARM Linux
On Thu, Oct 31, 2013 at 06:45:41PM -0200, Fabio Estevam wrote: Hi Troy, On Thu, Oct 31, 2013 at 6:38 PM, Troy Kisky troy.ki...@boundarydevices.com wrote: I get a magenta line down the left side of the screen unless I replace the 5 with a 6. ie. +for (count = 0; count 6;

Re: [PATCHv3 1/8] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-11-12 Thread Russell King - ARM Linux
On Tue, Nov 12, 2013 at 05:49:18PM +0100, Denis Carikli wrote: diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index fc2adb6..586c12f 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -537,6 +537,15 @@ int

  1   2   3   4   >