y wrote:
>> There were some parentheses at the end of lines, which I took care of.
>> This is my first patch.
> ^^
> Put this sort of comments after the --- cut off line
>
>>
>> Signed-off-by: Sandro Volery
>> ---
> ^^^
>
Fixed open parenthesis at the end of the line on line 327.
Signed-off-by: Sandro Volery
---
drivers/staging/wlan-ng/cfg80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
b/drivers/staging/wlan-ng/cfg80211.c
index eee1998c4b18
Using temporaries for gasket_page_table entries to remove scnprintf()
statements and reduce line length, as suggested by Joe Perches. Thanks!
Signed-off-by: Sandro Volery
---
drivers/staging/gasket/apex_driver.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff
> On 10 Sep 2019, at 00:30, Joe Perches wrote:
>
> On Mon, 2019-09-09 at 22:28 +0200, Sandro Volery wrote:
>> Using temporaries for gasket_page_table entries to remove scnprintf()
>> statements and reduce line length, as suggested by Joe Perches. Thanks!
>
> nak.
Using temporaries for gasket_page_table entries to remove scnprintf()
statements and reduce line length, as suggested by Joe Perches. Thanks!
Signed-off-by: Sandro Volery
---
drivers/staging/gasket/apex_driver.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff
Using temporaries for gasket_page_table entries to remove scnprintf()
statements and reduce line length, as suggested by Joe Perches. Thanks!
Signed-off-by: Sandro Volery
---
v3: Fixed faulty copy/paste of function
v2: Attempt to fix
v1: Original patch
drivers/staging/gasket/apex_driver.c
Replaced strcpy with strscpy in exfat_core.c.
Signed-off-by: Sandro Volery
---
drivers/staging/exfat/exfat_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/staging/exfat/exfat_core.c
index da8c58149c35..c71b145e8a24 100644
strcpy was used multiple times in strcpy to write into dev->name.
I replaced them with strscpy.
Signed-off-by: Sandro Volery
---
drivers/staging/octeon/ethernet.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c
b/driv
> On 11 Sep 2019, at 10:52, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 08:23:59AM +0200, Sandro Volery wrote:
>> strcpy was used multiple times in strcpy to write into dev->name.
>> I replaced them with strscpy.
>>
>> Signed-off-by: Sandro Vole
On 11 Sep 2019, at 11:17, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 11:04:38AM +0200, Sandro Volery wrote:
>>
>>
>>>> On 11 Sep 2019, at 10:52, Dan Carpenter wrote:
>>>
>>> On Wed, Sep 11, 2019 at 08:23:59AM +0200, Sandro Volery wrot
Use strscpy instead of strcpy in exfat_core.c, and add a check
for length that will return already known FFS_INVALIDPATH.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
v2: Implement length check and return in one
v1: Original Patch
drivers/staging/exfat/exfat_core.c | 3
> On 11 Sep 2019, at 12:06, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 11:42:19AM +0200, Sandro Volery wrote:
>> Use strscpy instead of strcpy in exfat_core.c, and add a check
>> for length that will return already known FFS_INVALIDPATH.
>>
>> Suggeste
Use strscpy instead of strcpy in exfat_core.c, and add a check
for length that will return already known FFS_INVALIDPATH.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
v3: Fixed replacing mistake
v2: Introduced length check
v1: Original patch
drivers/staging/exfat
Replacing strcpy with strscpy and moving the length check to the
same function.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
Took a couple attempts to finaly get this right :P
v4: Replaced strlen check
v3: Failed to replace check
v2: Forgot to replace strlen check
v1
> On 11 Sep 2019, at 21:06, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 09:53:03PM +0200, Sandro Volery wrote:
>> diff --git a/drivers/staging/exfat/exfat_core.c
>> b/drivers/staging/exfat/exfat_core.c
>> index da8c58149c35..4336fee444ce 100644
>
Use strscpy instead of strcpy in exfat_core.c, and add a check
for length that will return already known FFS_INVALIDPATH.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
v5: Fixed some whitespaces
v4: Replaced strlen check
v3: Failed to replace check
v2: Forgot to replace strlen
> On 12 Sep 2019, at 10:34, Dan Carpenter wrote:
>
> You did it. Well done. :P
>
> Reviewed-by: Dan Carpenter
Thanks :D Had some issues with my git configuration
setting up a home workstation but now it is all fine
___
devel mailing list
de...@li
Well if documentation is missing then it's their fault..
Go ahead and delete it, even tho it kills me since my first
patch was in there :)
Sandro V
> On 10 Dec 2019, at 13:01, Greg Kroah-Hartman
> wrote:
>
> On Tue, Dec 10, 2019 at 12:40:54PM +0100, Sandro Volery wrote:
Wow... I checked, compiled and still sent the wrong thing again. I'm gonna have
to give this up soon if i can't get it right.
Sandro V
> On 10 Sep 2019, at 07:06, Sandro Volery wrote:
>
> Using temporaries for gasket_page_table entries to remove scnprintf()
> stat
19 matches
Mail list logo