Re: dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-02-20 Thread Sumit Semwal
Hi Dan, On 21 February 2015 at 00:56, Dan Carpenter dan.carpen...@oracle.com wrote: Hello Sumit Semwal, The patch 817bd7253291: dma-buf: cleanup dma_buf_export() to make it easily extensible from Jan 23, 2015, leads to the following static checker warning: drivers/staging/android

[PATCH] staging: android: ion: fix wrong init of dma_buf_export_info

2015-02-24 Thread Sumit Semwal
; 1114 exp_info.priv = buffer; ^^ And here also. 1115 This patch corrects this stupidity. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Sumit Semwal sumit.sem...@linaro.org --- drivers/staging/android/ion/ion.c | 10

Re: [PATCHv2 1/1] staging/ion: Add support to get ion handle from dma buf

2016-01-07 Thread Sumit Semwal
e, but perhaps you should add related ION tests for this as well? Once you add that and share for review, feel free to add Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org> > drivers/staging/android/ion/ion.c | 21 +++-- > drivers/staging/android/ion/ion.h | 20

Re: [PATCH 00/18] staging/android: clean up SW_SYNC

2016-06-09 Thread Sumit Semwal
gt; >> I am just starting to catch up on patches, please give me some time, >> staging patches are at the bottom of my priority list, sorry. > > fwiw on the patch series: > > Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Likewise, fwiw for this series, Reviewed-by: S

Re: [PATCH] dma-buf: Update docs for SYNC ioctl

2016-03-21 Thread Sumit Semwal
o.vigna...@intel.com> > Cc: Stéphane Marchesin <marc...@chromium.org> > Cc: David Herrmann <dh.herrm...@gmail.com> > Cc: Sumit Semwal <sumit.sem...@linaro.org> > Cc: Daniel Vetter <daniel.vet...@intel.com> > CC: linux-me...@vger.kernel.org > Cc:

Re: [PATCH] dma-buf, drm, ion: Propagate error code from dma_buf_start_cpu_access()

2016-03-21 Thread Sumit Semwal
ase: igt/prime_mmap_coherency/ioctl-errors >> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> >> Cc: Tiago Vignatti <tiago.vigna...@intel.com> >> Cc: Stéphane Marchesin <marc...@chromium.org> >> Cc: David Herrmann <dh.herrm...@gmail.com> >

Re: [PATCH] dma-buf/sync_file: de-stage sync_file

2016-03-21 Thread Sumit Semwal
Thanks for the patch, Gustavo! On 18 March 2016 at 19:49, Gustavo Padovan wrote: > From: Gustavo Padovan > > sync_file is useful to connect one or more fences to the file. The file is > used by userspace to track fences. > I think it is

Re: [PATCH] MAINTAINERS: add entry for the Sync File Framework

2016-05-11 Thread Sumit Semwal
s Sumit's > tree as base. > > Cc: Sumit Semwal <sumit.sem...@linaro.org> > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> With the de-staging patches going through staging, perhaps we should add an Acked-by: Sumit Semwal <sumit.sem...@l

Re: [Linaro-mm-sig] [RESEND][PATCH 0/5] Ion cleanup

2016-08-15 Thread Sumit Semwal
<labb...@redhat.com>: >> I never saw any feedback or action on these patches so this is a resend. >> Probably hit the window when everyone was busy/traveling. >> Looks good to me; please feel free to apply my Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org>

Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS

2016-09-14 Thread Sumit Semwal
ply my Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org> Best, Sumit. > Building sparc64:allmodconfig ... failed > -- > Error log: > ... > drivers/built-in.o: In function `ion_parse_dt': > (.text+0x11aa2c): undefined reference to `of_platform_device_create' > >

Re: [PATCH -next] staging: android: ion: Fix return value check in hi6220_ion_probe()

2016-09-15 Thread Sumit Semwal
ver returns NULL. The NULL test in the return value check should be >> replaced with IS_ERR(). >> > > Acked-by: Laura Abbott <labb...@redhat.com> > Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org> > >> Signed-off-by: Wei Yongjun <weiyongj...@huawei.com&

Re: [PATCH] staging: android ion/hisi: fix dependencies

2016-09-15 Thread Sumit Semwal
on.c:(.text.hi6220_ion_probe+0x5c): undefined reference to >> `ion_parse_dt' >> hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to >> `ion_destroy_platform_data' >> >> This selects the symbol when needed. >> > > Acked-by: Laura Abbott <labb...@redh

[PATCH for-4.4 04/19] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic

2017-03-25 Thread Sumit Semwal
alexander.le...@verizon.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Sumit Semwal <sumit.sem...@linaro.org> --- arch/x86/kernel/cpu/mshyperv.c | 24 1 file changed, 24 insertions(+) diff --git a/arch/x86/kernel/cpu/msh

Re: [PATCHv4 00/12] Ion cleanup in preparation for moving out of staging

2017-04-21 Thread Sumit Semwal
with the CMA APIs so this is a new version to address that. I also > addressed some minor comments on the patch to collapse header files. For the series, please feel free to apply my Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > > Thanks, > Laura > > Laura Abbott (12): >

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

2017-04-20 Thread Sumit Semwal
om> >> Reviewed-by: Sinclair Yeh <s...@vmware.com> > > Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > > Probably simplest if we pull this in through the drm-misc tree for 4.12. > Can we have an ack fo

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

2017-04-20 Thread Sumit Semwal
>>> diff --git a/drivers/staging/android/ion/ion.c >>> b/drivers/staging/android/ion/ion.c >>> index f45115f..95a7f16 100644 >>> --- a/drivers/staging/android/ion/ion.c >>> +++ b/drivers/staging/android/ion/ion.c >>> @@ -1020,10 +1020,10 @@ static const struct dma_bu

Re: [RFC PATCH 08/12] cma: Store a name in the cma structure

2017-03-10 Thread Sumit Semwal
Hi Laura, Thanks for the patch. On 3 March 2017 at 03:14, Laura Abbott wrote: > > Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it > useful to have an explicit name attached to each region. Store the name > in each CMA structure. > > Signed-off-by:

Re: [PATCH 0/3] staging: android: ion: Minor clean ups and fixes

2017-05-17 Thread Sumit Semwal
neja (3): > staging: android: ion: Remove unused members from ion_buffer > staging: android: ion: Remove ION_FLAG_CACHED_NEEDS_SYNC > staging: android: ion: Avoid calling free_duped_table() twice > Thanks for these patches! Please feel free to add my Reviewed-by: Sumit Semwal <

Re: [PATCH 2/2] staging: android: ion: Combine cache and uncache pools

2018-02-07 Thread Sumit Semwal
bined. > Thanks for the patch! Perhaps you should also put the version history here, to capture the changes from previous versions? > Signed-off-by: Yisheng Xie <xieyishe...@huawei.com> With that done, please feel free to add Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > ---

Re: [PATCH 1/2] staging: android: ion: Cleanup ion_page_pool_alloc_pages

2018-02-07 Thread Sumit Semwal
can just return > alloc_pages without any judgement. > With patch history comment addressed (same as the other patch you sent), > Signed-off-by: Yisheng Xie <xieyishe...@huawei.com> Please feel free to add my Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > --- > drive

Re: [PATCH] staging: android: ion: remove duplicate buffer field initializes

2018-04-23 Thread Sumit Semwal
er. Remove one set. > > Move the initialization of these two fields together with the > statements that initialize the other two fields from the function > parameters, prior to the heap allocate() call, for consistency. > > Signed-off-by: Todd Poynor <toddpoy...@google.com

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-22 Thread Sumit Semwal
Hello everyone, Sincere apologies for chiming in a bit late here, but was off due to some health issues. Also, adding Daniel Vetter to the mix, since he has been one of the core guys who shaped up dma-buf as it is today. On Tue, 22 Jan 2019 at 02:51, Andrew F. Davis wrote: On 1/21/19 5:22