On Wed, 03 Dec 2014 17:07:28 +, Sean Cleator said:
A patch to fix the rest of the long line warnings in the dgnc_cls.h file
found by the checkpatch.pl tool
struct cls_uart_struct {
u8 txrx;/* WR RHR/THR - Holding Reg */
u8 ier; /* WR IER - Interrupt
On Tue, 15 Jul 2014 20:01:44 +0300, Sam Asadi said:
From: Linus Torvalds torva...@linux-foundation.org
Signed-off-by: sam-the-6 asadi.sam...@gmail.com
---
Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 2167084..f3c543d 100644
-By: Valdis Kletnieks valdis.kletni...@vt.edu
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 2014-09-05
15:51:00.005660044 -0400
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 2014-09-08
17:42:16.773748142 -0400
@@ -847,6 +847,8 @@ static u8 parse_subframe(struct sk_buff
#else
On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said:
Fix a possible null pointer dereference, there is
otherwise a risk of a possible null pointer dereference.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
- if (ir == NULL) {
- dev_err(ir-l.dev, close: no private_data attached to the file
!\n);
Yes, the dev_err() call is an obvious thinko.
However, I'm not sure whether removing it entirely is right either. If
there
On Mon, 06 Jul 2015 18:50:12 +0530, Ravi Teja Darbha said:
Why would you use a macro to avoid code duplication?
The macro does end up putting code in each place it's used.
However, the actual code is in one place rather than open-coded
in multiple places that can diverge over time (somebody
On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said:
When the checkpatch.pl script was run, it showed lines with length
more than 80 characters in rtw_ap.c file. Fixed line number 382 by
breaking it up into two lines within 80 characters.
- stainfo_offset =
On Tue, 07 Jul 2015 21:08:10 -0400, Sreenath Madasu said:
The kernelnewbies.org guide said For your first patch, only pick one
warning. That is the reason why I fixed one warning.
They mean don't fix lines over 80 characters *and* missing-blank
warnings in the same patch.
pgpoBhFQVf2aM.pgp
On Tue, 07 Jul 2015 13:38:47 -0700, Joe Perches said:
The longest line in this file is 158 chars, that's
probably excessive, awk shows 35 lines 80 chars.
That doesn't count tabs. Checkpatch throws 98 warnings.
pgpyA7aIF0_ni.pgp
Description: PGP signature
;
^
Just ignore the dentry returned, and add a comment that we *know*
we're not really leaking the dentry because something else will be able
to reap it via recursion.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/libcfs/module.
test code - it should be *more* bulletproof than production, not less.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c
b/drivers/s
libcfs_private.h:58:6:
note: in expansion of macro 'unlikely'
if (unlikely(!(cond))) { \
^
drivers/staging/lustre/lustre/llite/rw.c:763:2: note: in expansion of macro
'LASSERTF'
LASSERTF(reserved >= 0, "reserved %lu\n", reserved);
^
Umm, thank you, GCC. We'll delete the problem
lu_device_operations *
^
So we just swap inline and const. 272 warnings gone. :)
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lu_objec
. Bye-bye.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 --
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_cfg.h
b/drivers/staging/lustre/lustre/include/lustre_cfg.h
Start of a batch series to clean up the Lustre tree. Other people have
done some sparse and checkpatch cleanups, but I found a bunch of
stuff building with W=1. There's probably more, but this was the
really low-hanging obvious fruit.
Valdis Kletnieks (6):
staging/lustre: Silence warning about
d save a page of compiler spew.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
b/drivers/staging/lustre/lustre/ptlrpc/sec_
lu_device_operations *
^
So we just swap inline and const. 272 warnings gone. :)
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lu_objec
;
^
Just ignore the dentry returned, and add a comment that we *know*
we're not really leaking the dentry because something else will be able
to reap it via recursion.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/libcfs/module.
. Bye-bye.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 --
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_cfg.h
b/drivers/staging/lustre/lustre/include/lustre_cfg.h
Start of a batch series to clean up the Lustre tree. Other people have
done some sparse and checkpatch cleanups, but I found a bunch of
stuff building with W=1. There's probably more, but this was the
really low-hanging obvious fruit.
Valdis Kletnieks (6):
drivers/staging/lustre: Silence
d save a page of compiler spew.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
b/drivers/staging/lustre/lustre/ptlrpc/sec_
test code - it should be *more* bulletproof than production, not less.
Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c
b/drivers/s
libcfs_private.h:58:6:
note: in expansion of macro 'unlikely'
if (unlikely(!(cond))) { \
^
drivers/staging/lustre/lustre/llite/rw.c:763:2: note: in expansion of macro
'LASSERTF'
LASSERTF(reserved >= 0, "reserved %lu\n", reserved);
^
Umm, thank you, GCC. We'll delete the problem
On Sat, 19 Mar 2016 19:22:09 -0700, Joe Perches said:
> On Sun, 2016-03-20 at 07:48 +0530, Parth Sane wrote:
> > Hi,
> > Thanks for pointing out that the changes have been done. Nevertheless
> > this was a good learning exercise. How do I check which changes have
> > already been done?
>
> Use
On Sat, 16 Jun 2018 15:00:31 +0900, Hyunil Kim said:
> *fix checkpatch.pl warnings:
> WARNING: line over 80 characters
> + if (((ieee->wpa_ie[0] == 0xdd) &&
> + (!memcmp(&(ieee->wpa_ie[14]), ccmp_ie, 4))) ||
> + ((ieee->wpa_ie[0] == 0x30) &&
> +
On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said:
> Clang warns that the address of a pointer will always evaluated as true
> in a boolean context:
>
> drivers/staging/wilc1000/linux_wlan.c:267:20: warning: address of
> 'vif->ndev->dev' will always evaluate to 'true'
>
John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call
ieee80211_networks_free(). In addition, that function has an un-needed check
before kfree().
Reported-by: John Whitmore
Signed-off-by: Valdis Kletnieks
---
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_modul
On Fri, 25 Jan 2019 22:14:32 -0200, Rodrigo Ribeiro said:
> Maybe, one checkstyle patch is enough, right? Which drivers can I truly
> contribute to?
I'll give you a pointer to the "How to contribute" the Kernel Newbies list and
IRC
channel uses:
Use -ENOTEMPTY rather than -EEXIST for attempting to remove
a directory that still has files in it.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging
Convert FFS_ERROR to -EINVAL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_core.c | 10 +-
drivers/staging/exfat/exfat_super.c | 20 ++--
3 files changed, 15 insertions(+), 16 deletions(-)
diff --git
There's currently 6 filesystems that have the same #define. Move it
into errno.h so it's defined in just one place.
Signed-off-by: Valdis Kletnieks
Acked-by: Darrick J. Wong
Reviewed-by: Jan Kara
Acked-by: Theodore Ts'o
---
drivers/staging/exfat/exfat.h| 2 --
fs/erofs/internal.h
Convert FFS_SUCCESS to 0.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 -
drivers/staging/exfat/exfat_cache.c | 4 +-
drivers/staging/exfat/exfat_core.c | 104 ++--
drivers/staging/exfat/exfat_super.c | 50 ++---
4 files
Covert FFS_INVALIDFID to -EINVAL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 10 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
Convert FFS_EOF to return 0 for a zero-length read() as per 'man 2 read'.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b
Convert FFS_MEDIAERR to (mostly) -ENOENT and -EIO. Some additional code surgery
needed to propogate correct error codes upwards.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h| 1 -
drivers/staging/exfat/exfat_blkdev.c | 18 ++---
drivers/staging/exfat
Now that we no longer use odd internal return codes, we can
heave the translation code over the side, and just pass the
error code back up the call chain.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat_super.c | 92 +
1 file changed, 14 insertions
There are 6 FFS_* error values not used at all. Remove them.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 443fafe1d89d..b3fc9bb06c24 100644
Convert FFS_FORMATERR to -EFSCORRUPTED
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 ++-
drivers/staging/exfat/exfat_core.c | 8
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
The rest of the conversion from internal error numbers to the
standard values used in the rest of the kernel.
Patch 10/10 is logically separate, merging multiple #defines
into one place in errno.h. It's included in the series because
it depends on patch 1/10.
Valdis Kletnieks (10):
staging
in just one place.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h| 2 --
fs/erofs/internal.h | 2 --
fs/ext4/ext4.h | 1 -
fs/f2fs/f2fs.h | 1 -
fs/xfs/xfs_linux.h | 1 -
include/linux/jbd2.h | 1
Remove the top-level mount functionality, to make this driver handle
only exfat file systems.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/Kconfig | 9 --
drivers/staging/exfat/exfat.h | 2 -
drivers/staging/exfat/exfat_core.c | 193
These functions are only used in the local file, make them static
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 6 --
drivers/staging/exfat/exfat_core.c | 8
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b
In this patch, we straighten out most of the cases where the
code was testing 'p_fs->vol_type == EXFAT' and '!= EXFAT'
There's still some ?: ops and a few places where the code
is doing checks for '.' and '..' that require looking at,
but those are future patches
Signed-off-by: Valdis Kletni
Rename all the FAT_* functions to exfat_fat_*.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 12 +-
drivers/staging/exfat/exfat_cache.c | 26 +++---
drivers/staging/exfat/exfat_core.c | 34 ++---
drivers/staging/exfat
Global functions called 'buf*' are a linkage editor disaster waiting to
happen. Rename our buf_* functions to exfat_buf_*
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 18 +++---
drivers/staging/exfat/exfat_cache.c | 22 +++
drivers/staging/exfat/exfat_core.c
Remove no longer referenced FAT/VFAT routines.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 44 --
drivers/staging/exfat/exfat_core.c | 619 -
2 files changed, 663 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging
The code simplification from the previous patch rendered a few more
routines unreferenced, so heave them over the side as well.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 19 ---
drivers/staging/exfat/exfat_core.c | 137
drivers/staging/exfat
Rename all the bdev_* to exfat_bdev_*
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h| 10 +-
drivers/staging/exfat/exfat_blkdev.c | 10 +-
drivers/staging/exfat/exfat_core.c | 8
drivers/staging/exfat/exfat_super.c | 16
4
Relocating these functions to before first use lets us make them static
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 4 --
drivers/staging/exfat/exfat_core.c | 78 +++---
2 files changed, 39 insertions(+), 43 deletions(-)
diff --git
Some more functions that can be moved and made static
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 -
drivers/staging/exfat/exfat_core.c | 182 ++---
2 files changed, 91 insertions(+), 94 deletions(-)
diff --git a/drivers/staging/exfat
*should* be getting called someplace
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 8 --
drivers/staging/exfat/exfat_core.c | 170 ++---
2 files changed, 85 insertions(+), 93 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers
Everything referenced in the struct fs_func exfat_fs_func is located
in that same .c file. Make them static and remove from exfat.h
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 32 ---
drivers/staging/exfat/exfat_core.c | 42
The first 4 patches iteratively remove more and more of the
FAT/VFAT code.
The second 8 patches make a lot of functions static, and
renames many of the rest to avoid namespace pollution.
Valdis Kletnieks (12):
staging: exfat: Remove FAT/VFAT mount support, part 1
staging: exfat: Remove FAT
Updating with the current laundry list of things that need attention.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/TODO | 70 --
1 file changed, 59 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/TODO b/drivers/staging/exfat
Convert FFS_ERROR to -EINVAL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_core.c | 10 +-
drivers/staging/exfat/exfat_super.c | 20 ++--
3 files changed, 15 insertions(+), 16 deletions(-)
diff --git
Convert FFS_MEDIAERR to (mostly) -ENOENT and -EIO. Some additional code surgery
needed to propogate correct error codes upwards.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h| 1 -
drivers/staging/exfat/exfat_blkdev.c | 18 ++---
drivers/staging/exfat
Covert FFS_INVALIDFID to -EINVAL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 10 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
Now that we no longer use odd internal return codes, we can
heave the translation code over the side, and just pass the
error code back up the call chain.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat_super.c | 92 +
1 file changed, 14 insertions
Convert FFS_EOF to return 0 for a zero-length read() as per 'man 2 read'.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b
Convert FFS_SUCCESS to 0.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 -
drivers/staging/exfat/exfat_cache.c | 4 +-
drivers/staging/exfat/exfat_core.c | 104 ++--
drivers/staging/exfat/exfat_super.c | 50 ++---
4 files
Convert FFS_FORMATERR to -EFSCORRUPTED
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 ++-
drivers/staging/exfat/exfat_core.c | 8
drivers/staging/exfat/exfat_super.c | 2 +-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
There are 6 FFS_* error values not used at all. Remove them.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 443fafe1d89d..b3fc9bb06c24 100644
syzbot took a nosedive because it runs with panic_on_warn set. And
it's quite correct, it shouldn't have been a WARN in the first place.
Other locations just use a pr_info(), so do that here too.
Signed-off-by: Valdis Kletnieks
Reported-by: syzbot+787bcbef9b5fec619...@syzkaller.appspotmail.com
Convert FFS_ERROR to -EINVAL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_core.c | 8
drivers/staging/exfat/exfat_super.c | 20 ++--
3 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers
Just replace FFS_SUCCESS with a literal 0.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 -
drivers/staging/exfat/exfat_cache.c | 4 +-
drivers/staging/exfat/exfat_core.c | 90 ++---
drivers/staging/exfat/exfat_super.c | 50
There are 6 FFS_* error values not used at all. Remove them.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 2ca2710601ae..819a21d72c67 100644
Convert FFS_PERMISSIONERR to -EPERM
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 20 ++--
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging
Covert FFS_INVALIDFID to -EINVAL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 10 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
Convert FFS_MEDIAERR to (mostly) -ENOENT and -EIO. Some additional code surgery
needed to propogate correct error codes upwards.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h| 1 -
drivers/staging/exfat/exfat_blkdev.c | 18 ++---
drivers/staging/exfat
Convert FFS_FORMATERR to -EFSCORRUPTED
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 3 ++-
drivers/staging/exfat/exfat_core.c | 4 ++--
drivers/staging/exfat/exfat_super.c | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/exfat
Convert FFS_EOF to return 0 for a zero-length read() as per 'man 2 read'.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b
Convert FFS_MEMORYERR to -ENOMEM
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_core.c | 10 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index
Convert FFS_NOTFOUND to -ENOENT
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index
Convert FFS_FILEEXIST to -EEXIST
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_core.c | 2 +-
drivers/staging/exfat/exfat_super.c | 14 +++---
3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging
Convert FFS_NOTNAMETOOLONG to -ENAMETOOLONG
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
Convert FFS_INVALIDPATH to -EINVAL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_core.c | 10 +-
drivers/staging/exfat/exfat_super.c | 10 +-
3 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers
Start cleaning up the odd scheme of return codes, starting with FFS_FULL
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_core.c | 10 +-
drivers/staging/exfat/exfat_super.c | 16
3 files changed, 13 insertions
The code had its own non-standard FFS_FOO return codes. Go through
and convert them all the kernel standard -EFOO codes.
Valdis Kletnieks (15):
staging: exfat: Clean up return codes - FFS_FULL
staging: exfat: Clean up return codes - FFS_NOTFOUND
staging: exfat: Clean up return codes
Convert FFS_DIRBUSY to -EBUSY
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_super.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 1d82de4e1a5c
Many of the static definitions that remain are not needed, as the function
definition is already before the first use.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 53 ---
1 file changed, 53 deletions(-)
diff --git a/drivers/staging/exfat
Move static function bodies before first use, remove the definition in exfat.h
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 6 -
drivers/staging/exfat/exfat_core.c | 500 ++---
2 files changed, 250 insertions(+), 256 deletions(-)
diff --git
Move static function bodies before first use, remove the definition in exfat.h
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 4 --
drivers/staging/exfat/exfat_cache.c | 94 +++--
2 files changed, 48 insertions(+), 50 deletions(-)
diff --git
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/TODO | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/exfat/TODO b/drivers/staging/exfat/TODO
index b60e50b9cf4e..110c30834bd2 100644
--- a/drivers/staging/exfat/TODO
+++ b/drivers
Remove the top-level mount functionality, to make this driver handle
only exfat file systems.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/Kconfig | 9 --
drivers/staging/exfat/exfat.h | 2 -
drivers/staging/exfat/exfat_core.c | 142
Two main goals here - remove the code to mount FAT and VFAT filesystes,
and make a lot of functions static to reduce namespace pollution.
Valdis Kletnieks (8):
staging: exfat: Clean up namespace pollution, part 1
staging: exfat: Remove FAT/VFAT mount support, part 1
staging: exfat: Remove
Remove no longer referenced FAT/VFAT routines.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 49 +-
drivers/staging/exfat/exfat_core.c | 755 -
2 files changed, 2 insertions(+), 802 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h
Make as much as possible static. We're over-exuberant here for the benefit
of a following patch, as the compiler will flag now-unused static code
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 156 ++---
drivers/staging/exfat/exfat_core.c | 142
Move static function bodies before first use, remove the definition in exfat.h
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat.h | 10 -
drivers/staging/exfat/exfat_core.c | 661 ++---
2 files changed, 330 insertions(+), 341 deletions(-)
diff --git
.
Valdis Kletnieks (9):
staging: exfat: Clean up return codes - FFS_FORMATERR
staging: exfat: Clean up return codes - FFS_MEDIAERR
staging: exfat: Clean up return codes - FFS_EOF
staging: exfat: Clean up return codes - FFS_INVALIDFID
staging: exfat: Clean up return codes - FFS_ERROR
staging
Use -ENOTEMPTY rather than -EEXIST for attempting to remove
a directory that still has files in it.
Signed-off-by: Valdis Kletnieks
---
drivers/staging/exfat/exfat_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging
90 matches
Mail list logo
