[PATCH 5/5] staging: rtl8723bs: remove set but not used variable 'change', 'pos'

2019-11-17 Thread zhengbin
so remove them. Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg802

[PATCH -next] staging: rtl8192e: remove set but not used variable 'frag'

2019-11-17 Thread zhengbin
3d461c912462 ("rtl8192e: Split into two directories"), but never used, so remove it. Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192

[PATCH 1/5] staging: rtl8723bs: remove set but not used variable 'pHalData', 'pregistrypriv'

2019-11-17 Thread zhengbin
Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index 0f5dd46..e813382 100644 --- a/drive

[PATCH 0/5] staging: rtl8723bs: remove some unused variables

2019-11-17 Thread zhengbin
zhengbin (5): staging: rtl8723bs: remove set but not used variable 'pHalData','pregistrypriv' staging: rtl8723bs: remove set but not used variable 'pHalData','pdmpriv' staging: rtl8723bs: remove set but not used variable 'pmlmeinfo','pHalData' staging: rtl8723bs: remove set

[PATCH 2/5] staging: rtl8723bs: remove set but not used variable 'pHalData', 'pdmpriv'

2019-11-17 Thread zhengbin
river"), but never used, so remove them. Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_in

[PATCH 3/5] staging: rtl8723bs: remove set but not used variable 'pmlmeinfo', 'pHalData'

2019-11-17 Thread zhengbin
/rtl8723b_cmd.c:2149:23: warning: variable pHalData set but not used [-Wunused-but-set-variable] They are introduced by commit 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver"), but never used, so remove them. Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl

[PATCH 4/5] staging: rtl8723bs: remove set but not used variable 'notify_ielen', 'notify_ie', 'notify_interval', 'notify_capability'

2019-11-17 Thread zhengbin
notify_capability set but not used [-Wunused-but-set-variable] They are introduced by commit 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver"), but never used, so remove them. Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 10

[PATCH 2/5] staging: rtl8723bs: Remove set but not used variable 'tmp_aid'

2019-10-06 Thread zhengbin
("staging: Add rtl8723bs sdio wifi driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c ind

[PATCH 3/5] staging: rtl8723bs: Remove set but not used variable 'prwskeylen'

2019-10-06 Thread zhengbin
: variable prwskeylen set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/core/rtw_security.c | 9 - 1 file changed, 9

[PATCH 4/5] staging: rtl8723bs: Remove set but not used variables 'ppp', 'type', 'data'

2019-10-06 Thread zhengbin
but not used [-Wunused-but-set-variable] They are not used since commit 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/core/rtw_recv.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

[PATCH 5/5] staging: rtl8723bs: Remove set but not used variable 'adapter'

2019-10-06 Thread zhengbin
("staging: Add rtl8723bs sdio wifi driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c ind

[PATCH 0/5] staging/rtl8723bs/core: Remove some set but not used variables

2019-10-06 Thread zhengbin
zhengbin (5): staging: rtl8723bs: Remove set but not used variable 'i' staging: rtl8723bs: Remove set but not used variable 'tmp_aid' staging: rtl8723bs: Remove set but not used variable 'prwskeylen' staging: rtl8723bs: Remove set but not used variables 'ppp','type','data' staging

[PATCH 1/5] staging: rtl8723bs: Remove set but not used variable 'i'

2019-10-06 Thread zhengbin
: Add rtl8723bs sdio wifi driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index b5dcb7

[PATCH] staging: rtl8723bs: Remove set but not used variable 'oldcnt'

2019-10-06 Thread zhengbin
aging: rtl8723bs: remove unused code") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index 301d327..1267

[PATCH 0/6] staging: Remove a bounch set of set but not used variables

2019-10-07 Thread zhengbin
zhengbin (6): staging: bcm2835-audio: Remove set but not used variable 'status' staging: sm750fb: Remove set but not used variable 'uiActualPixelClk' staging: sm750fb: Remove set but not used variable 'actual_mx_clk' staging: comedi: Remove set but not used variable 'data' staging

[PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'

2019-10-07 Thread zhengbin
("staging: sm750fb: add sm750 to staging") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/sm750fb/ddk750_mode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 972269

[PATCH 3/6] staging: sm750fb: Remove set but not used variable 'actual_mx_clk'

2019-10-07 Thread zhengbin
750fb: lower case to fix camelcase checkpatch warning") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/sm750fb/ddk750_chip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_ch

[PATCH 6/6] staging: comedi: Remove set but not used variable 'aref'

2019-10-07 Thread zhengbin
omedi: dt3000: rename dt3k_ai_insn()") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/comedi/drivers/dt3000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c ind

[PATCH 5/6] staging: comedi: Remove set but not used variable 'hi'

2019-10-07 Thread zhengbin
: add dt2815 driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/comedi/drivers/dt2815.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2815.c b/drivers/staging/comedi/drivers/dt2815.c index 83026ba..bcf8

[PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status'

2019-10-07 Thread zhengbin
since commit 23b028c871e1 ("staging: bcm2835-audio: initial staging submission") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc0

[PATCH 4/6] staging: comedi: Remove set but not used variable 'data'

2019-10-07 Thread zhengbin
omedi: refactor dt2814 driver and use module_comedi_driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/comedi/drivers/dt2814.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c ind

[PATCH v2 0/6] staging: Remove a bounch set of set but not used variables

2019-10-08 Thread zhengbin
v1->v2: need to judge the value of status, If status != 0, just return zhengbin (6): staging: bcm2835-audio: Need to judge the return value of vchi_msg_dequeue in audio_vchi_callback staging: sm750fb: Remove set but not used variable 'uiActualPixelClk' staging: sm750fb: Remove

[PATCH v2 5/6] staging: comedi: Remove set but not used variable 'hi'

2019-10-08 Thread zhengbin
: add dt2815 driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/comedi/drivers/dt2815.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2815.c b/drivers/staging/comedi/drivers/dt2815.c index 83026ba..bcf8

[PATCH v2 3/6] staging: sm750fb: Remove set but not used variable 'actual_mx_clk'

2019-10-08 Thread zhengbin
750fb: lower case to fix camelcase checkpatch warning") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/sm750fb/ddk750_chip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_ch

[PATCH v2 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'

2019-10-08 Thread zhengbin
("staging: sm750fb: add sm750 to staging") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/sm750fb/ddk750_mode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 972269

[PATCH v2 6/6] staging: comedi: Remove set but not used variable 'aref'

2019-10-08 Thread zhengbin
omedi: dt3000: rename dt3k_ai_insn()") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/comedi/drivers/dt3000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c ind

[PATCH v2 4/6] staging: comedi: Remove set but not used variable 'data'

2019-10-08 Thread zhengbin
omedi: refactor dt2814 driver and use module_comedi_driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/comedi/drivers/dt2814.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c ind

[PATCH v2 1/6] staging: bcm2835-audio: Need to judge the return value of vchi_msg_dequeue in audio_vchi_callback

2019-10-08 Thread zhengbin
If vchi_msg_dequeue return -1, variable m is not assigined, need to return. Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835

[PATCH v2] staging: rtl8723bs: Remove set but not used variable 'i'

2019-10-07 Thread zhengbin
: Add rtl8723bs sdio wifi driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index b5dcb7

[PATCH v3] staging: rtl8723bs: Remove set but not used variable 'i'

2019-10-08 Thread zhengbin
: Add rtl8723bs sdio wifi driver") Reported-by: Hulk Robot Signed-off-by: zhengbin --- v1->v2: remove unnecessary (void) of (void)_rtw_pktfile_read(...) v2->v3: add the changelog for v1->v2 drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) d

[PATCH 0/3] staging: wfx: Make some functions static

2019-10-09 Thread zhengbin
zhengbin (3): staging: wfx: Make function 'sram_write_dma_safe','load_firmware_secure' static staging: wfx: Make function 'wfx_tx_queue_get' static staging: wfx: Make some functions static in sta.c drivers/staging/wfx/fwio.c | 5 +++-- drivers/staging/wfx/queue.c | 3 ++- drivers

[PATCH 1/3] staging: wfx: Make function 'sram_write_dma_safe', 'load_firmware_secure' static

2019-10-09 Thread zhengbin
Fix sparse warnings: drivers/staging/wfx/fwio.c:83:5: warning: symbol 'sram_write_dma_safe' was not declared. Should it be static? drivers/staging/wfx/fwio.c:229:5: warning: symbol 'load_firmware_secure' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: zhengbin

[PATCH 3/3] staging: wfx: Make some functions static in sta.c

2019-10-09 Thread zhengbin
' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/wfx/sta.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 2855d14..d19bab6 100644 --- a/drivers/staging/wfx

[PATCH 2/3] staging: wfx: Make function 'wfx_tx_queue_get' static

2019-10-09 Thread zhengbin
Fix sparse warnings: drivers/staging/wfx/queue.c:218:16: warning: symbol 'wfx_tx_queue_get' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/wfx/queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 1/3] staging: wfx: Make function 'sram_write_dma_safe', 'load_firmware_secure' static

2019-10-09 Thread zhengbin
Fix sparse warnings: drivers/staging/wfx/fwio.c:83:5: warning: symbol 'sram_write_dma_safe' was not declared. Should it be static? drivers/staging/wfx/fwio.c:229:5: warning: symbol 'load_firmware_secure' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: zhengbin

[PATCH v2 2/3] staging: wfx: Make function 'wfx_tx_queue_get' static

2019-10-09 Thread zhengbin
Fix sparse warnings: drivers/staging/wfx/queue.c:218:16: warning: symbol 'wfx_tx_queue_get' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/wfx/queue.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 3/3] staging: wfx: Make some functions static in sta.c

2019-10-09 Thread zhengbin
' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/staging/wfx/sta.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 2855d14..d19bab6 100644 --- a/drivers/staging/wfx

[PATCH v2 0/3] staging: wfx: Make some functions static

2019-10-09 Thread zhengbin
v1->v2: keep the declaration style consistent within the file zhengbin (3): staging: wfx: Make function 'sram_write_dma_safe','load_firmware_secure' static staging: wfx: Make function 'wfx_tx_queue_get' static staging: wfx: Make some functions static in sta.c drivers/staging/