Re: [PATCH] Staging: comedi: fix camelcase issue in range.c

[Greg KH]

On Thu, Feb 15, 2018 at 01:36:43AM +0530, Yash Omer wrote:
> This is a patch to the range.c file that fixes up a camelcase warning found 
> bythe checkpatch.pl tool.
> 
> Signed-off-by: Yash Omer 
> ---
>  drivers/staging/comedi/range.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
> index 087bbde7bf12..ec128a6a70bb 100644
> --- a/drivers/staging/comedi/range.c
> +++ b/drivers/staging/comedi/range.c
> @@ -24,7 +24,7 @@ EXPORT_SYMBOL_GPL(range_unipolar5);
>  const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
>  EXPORT_SYMBOL_GPL(range_unipolar2_5);
>  const struct comedi_lrange RANGE_0_20m_A = { 1, {RANGE_m_A(0, 20)} };
> -EXPORT_SYMBOL_GPL(range_0_20mA);
> +EXPORT_SYMBOL_GPL(range_0_20m_A);

That change really does not make that much sense, does it?  Checkpatch
is a hint, you don't want to change wyat "mA" means, right?

And did you test-build this change?  It should not work as-is :(

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: comedi: fix camelcase issue in range.c

[Yash Omer]

This is a patch to the range.c file that fixes up a camelcase warning found by  
the checkpatch.pl tool.

Signed-off-by: Yash Omer 
---
 drivers/staging/comedi/range.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 087bbde7bf12..ec128a6a70bb 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -24,7 +24,7 @@ EXPORT_SYMBOL_GPL(range_unipolar5);
 const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
 EXPORT_SYMBOL_GPL(range_unipolar2_5);
 const struct comedi_lrange RANGE_0_20m_A = { 1, {RANGE_m_A(0, 20)} };
-EXPORT_SYMBOL_GPL(range_0_20mA);
+EXPORT_SYMBOL_GPL(range_0_20m_A);
 const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
 EXPORT_SYMBOL_GPL(range_4_20mA);
 const struct comedi_lrange RANGE_0_32m_A = { 1, {RANGE_mA(0, 32)} };
-- 
2.14.3

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel