Re: [PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

2018-09-28 Thread Nathan Chancellor
On Fri, Sep 28, 2018 at 10:04:29AM +0100, Dave Stevenson wrote: > Hi Nate > > Thanks for the patch. > > On Fri, 28 Sep 2018 at 01:53, Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: > > variable 'mains_freq_qmenu'

Re: [PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

2018-09-28 Thread Dave Stevenson
Hi Nate Thanks for the patch. On Fri, 28 Sep 2018 at 01:53, Nathan Chancellor wrote: > > Clang warns: > > drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: > variable 'mains_freq_qmenu' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static

[PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

2018-09-27 Thread Nathan Chancellor
Clang warns: drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: variable 'mains_freq_qmenu' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const s64 mains_freq_qmenu[] = { ^ 1 warning generated. This is because