Re: [PATCH] staging: iio: adc: ad7280: Add spaces around math operator
On Sun, Nov 10, 2019 at 01:27:10PM +, Jonathan Cameron wrote: > On Sat, 9 Nov 2019 16:17:28 +0100 > Pedro Ortega wrote: > > > Add spaces around the minus math operator to increase readability. > > > > Signed-off-by: Pedro Ortega > Hi Pedro, > > Afraid not. Look at what that macro is actually doing. That's not a maths > operator at all. I'm fairly sure we had a plan to actually hide these > examples away as we get a few people suggesting this 'fix' ever year. > Not sure what happened to them though, I'll have to check back. I'm sorry. Next time I will review the code much more carefully. The macro IIO_DEVICE_ATTR_NAMED expand the second parameter to a string. So, the hyphen is not a maths operator. > > Sorry about this, but it is a good lesson in making sure you check > that the suggestion from checkpatch is actually correct. It's a > pattern matcher, it can't always know enough to be able to tell what > is going on. First lesson learned. > > Thanks, > > Jonathan Thanks, Pedro > > > --- > > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/iio/adc/ad7280a.c > > b/drivers/staging/iio/adc/ad7280a.c > > index 19a5f244dcae..34ca0d09db85 100644 > > --- a/drivers/staging/iio/adc/ad7280a.c > > +++ b/drivers/staging/iio/adc/ad7280a.c > > @@ -825,14 +825,14 @@ static irqreturn_t ad7280_event_handler(int irq, void > > *private) > > } > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > > -in_voltage-voltage_thresh_low_value, > > +in_voltage - voltage_thresh_low_value, > > 0644, > > ad7280_read_channel_config, > > ad7280_write_channel_config, > > AD7280A_CELL_UNDERVOLTAGE); > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > > -in_voltage-voltage_thresh_high_value, > > +in_voltage - voltage_thresh_high_value, > > 0644, > > ad7280_read_channel_config, > > ad7280_write_channel_config, > > -- > > 2.17.1 > > > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: iio: adc: ad7280: Add spaces around math operator
On Sat, 9 Nov 2019 16:17:28 +0100 Pedro Ortega wrote: > Add spaces around the minus math operator to increase readability. > > Signed-off-by: Pedro Ortega Hi Pedro, Afraid not. Look at what that macro is actually doing. That's not a maths operator at all. I'm fairly sure we had a plan to actually hide these examples away as we get a few people suggesting this 'fix' ever year. Not sure what happened to them though, I'll have to check back. Sorry about this, but it is a good lesson in making sure you check that the suggestion from checkpatch is actually correct. It's a pattern matcher, it can't always know enough to be able to tell what is going on. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7280a.c > b/drivers/staging/iio/adc/ad7280a.c > index 19a5f244dcae..34ca0d09db85 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -825,14 +825,14 @@ static irqreturn_t ad7280_event_handler(int irq, void > *private) > } > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > - in_voltage-voltage_thresh_low_value, > + in_voltage - voltage_thresh_low_value, >0644, >ad7280_read_channel_config, >ad7280_write_channel_config, >AD7280A_CELL_UNDERVOLTAGE); > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > - in_voltage-voltage_thresh_high_value, > + in_voltage - voltage_thresh_high_value, >0644, >ad7280_read_channel_config, >ad7280_write_channel_config, > -- > 2.17.1 > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: iio: adc: ad7280: Add spaces around math operator
Add spaces around the minus math operator to increase readability. Signed-off-by: Pedro Ortega --- drivers/staging/iio/adc/ad7280a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 19a5f244dcae..34ca0d09db85 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b/drivers/staging/iio/adc/ad7280a.c @@ -825,14 +825,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) } static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, -in_voltage-voltage_thresh_low_value, +in_voltage - voltage_thresh_low_value, 0644, ad7280_read_channel_config, ad7280_write_channel_config, AD7280A_CELL_UNDERVOLTAGE); static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, -in_voltage-voltage_thresh_high_value, +in_voltage - voltage_thresh_high_value, 0644, ad7280_read_channel_config, ad7280_write_channel_config, -- 2.17.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
