Re: [PATCH] staging: ion: Fix checkpatch.pl coding style issues

2016-09-22 Thread Greg KH
On Thu, Sep 22, 2016 at 09:57:16AM +0300, Antti Keränen wrote: > This patch fixes two coding style issues found with checkpatch.pl. Both > of them are warnings. Ah, then this should be two separate patches :) Also, always use scripts/get_maintainer.pl to determine who to cc: on a patch. > >

[PATCH] staging: ion: Fix checkpatch.pl coding style issues

2016-09-22 Thread Antti Keränen
This patch fixes two coding style issues found with checkpatch.pl. Both of them are warnings. uapi/ion.h had an unaligned block comment. ion/hisilicon/hi6220_ion.c had unnecessary braces around a single statement block. One warning in uapi/ion.h was left in place that wanted a typedef

Re: [PATCH] staging: ion: Fix checkpatch.pl coding style issues

2016-09-22 Thread Greg KH
On Thu, Sep 22, 2016 at 09:08:01AM +0300, Antti Keränen wrote: > One warning was left in place that wanted a typedef (ion_user_handle_t) to be > removed. > I think the typedef makes sense so I left it intact. This does not describe at all what type of changes you made, or why you made them, only

[PATCH] staging: ion: Fix checkpatch.pl coding style issues

2016-09-22 Thread Antti Keränen
One warning was left in place that wanted a typedef (ion_user_handle_t) to be removed. I think the typedef makes sense so I left it intact. Signed-off-by: Antti Keränen --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++-- drivers/staging/android/uapi/ion.h