Re: [PATCH] staging: lustre: lmv: add missing function declaration

[Arnd Bergmann]

On Sunday, September 18, 2016 8:43:18 PM CEST James Simmons wrote:
> 
> Nak. I'm not seeing this error with W=1. Also if you look
> lmv_pack_md() is only used in lmv_obd.c and the function
> appears early in the file before it is used, so no prototype
> missing errors should happen. 

So it should be marked "static" and the EXPORT_SYMBOL() removed,
right?

Arnd

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: lustre: lmv: add missing function declaration

[James Simmons]

> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lmv/lmv_obd.c:2774:5: warning: no previous 
> prototype for 'lmv_pack_md' [-Wmissing-prototypes]
> 
> In fact, this function is not declared in any file,but should be
> declared in a header file, thus can be recognized in other file.
> 
> So this patch adds the declarations into
> drivers/staging/lustre/lustre/include/lustre_lmv.h.
> 
> Signed-off-by: Baoyou Xie 
> ---
>  drivers/staging/lustre/lustre/include/lustre_lmv.h | 2 ++
>  1 file changed, 2 insertions(+)

Nak. I'm not seeing this error with W=1. Also if you look
lmv_pack_md() is only used in lmv_obd.c and the function
appears early in the file before it is used, so no prototype
missing errors should happen. 
 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_lmv.h 
> b/drivers/staging/lustre/lustre/include/lustre_lmv.h
> index 085e596..21302c7 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_lmv.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_lmv.h
> @@ -119,3 +119,5 @@ static inline void lmv_le_to_cpu(union lmv_mds_md 
> *lmv_dst,
>  }
> 
> +int lmv_pack_md(union lmv_mds_md **lmmp, const struct lmv_stripe_md *lsm,
> + int stripe_count);
>  #endif
> -- 
> 2.7.4
> 
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: lustre: lmv: add missing function declaration

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/staging/lustre/lustre/lmv/lmv_obd.c:2774:5: warning: no previous 
prototype for 'lmv_pack_md' [-Wmissing-prototypes]

In fact, this function is not declared in any file,but should be
declared in a header file, thus can be recognized in other file.

So this patch adds the declarations into
drivers/staging/lustre/lustre/include/lustre_lmv.h.

Signed-off-by: Baoyou Xie 
---
 drivers/staging/lustre/lustre/include/lustre_lmv.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/lustre/lustre/include/lustre_lmv.h 
b/drivers/staging/lustre/lustre/include/lustre_lmv.h
index 085e596..21302c7 100644
--- a/drivers/staging/lustre/lustre/include/lustre_lmv.h
+++ b/drivers/staging/lustre/lustre/include/lustre_lmv.h
@@ -119,3 +119,5 @@ static inline void lmv_le_to_cpu(union lmv_mds_md *lmv_dst,
 }

+int lmv_pack_md(union lmv_mds_md **lmmp, const struct lmv_stripe_md *lsm,
+   int stripe_count);
 #endif
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel