Re: [PATCH] staging: pi433: Fix warnings from sparse

[Greg KH]

On Sat, Aug 12, 2017 at 10:39:41AM -0400, Quentin Swain wrote:
> Running sparse produced warnings regarding use of conflicting
> enum types and logical vs bitwise operator use.
> 
> Signed-off-by: Quentin Swain 
> ---
>  drivers/staging/pi433/pi433_if.c | 4 ++--
>  drivers/staging/pi433/rf69.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Patch does not apply to my tree, and be sure to always properly cc: the
correct developers for a patch by using scripts/get_maintainer.pl.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: pi433: Fix warnings from sparse

[Quentin Swain]

Running sparse produced warnings regarding use of conflicting
enum types and logical vs bitwise operator use.

Signed-off-by: Quentin Swain 
---
 drivers/staging/pi433/pi433_if.c | 4 ++--
 drivers/staging/pi433/rf69.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ed737f4..9d35e8d 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -210,7 +210,7 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct 
pi433_rx_cfg *rx_cfg)
{
SET_CHECKED(rf69_set_fifo_fill_condition(dev->spi, always));
}
-   SET_CHECKED(rf69_set_packet_format  (dev->spi, 
rx_cfg->enable_length_byte));
+   SET_CHECKED(rf69_set_packet_format(dev->spi, (enum 
packetFormat)rx_cfg->enable_length_byte));
SET_CHECKED(rf69_set_adressFiltering(dev->spi, 
rx_cfg->enable_address_filtering));
SET_CHECKED(rf69_set_crc_enable (dev->spi, rx_cfg->enable_crc));
 
@@ -267,7 +267,7 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct 
pi433_tx_cfg *tx_cfg)
SET_CHECKED(rf69_set_preamble_length(dev->spi, 0));
}
SET_CHECKED(rf69_set_sync_enable  (dev->spi, tx_cfg->enable_sync));
-   SET_CHECKED(rf69_set_packet_format(dev->spi, 
tx_cfg->enable_length_byte));
+   SET_CHECKED(rf69_set_packet_format(dev->spi, (enum 
packetFormat)tx_cfg->enable_length_byte));
SET_CHECKED(rf69_set_crc_enable   (dev->spi, tx_cfg->enable_crc));
 
/* configure sync, if enabled */
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index f83523e..e6332e1 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -203,7 +203,7 @@ int rf69_set_deviation(struct spi_device *spi, u32 
deviation)
lsb = (f_reg&0xff);
 
// check msb
-   if (msb & !FDEVMASB_MASK)
+   if (msb & ~FDEVMASB_MASK)
{
dev_dbg(&spi->dev, "set_deviation: err in calc of msb");
INVALID_PARAM;
-- 
2.10.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel