Re: [PATCH] staging: wilc1000: remove memory allocate failure message

2016-12-01 Thread Greg KH
On Fri, Dec 02, 2016 at 12:35:54AM +0530, Amit Kushwaha wrote:
> This patch cleanup following warning reported by checkpatch.pl
> WARNING: Possible unnecessary 'out of memory' message
> With no available memory, a warn on message already gets printed
> by page alloc functions
> 
> Signed-off-by: Amit Kushwaha 
> ---
>  drivers/staging/wilc1000/host_interface.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c
> b/drivers/staging/wilc1000/host_interface.c
> index b00ea75..23abdd4 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -1691,7 +1691,6 @@ static int Handle_Key(struct wilc_vif *vif,
>   } else if (pstrHostIFkeyAttr->action & ADDKEY) {
>   pu8keybuf = kmalloc(PTK_KEY_MSG_LEN, GFP_KERNEL);
>   if (!pu8keybuf) {
> - netdev_err(vif->ndev, "No buffer send PTK\n");
>   ret = -ENOMEM;
>   goto _WPAPtk_end_case_;
>   }
> -- 
> 2.10.2.windows.1

"windows"?

Anyway, you are obviously not testing your patches actually can be
applied, and you have now changed your email address, so I'm going to
assume there is something really wrong here and now just add your
emails to a blacklist.

I suggest working on a different open source project for a while to get
some experience.

best of luck,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] staging: wilc1000: remove memory allocate failure message

2016-12-01 Thread Amit Kushwaha
This patch cleanup following warning reported by checkpatch.pl
WARNING: Possible unnecessary 'out of memory' message
With no available memory, a warn on message already gets printed
by page alloc functions

Signed-off-by: Amit Kushwaha 
---
 drivers/staging/wilc1000/host_interface.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index b00ea75..23abdd4 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1691,7 +1691,6 @@ static int Handle_Key(struct wilc_vif *vif,
  } else if (pstrHostIFkeyAttr->action & ADDKEY) {
  pu8keybuf = kmalloc(PTK_KEY_MSG_LEN, GFP_KERNEL);
  if (!pu8keybuf) {
- netdev_err(vif->ndev, "No buffer send PTK\n");
  ret = -ENOMEM;
  goto _WPAPtk_end_case_;
  }
-- 
2.10.2.windows.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel