Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

2018-02-27 Thread Dan Carpenter
Hm... Sorry. I was looking at the wrong code. I was looking at aes_decipher() instead of rtw_aes_decrypt(). The aes_decipher() was acceptable style (although, it's of course good that you deleted it). rtw_aes_decrypt() was always really really awful. That's fine then. Sorry again. regards,

Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

2018-02-27 Thread Ivan Safonov
On 02/26/2018 10:56 AM, Dan Carpenter wrote: On Fri, Feb 23, 2018 at 05:57:42PM +0300, Ivan Safonov wrote: Custom AES decrypt implementation replaced with lib80211 library. Signed-off-by: Ivan Safonov The new code looks like original RTL code (really bad) so I'm

Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

2018-02-25 Thread Dan Carpenter
On Fri, Feb 23, 2018 at 05:57:42PM +0300, Ivan Safonov wrote: > Custom AES decrypt implementation replaced with lib80211 library. > > Signed-off-by: Ivan Safonov The new code looks like original RTL code (really bad) so I'm guessing you copy and pasted the code from

[PATCH] staging:r8188eu: use lib80211 CCMP decrypt

2018-02-23 Thread Ivan Safonov
Custom AES decrypt implementation replaced with lib80211 library. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/Kconfig | 1 + drivers/staging/rtl8188eu/core/rtw_security.c | 266 +- 2 files changed, 51 insertions(+), 216