Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-10-04 Thread Michael Ellerman
Emilio López writes: > Hi, > > El 27/09/16 a las 01:23, Michael Ellerman escribió: >> Emilio López writes: >>> El 22/09/16 a las 06:43, Michael Ellerman escribió: Emilio López writes: Please don't include the *kernel* headers, they're really not meant to be used in userspace

Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-09-27 Thread Emilio López
Hi, El 27/09/16 a las 01:23, Michael Ellerman escribió: Emilio López writes: El 22/09/16 a las 06:43, Michael Ellerman escribió: Emilio López writes: Please don't include the *kernel* headers, they're really not meant to be used in userspace programs :) +CFLAGS += -I../../../../usr/includ

Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-09-26 Thread Michael Ellerman
Emilio López writes: > El 22/09/16 a las 06:43, Michael Ellerman escribió: >> Emilio López writes: >> >> Please don't include the *kernel* headers, they're really not meant to >> be used in userspace programs :) >> >>> +CFLAGS += -I../../../../usr/include/ >> >> That is the correct place to get t

Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-09-22 Thread Emilio López
Hi Michael, El 22/09/16 a las 06:43, Michael Ellerman escribió: Emilio López writes: +CFLAGS += -I../../../../include/uapi/ Please don't include the unprocessed uapi headers, they are not meant to be directly included in userspace programs. They even say so: include/uapi/linux/types.h:#war

Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-09-22 Thread Michael Ellerman
Emilio López writes: > These tests are based on the libsync test suite from Android. > This commit lays the ground for future tests, as well as includes > tests for a variety of basic allocation commands. Hi Emilio, Just a few comments on the Makefile. > diff --git a/tools/testing/selftests/sy

[PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-09-21 Thread Emilio López
These tests are based on the libsync test suite from Android. This commit lays the ground for future tests, as well as includes tests for a variety of basic allocation commands. Signed-off-by: Emilio López --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/sync/.gitig