Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-10 Thread Joe Perches
On Sat, 2016-12-10 at 00:56 +0100, Markus Böhme wrote: > On 12/09/2016 09:50 AM, Kalle Valo wrote: > > Dan Carpenter writes: > > > > > On Thu, Dec 08, 2016 at 02:50:49PM +0300, Dan Carpenter wrote: > > > > On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: > >

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-09 Thread Markus Böhme
On 12/09/2016 09:50 AM, Kalle Valo wrote: > Dan Carpenter writes: > >> On Thu, Dec 08, 2016 at 02:50:49PM +0300, Dan Carpenter wrote: >>> On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: But it would make me very happy if someone would add a similar

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-09 Thread Kalle Valo
Dan Carpenter writes: > On Thu, Dec 08, 2016 at 02:50:49PM +0300, Dan Carpenter wrote: >> On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: >> > But it would make me very happy if someone would add a similar grouping >> > functionality to dyndbg to make it

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-09 Thread Kalle Valo
Dan Carpenter writes: > I don't have a problem with the ath debug printks. Larry asked me for > examples of better debug functions and the ath code is an example. > Literally, any existing debug functions are better than the > BTC_TRACE_STRING() stuff. Sure, I agree

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-08 Thread Dan Carpenter
On Thu, Dec 08, 2016 at 02:50:49PM +0300, Dan Carpenter wrote: > On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: > > But it would make me very happy if someone would add a similar grouping > > functionality to dyndbg to make it easy to enable a set of debug > > messages in a driver. >

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-08 Thread Dan Carpenter
I don't have a problem with the ath debug printks. Larry asked me for examples of better debug functions and the ath code is an example. Literally, any existing debug functions are better than the BTC_TRACE_STRING() stuff. On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: > But it

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-08 Thread Kalle Valo
Dan Carpenter writes: > On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: >> We have disccused this before, but for wireless it's not really that >> simple. AFAIK with dyndbg you can only control the messages per line >> (painful to enable group of messages)

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-07 Thread Larry Finger
On 12/07/2016 07:32 AM, Dan Carpenter wrote: On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: We have disccused this before, but for wireless it's not really that simple. AFAIK with dyndbg you can only control the messages per line (painful to enable group of messages) or per file

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-07 Thread Dan Carpenter
On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: > We have disccused this before, but for wireless it's not really that > simple. AFAIK with dyndbg you can only control the messages per line > (painful to enable group of messages) or per file (enables too many > messages). In wireless

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-07 Thread Kalle Valo
Greg KH writes: > On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote: >> On 12/05/2016 03:34 PM, Dan Carpenter wrote: >> > On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: >> > > --- >> > >

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-06 Thread Dan Carpenter
On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote: > Can you point me to a driver with a better way to conditionally dump > a debugging string to the logs? People should look at using ftrace and kprobes. They really are very powerful and useful. regards, dan carpenter

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-05 Thread Greg KH
On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote: > On 12/05/2016 03:34 PM, Dan Carpenter wrote: > > On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: > > > --- > > > wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > > +++ > > >

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-05 Thread Larry Finger
On 12/05/2016 03:34 PM, Dan Carpenter wrote: On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: --- wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h +++ wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h @@

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-05 Thread Dan Carpenter
On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: > --- > wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > +++ > wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > @@ -27,6 +27,29 @@ > > #include

[PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

2016-12-01 Thread Larry Finger
From: Ping-Ke Shih Add a new debugging function. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 23 ++