Re: [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments

[Dan Carpenter]

On Tue, Sep 20, 2016 at 05:38:57AM -0400, Brian Masney wrote:
> Address warning from checkpatch:
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Brian Masney 
> ---
>  drivers/staging/iio/light/isl29018.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/isl29018.c 
> b/drivers/staging/iio/light/isl29018.c
> index ea4d7f1..4401451 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -607,8 +607,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
>   return status;
>   }
>  
> - status = isl29018_set_integration_time(chip,
> - isl29018_int_utimes[chip->type][chip->int_time]);
> + status = isl29018_set_integration_time(
> + chip, isl29018_int_utimes[chip->type][chip->int_time]);

Congrats on finding a hack to silence checkpatch but this doesn't really
improve the code at all...  It's ok to ignore checkpatch.pl.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments

[Brian Masney]

Address warning from checkpatch:

CHECK: Alignment should match open parenthesis

Signed-off-by: Brian Masney 
---
 drivers/staging/iio/light/isl29018.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/light/isl29018.c 
b/drivers/staging/iio/light/isl29018.c
index ea4d7f1..4401451 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -607,8 +607,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
return status;
}
 
-   status = isl29018_set_integration_time(chip,
-   isl29018_int_utimes[chip->type][chip->int_time]);
+   status = isl29018_set_integration_time(
+   chip, isl29018_int_utimes[chip->type][chip->int_time]);
if (status < 0) {
dev_err(dev, "Init of isl29018 fails\n");
return status;
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel