Re: [PATCH 3/3] staging: greybus: use preferred kernel type u32

[Chaehyun Lim]

On Tue, Sep 20, 2016 at 3:29 PM, Greg KH  wrote:
> On Tue, Sep 20, 2016 at 09:47:31AM +0900, Chaehyun Lim wrote:
>> As suggested by checkpatch.pl:
>>
>> CHECK: Prefer kernel type 'u32' over 'uint32_t'
>>
>> Signed-off-by: Chaehyun Lim 
>> ---
>>  drivers/staging/greybus/audio_codec.c |  6 ++--
>>  drivers/staging/greybus/audio_codec.h | 10 +++
>>  drivers/staging/greybus/audio_gb.c|  4 +--
>>  drivers/staging/greybus/sdio.c|  2 +-
>>  drivers/staging/greybus/tools/loopback_test.c | 40 
>> +--
>>  5 files changed, 31 insertions(+), 31 deletions(-)
>
> Oops, I applied this but will drop it as loopback_test is a userspace
> tool, and I don't think that u32 will work there.  Did you test build
> this?
>
> thanks,
>
> greg k-h

I'm sorry that I didn't notice it's not compiled when doing build this module

thanks
chaehyun lim
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] staging: greybus: use preferred kernel type u32

[Greg KH]

On Tue, Sep 20, 2016 at 09:47:31AM +0900, Chaehyun Lim wrote:
> As suggested by checkpatch.pl:
> 
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> 
> Signed-off-by: Chaehyun Lim 
> ---
>  drivers/staging/greybus/audio_codec.c |  6 ++--
>  drivers/staging/greybus/audio_codec.h | 10 +++
>  drivers/staging/greybus/audio_gb.c|  4 +--
>  drivers/staging/greybus/sdio.c|  2 +-
>  drivers/staging/greybus/tools/loopback_test.c | 40 
> +--
>  5 files changed, 31 insertions(+), 31 deletions(-)

Oops, I applied this but will drop it as loopback_test is a userspace
tool, and I don't think that u32 will work there.  Did you test build
this?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/3] staging: greybus: use preferred kernel type u32

[Chaehyun Lim]

As suggested by checkpatch.pl:

CHECK: Prefer kernel type 'u32' over 'uint32_t'

Signed-off-by: Chaehyun Lim 
---
 drivers/staging/greybus/audio_codec.c |  6 ++--
 drivers/staging/greybus/audio_codec.h | 10 +++
 drivers/staging/greybus/audio_gb.c|  4 +--
 drivers/staging/greybus/sdio.c|  2 +-
 drivers/staging/greybus/tools/loopback_test.c | 40 +--
 5 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/drivers/staging/greybus/audio_codec.c 
b/drivers/staging/greybus/audio_codec.c
index 5ce2542..ae0daeb 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -48,7 +48,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info 
*codec,
int module_state, ret = 0;
u16 data_cport, i2s_port, cportid;
u8 sig_bits, channels;
-   uint32_t format, rate;
+   u32 format, rate;
struct gbaudio_data_connection *data;
struct gbaudio_stream_params *params;
 
@@ -183,7 +183,7 @@ static int gbaudio_module_enable_rx(struct 
gbaudio_codec_info *codec,
int module_state, ret = 0;
u16 data_cport, i2s_port, cportid;
u8 sig_bits, channels;
-   uint32_t format, rate;
+   u32 format, rate;
struct gbaudio_data_connection *data;
struct gbaudio_stream_params *params;
 
@@ -414,7 +414,7 @@ static int gbcodec_hw_params(struct snd_pcm_substream 
*substream,
 {
int ret;
u8 sig_bits, channels;
-   uint32_t format, rate;
+   u32 format, rate;
struct gbaudio_module_info *module;
struct gbaudio_data_connection *data;
struct gb_bundle *bundle;
diff --git a/drivers/staging/greybus/audio_codec.h 
b/drivers/staging/greybus/audio_codec.h
index ca027bd..43a2e4a 100644
--- a/drivers/staging/greybus/audio_codec.h
+++ b/drivers/staging/greybus/audio_codec.h
@@ -99,7 +99,7 @@ enum gbaudio_codec_state {
 struct gbaudio_stream_params {
int state;
u8 sig_bits, channels;
-   uint32_t format, rate;
+   u32 format, rate;
 };
 
 struct gbaudio_codec_dai {
@@ -231,12 +231,12 @@ extern int gb_audio_gb_enable_widget(struct gb_connection 
*connection,
 extern int gb_audio_gb_disable_widget(struct gb_connection *connection,
  u8 widget_id);
 extern int gb_audio_gb_get_pcm(struct gb_connection *connection,
-  u16 data_cport, uint32_t *format,
-  uint32_t *rate, u8 *channels,
+  u16 data_cport, u32 *format,
+  u32 *rate, u8 *channels,
   u8 *sig_bits);
 extern int gb_audio_gb_set_pcm(struct gb_connection *connection,
-  u16 data_cport, uint32_t format,
-  uint32_t rate, u8 channels,
+  u16 data_cport, u32 format,
+  u32 rate, u8 channels,
   u8 sig_bits);
 extern int gb_audio_gb_set_tx_data_size(struct gb_connection *connection,
u16 data_cport, u16 size);
diff --git a/drivers/staging/greybus/audio_gb.c 
b/drivers/staging/greybus/audio_gb.c
index 42f287d..7884d84 100644
--- a/drivers/staging/greybus/audio_gb.c
+++ b/drivers/staging/greybus/audio_gb.c
@@ -108,7 +108,7 @@ int gb_audio_gb_disable_widget(struct gb_connection 
*connection,
 EXPORT_SYMBOL_GPL(gb_audio_gb_disable_widget);
 
 int gb_audio_gb_get_pcm(struct gb_connection *connection, u16 data_cport,
-   uint32_t *format, uint32_t *rate, u8 *channels,
+   u32 *format, u32 *rate, u8 *channels,
u8 *sig_bits)
 {
struct gb_audio_get_pcm_request req;
@@ -132,7 +132,7 @@ int gb_audio_gb_get_pcm(struct gb_connection *connection, 
u16 data_cport,
 EXPORT_SYMBOL_GPL(gb_audio_gb_get_pcm);
 
 int gb_audio_gb_set_pcm(struct gb_connection *connection, u16 data_cport,
-   uint32_t format, uint32_t rate, u8 channels,
+   u32 format, u32 rate, u8 channels,
u8 sig_bits)
 {
struct gb_audio_set_pcm_request req;
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index c7133b1..886e62e 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -52,7 +52,7 @@ struct gb_sdio_host {
 
 static inline bool single_op(struct mmc_command *cmd)
 {
-   uint32_t opcode = cmd->opcode;
+   u32 opcode = cmd->opcode;
 
return opcode == MMC_WRITE_BLOCK ||
   opcode == MMC_READ_SINGLE_BLOCK;
diff --git a/drivers/staging/greybus/tools/loopback_test.c 
b/drivers/staging/greybus/tools/loopback_test.c
index f7f4cd6..2d75fa8 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -40,31 +40,31 @@ static struct