Re: [RESEND PATCH v1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
On Tue, Jun 02, 2020 at 03:57:15PM +0300, Dan Carpenter wrote: > On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote: > > Currently, GB codec and audio module is conditionally compiled based on > > GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994 > > platform and can be used generically with any platform that follows > > GB Audio class specification. > > > > Also, GB codec driver corresponds to dummy codec represented by I2S port > > available on Toshiba AP Bridge. Added config option for the same in > > kconfig file and accordingly updated Makefile. > > > > This commit message was a bit confusing to me. Just say: > > "Currently you can't enable the Grey Bus Audio Codec because there is no > entry for it in the Kconfig file. Originally the config name was going > to be AUDIO_MSM8994 but that's not correct because other types of > hardware are supported now. I have chosen the name AUDIO_APB_CODEC > instead. Also I had to update the dependencies for GREYBUS_AUDIO to > make the compile work." > > Otherwise this looks fine. Thanks Dan for sharing your valuable feedback. I'll make the suggested changes for the complete series in v2 patchset. regards, vaibhav > > regards, > dan carpenter > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RESEND PATCH v1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote: > Currently, GB codec and audio module is conditionally compiled based on > GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994 > platform and can be used generically with any platform that follows > GB Audio class specification. > > Also, GB codec driver corresponds to dummy codec represented by I2S port > available on Toshiba AP Bridge. Added config option for the same in > kconfig file and accordingly updated Makefile. > This commit message was a bit confusing to me. Just say: "Currently you can't enable the Grey Bus Audio Codec because there is no entry for it in the Kconfig file. Originally the config name was going to be AUDIO_MSM8994 but that's not correct because other types of hardware are supported now. I have chosen the name AUDIO_APB_CODEC instead. Also I had to update the dependencies for GREYBUS_AUDIO to make the compile work." Otherwise this looks fine. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[RESEND PATCH v1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
Currently, GB codec and audio module is conditionally compiled based on GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994 platform and can be used generically with any platform that follows GB Audio class specification. Also, GB codec driver corresponds to dummy codec represented by I2S port available on Toshiba AP Bridge. Added config option for the same in kconfig file and accordingly updated Makefile. Signed-off-by: Vaibhav Agarwal --- drivers/staging/greybus/Kconfig | 14 +- drivers/staging/greybus/Makefile | 4 ++-- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/Kconfig b/drivers/staging/greybus/Kconfig index d4777f5a8b90..cbcfcbba239b 100644 --- a/drivers/staging/greybus/Kconfig +++ b/drivers/staging/greybus/Kconfig @@ -3,7 +3,7 @@ if GREYBUS config GREYBUS_AUDIO tristate "Greybus Audio Class driver" - depends on SOUND + depends on SOUND && SND_SOC ---help--- Select this option if you have a device that follows the Greybus Audio Class specification. @@ -11,6 +11,18 @@ config GREYBUS_AUDIO To compile this code as a module, chose M here: the module will be called gb-audio.ko +config GREYBUS_AUDIO_APB_CODEC + tristate "Greybus APBridge Audio codec driver" + depends on SND_SOC && GREYBUS_AUDIO + help + Select this option if you have a Toshiba APB device that has I2S + ports and acts as a Greybus "Dummy codec". This device is a + bridge from an APB-I2S port to a Unipro network. + + To compile this code as a module, chose M here: the module + will be called gb-audio-codec.ko + + config GREYBUS_BOOTROM tristate "Greybus Bootrom Class driver" ---help--- diff --git a/drivers/staging/greybus/Makefile b/drivers/staging/greybus/Makefile index 3b4b6cabff19..7c5e89622334 100644 --- a/drivers/staging/greybus/Makefile +++ b/drivers/staging/greybus/Makefile @@ -40,8 +40,8 @@ gb-audio-manager-y:= audio_manager.o audio_manager_module.o #ccflags-y += -DGB_AUDIO_MANAGER_SYSFS #endif -obj-$(CONFIG_GREYBUS_AUDIO_MSM8994)+= gb-audio-codec.o -obj-$(CONFIG_GREYBUS_AUDIO_MSM8994)+= gb-audio-module.o +obj-$(CONFIG_GREYBUS_AUDIO_APB_CODEC) += gb-audio-codec.o +obj-$(CONFIG_GREYBUS_AUDIO_APB_CODEC) += gb-audio-module.o obj-$(CONFIG_GREYBUS_AUDIO)+= gb-audio-gb.o obj-$(CONFIG_GREYBUS_AUDIO)+= gb-audio-apbridgea.o obj-$(CONFIG_GREYBUS_AUDIO)+= gb-audio-manager.o -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
Hi Vaibhav,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Vaibhav-Agarwal/Enable-Greybus-Audio-codec-driver/20200518-012023
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
cef077e6aa4c7dbe2f23e1201cf705f9540ec467
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/greybus/audio_helper.c:59:5: warning: no previous prototype
>> for function 'gbaudio_dapm_link_component_dai_widgets' [-Wmissing-prototypes]
int gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
^
drivers/staging/greybus/audio_helper.c:59:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
^
static
>> drivers/staging/greybus/audio_helper.c:112:5: warning: no previous prototype
>> for function 'gbaudio_dapm_free_controls' [-Wmissing-prototypes]
int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
^
drivers/staging/greybus/audio_helper.c:112:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
^
static
>> drivers/staging/greybus/audio_helper.c:189:5: warning: no previous prototype
>> for function 'gbaudio_remove_component_controls' [-Wmissing-prototypes]
int gbaudio_remove_component_controls(struct snd_soc_component *component,
^
drivers/staging/greybus/audio_helper.c:189:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int gbaudio_remove_component_controls(struct snd_soc_component *component,
^
static
3 warnings generated.
vim +/gbaudio_dapm_link_component_dai_widgets +59
drivers/staging/greybus/audio_helper.c
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 58
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 @59 int
gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 60
struct snd_soc_dapm_context *dapm)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 61 {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 62 struct
snd_soc_dapm_widget *dai_w;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 63
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 64 /* For each DAI
widget... */
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 65
list_for_each_entry(dai_w, >widgets, list) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 66 if (dai_w->dapm
!= dapm)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 67
continue;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 68 switch
(dai_w->id) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 69 case
snd_soc_dapm_dai_in:
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 70 case
snd_soc_dapm_dai_out:
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 71 break;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 72 default:
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 73
continue;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 74 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 75
gbaudio_dapm_link_dai_widget(dai_w, card);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 76 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 77
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 78 return 0;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 79 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 80
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 81 static void
gbaudio_dapm_free_path(struct snd_soc_dapm_path *path)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 82 {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 83
list_del(>list_node[SND_SOC_DAPM_DIR_IN]);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 84
Re: [PATCH V1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
Hi Vaibhav,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.7-rc6 next-20200518]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Vaibhav-Agarwal/Enable-Greybus-Audio-codec-driver/20200518-012023
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
cef077e6aa4c7dbe2f23e1201cf705f9540ec467
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/greybus/audio_helper.c:59:5: warning: no previous prototype
>> for 'gbaudio_dapm_link_component_dai_widgets' [-Wmissing-prototypes]
59 | int gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
| ^~~
>> drivers/staging/greybus/audio_helper.c:112:5: warning: no previous prototype
>> for 'gbaudio_dapm_free_controls' [-Wmissing-prototypes]
112 | int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
| ^~
>> drivers/staging/greybus/audio_helper.c:189:5: warning: no previous prototype
>> for 'gbaudio_remove_component_controls' [-Wmissing-prototypes]
189 | int gbaudio_remove_component_controls(struct snd_soc_component *component,
| ^
--
drivers/staging/greybus/audio_topology.c: In function 'find_gb_module':
>> drivers/staging/greybus/audio_topology.c:31:14: warning: variable 'ret' set
>> but not used [-Wunused-but-set-variable]
31 | int dev_id, ret;
| ^~~
drivers/staging/greybus/audio_topology.c: In function
'gbcodec_mixer_dapm_ctl_get':
>> drivers/staging/greybus/audio_topology.c:380:33: warning: variable 'info'
>> set but not used [-Wunused-but-set-variable]
380 | struct gb_audio_ctl_elem_info *info;
| ^~~~
vim +/gbaudio_dapm_link_component_dai_widgets +59
drivers/staging/greybus/audio_helper.c
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 58
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 @59 int
gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 60
struct snd_soc_dapm_context *dapm)
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 61 {
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 62 struct
snd_soc_dapm_widget *dai_w;
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 63
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 64 /* For each DAI
widget... */
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 65
list_for_each_entry(dai_w, >widgets, list) {
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 66 if (dai_w->dapm
!= dapm)
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 67
continue;
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 68 switch
(dai_w->id) {
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 69 case
snd_soc_dapm_dai_in:
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 70 case
snd_soc_dapm_dai_out:
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 71 break;
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 72 default:
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 73
continue;
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 74 }
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 75
gbaudio_dapm_link_dai_widget(dai_w, card);
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 76 }
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 77
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 78 return 0;
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 79 }
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 80
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 81 static void
gbaudio_dapm_free_path(struct snd_soc_dapm_path *path)
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 82 {
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 83
list_del(>list_node[SND_SOC_DAPM_DIR_IN]);
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 84
list_del(>list_node[SND_SOC_DAPM_DIR_OUT]);
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 85
list_del(>list_kcontrol);
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 86 list_del(>list);
94b08a33fd1bcaa Vaibhav Agarwal 2020-05-17 87 kfree(path);
Re: [PATCH V1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
Hi Vaibhav, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v5.7-rc5 next-20200515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Vaibhav-Agarwal/Enable-Greybus-Audio-codec-driver/20200518-012023 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git cef077e6aa4c7dbe2f23e1201cf705f9540ec467 config: i386-allyesconfig (attached as .config) reproduce: # apt-get install sparse # sparse version: v0.6.1-193-gb8fad4bc-dirty # save the attached .config to linux build tree make C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/staging/greybus/audio_codec.c:691:36: sparse: sparse: incorrect type >> in initializer (different base types) @@expected unsigned long long >> [usertype] formats @@got restricteunsigned long long [usertype] formats >> @@ >> drivers/staging/greybus/audio_codec.c:691:36: sparse:expected unsigned >> long long [usertype] formats >> drivers/staging/greybus/audio_codec.c:691:36: sparse:got restricted >> snd_pcm_format_t [usertype] drivers/staging/greybus/audio_codec.c:701:36: sparse: sparse: incorrect type in initializer (different base types) @@expected unsigned long long [usertype] formats @@got restricteunsigned long long [usertype] formats @@ drivers/staging/greybus/audio_codec.c:701:36: sparse:expected unsigned long long [usertype] formats drivers/staging/greybus/audio_codec.c:701:36: sparse:got restricted snd_pcm_format_t [usertype] -- >> drivers/staging/greybus/audio_module.c:223:25: sparse: sparse: incorrect >> type in assignment (different base types) @@expected restricted __le16 >> [usertype] data_cport @@got tricted __le16 [usertype] data_cport @@ >> drivers/staging/greybus/audio_module.c:223:25: sparse:expected >> restricted __le16 [usertype] data_cport >> drivers/staging/greybus/audio_module.c:223:25: sparse:got unsigned short >> [usertype] intf_cport_id -- >> drivers/staging/greybus/audio_topology.c:183:24: sparse: sparse: cast to >> restricted snd_ctl_elem_type_t >> drivers/staging/greybus/audio_topology.c:460:40: sparse: sparse: restricted >> __le32 degrades to integer >> drivers/staging/greybus/audio_topology.c:691:41: sparse: sparse: incorrect >> type in assignment (different base types) @@expected unsigned int access >> @@got restricted __le3unsigned int access @@ >> drivers/staging/greybus/audio_topology.c:691:41: sparse:expected >> unsigned int access >> drivers/staging/greybus/audio_topology.c:691:41: sparse:got restricted >> __le32 [usertype] access >> drivers/staging/greybus/audio_topology.c:678:14: sparse: sparse: restricted >> snd_ctl_elem_iface_t degrades to integer >> drivers/staging/greybus/audio_topology.c:746:44: sparse: sparse: incorrect >> type in assignment (different base types) @@expected unsigned int @@ >> got restrunsigned int @@ >> drivers/staging/greybus/audio_topology.c:746:44: sparse:expected >> unsigned int >> drivers/staging/greybus/audio_topology.c:746:44: sparse:got restricted >> __le32 drivers/staging/greybus/audio_topology.c:748:52: sparse: sparse: incorrect type in assignment (different base types) @@expected unsigned int @@got restrunsigned int @@ drivers/staging/greybus/audio_topology.c:748:52: sparse:expected unsigned int drivers/staging/greybus/audio_topology.c:748:52: sparse:got restricted __le32 drivers/staging/greybus/audio_topology.c:803:42: sparse: sparse: restricted __le32 degrades to integer >> drivers/staging/greybus/audio_topology.c:806:50: sparse: sparse: incorrect >> type in assignment (different base types) @@expected restricted __le32 >> @@got icted __le32 @@ >> drivers/staging/greybus/audio_topology.c:806:50: sparse:expected >> restricted __le32 >> drivers/staging/greybus/audio_topology.c:806:50: sparse:got unsigned int drivers/staging/greybus/audio_topology.c:815:50: sparse: sparse: restricted __le32 degrades to integer drivers/staging/greybus/audio_topology.c:818:58: sparse: sparse: incorrect type in assignment (different base types) @@expected restricted __le32 @@ got icted __le32 @@ drivers/staging/greybus/audio_topology.c:818:58: sparse:expected restricted __le32 drivers/staging/greybus/audio_topology.c:818:58: sparse:got unsigned int drivers/staging/greybus/audio_topology.c:890:25: sparse: sparse: incorrect type in assignment (different base types) @@expected unsigned int access @@ got
[PATCH V1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
Currently, GB codec and audio module is conditionally compiled based on GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994 platform and can be used generically with any platform that follows GB Audio class specification. Also, GB codec driver corresponds to dummy codec represented by I2S port available on Toshiba AP Bridge. Added config option for the same in kconfig file and accordingly updated Makefile. Signed-off-by: Vaibhav Agarwal --- drivers/staging/greybus/Kconfig | 14 +- drivers/staging/greybus/Makefile | 4 ++-- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/Kconfig b/drivers/staging/greybus/Kconfig index d4777f5a8b90..cbcfcbba239b 100644 --- a/drivers/staging/greybus/Kconfig +++ b/drivers/staging/greybus/Kconfig @@ -3,7 +3,7 @@ if GREYBUS config GREYBUS_AUDIO tristate "Greybus Audio Class driver" - depends on SOUND + depends on SOUND && SND_SOC ---help--- Select this option if you have a device that follows the Greybus Audio Class specification. @@ -11,6 +11,18 @@ config GREYBUS_AUDIO To compile this code as a module, chose M here: the module will be called gb-audio.ko +config GREYBUS_AUDIO_APB_CODEC + tristate "Greybus APBridge Audio codec driver" + depends on SND_SOC && GREYBUS_AUDIO + help + Select this option if you have a Toshiba APB device that has I2S + ports and acts as a Greybus "Dummy codec". This device is a + bridge from an APB-I2S port to a Unipro network. + + To compile this code as a module, chose M here: the module + will be called gb-audio-codec.ko + + config GREYBUS_BOOTROM tristate "Greybus Bootrom Class driver" ---help--- diff --git a/drivers/staging/greybus/Makefile b/drivers/staging/greybus/Makefile index 3b4b6cabff19..7c5e89622334 100644 --- a/drivers/staging/greybus/Makefile +++ b/drivers/staging/greybus/Makefile @@ -40,8 +40,8 @@ gb-audio-manager-y:= audio_manager.o audio_manager_module.o #ccflags-y += -DGB_AUDIO_MANAGER_SYSFS #endif -obj-$(CONFIG_GREYBUS_AUDIO_MSM8994)+= gb-audio-codec.o -obj-$(CONFIG_GREYBUS_AUDIO_MSM8994)+= gb-audio-module.o +obj-$(CONFIG_GREYBUS_AUDIO_APB_CODEC) += gb-audio-codec.o +obj-$(CONFIG_GREYBUS_AUDIO_APB_CODEC) += gb-audio-module.o obj-$(CONFIG_GREYBUS_AUDIO)+= gb-audio-gb.o obj-$(CONFIG_GREYBUS_AUDIO)+= gb-audio-apbridgea.o obj-$(CONFIG_GREYBUS_AUDIO)+= gb-audio-manager.o -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
