Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

2018-02-20 Thread Dan Carpenter
On Tue, Feb 20, 2018 at 09:21:56AM -0300, Rodrigo Siqueira wrote: > On 02/20, Dan Carpenter wrote: > > > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote: > > ^^^ > > This looks good, but you need to fix your from email header.

Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

2018-02-20 Thread Rodrigo Siqueira
On 02/20, Dan Carpenter wrote: > > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote: > ^^^ > This looks good, but you need to fix your from email header. Thanks for the review, and the feedback related to the email header. I

Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

2018-02-19 Thread Dan Carpenter
> On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote: ^^^ This looks good, but you need to fix your from email header. regards, dan carpenter ___ devel mailing list

[PATCH v2] staging:iio:meter: Add name to function definition arguments

2018-02-19 Thread rodrigosiqueira
This patch fixes the checkpatch.pl warning: drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition argument 'struct device *' should also have an identifier name... This commit adds arguments names to the signature declared in the ade7854_state struct. For consistency reason, It