Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

[Dan Carpenter]

When I look at them now in a more relaxed mood, they're basically all
fine except for patch 74 which is buggy.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

[Joe Perches]

On Mon, 2018-04-02 at 14:45 +0300, Dan Carpenter wrote:
> On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote:
> > On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote:
> > > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote:
> > > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> > > > > This macro, provided in 'linux/kernel.h', will calculate the size
> > > > > more succinctly than a division operation.
> > > > 
> > > > It's nice that you send patches, but please try to send a
> > > > cover letter with your patch series.
> > > > 
> > > 
> > > There are obviously times when a cover letter is required but what's the
> > > point of that for this particular series?
> > 
> > practice
> > 
> It really pisses me off to see patch submitters get assign busy work
> for no reason.  This is not school and these are not your students.

Please take a chill pill Dan.
I think cover letters are best practice.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

[Dan Carpenter]

On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote:
> On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote:
> > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote:
> > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> > > > This macro, provided in 'linux/kernel.h', will calculate the size
> > > > more succinctly than a division operation.
> > > 
> > > It's nice that you send patches, but please try to send a
> > > cover letter with your patch series.
> > > 
> > 
> > There are obviously times when a cover letter is required but what's the
> > point of that for this particular series?
> 
> practice
> 

It really pisses me off to see patch submitters get assign busy work
for no reason.  This is not school and these are not your students.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

[Joe Perches]

On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote:
> On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote:
> > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> > > This macro, provided in 'linux/kernel.h', will calculate the size
> > > more succinctly than a division operation.
> > 
> > It's nice that you send patches, but please try to send a
> > cover letter with your patch series.
> > 
> 
> There are obviously times when a cover letter is required but what's the
> point of that for this particular series?

practice

> > Also, 75 patches is quite a lot for a staging patch series.
> > 
> > Please try to send fewer patches in your series, say a
> > maximum of 20 or so and see what happens to those patches
> > before sending the next set.
> 
> Do we really care about that for staging?

It seems like it matters most for staging as the submitters
are the least experienced nd most likely to get something
wrong.

Start small and build.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

[Dan Carpenter]

On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote:
> On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> > This macro, provided in 'linux/kernel.h', will calculate the size
> > more succinctly than a division operation.
> 
> It's nice that you send patches, but please try to send a
> cover letter with your patch series.
> 

There are obviously times when a cover letter is required but what's the
point of that for this particular series?  What do you want the cover
letter to say here that isn't obvious to everyone just from glancing at
their inbox?

> Also, 75 patches is quite a lot for a staging patch series.
> 
> Please try to send fewer patches in your series, say a
> maximum of 20 or so and see what happens to those patches
> before sending the next set.

Do we really care about that for staging?  I can review the first 67
patches basically automatically so they take me about 5 seconds each.  I
feel like splitting it up risks introducing more conflicts so it
actually makes the process harder/worse.

regards,
dan carpenter


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

[Joe Perches]

On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> This macro, provided in 'linux/kernel.h', will calculate the size
> more succinctly than a division operation.

It's nice that you send patches, but please try to send a
cover letter with your patch series.

Also, 75 patches is quite a lot for a staging patch series.

Please try to send fewer patches in your series, say a
maximum of 20 or so and see what happens to those patches
before sending the next set.

Thanks.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

[Quytelda Kahja]

This macro, provided in 'linux/kernel.h', will calculate the size
more succinctly than a division operation.

Signed-off-by: Quytelda Kahja 
---
 drivers/staging/ks7010/ks_wlan_net.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan_net.c 
b/drivers/staging/ks7010/ks_wlan_net.c
index 9078e13b0d4a..533feef604a9 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -2702,10 +2702,9 @@ static const iw_handler ks_wlan_private_handler[] = {
 };
 
 static const struct iw_handler_def ks_wlan_handler_def = {
-   .num_standard = sizeof(ks_wlan_handler) / sizeof(iw_handler),
-   .num_private = sizeof(ks_wlan_private_handler) / sizeof(iw_handler),
-   .num_private_args =
-   sizeof(ks_wlan_private_args) / sizeof(struct iw_priv_args),
+   .num_standard = ARRAY_SIZE(ks_wlan_handler),
+   .num_private = ARRAY_SIZE(ks_wlan_private_handler),
+   .num_private_args = ARRAY_SIZE(ks_wlan_private_args),
.standard = (iw_handler *)ks_wlan_handler,
.private = (iw_handler *)ks_wlan_private_handler,
.private_args = (struct iw_priv_args *)ks_wlan_private_args,
-- 
2.16.3

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel