RE: [PATCH v3 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

2016-12-15 Thread Stuart Yoder
> > +#define DPIO_CMD(id) ((id << DPIO_CMD_ID_OFFSET) | > > DPIO_CMD_BASE_VERSION) > > Paranthesis around 'id'? In all cases these are opcode values and will never be an expression. If we really need to future proof these definitions, we should do it for all objects not just DPIO. I'd

Re: [PATCH v3 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

2016-12-02 Thread Laurentiu Tudor
Couple of nits inline. --- Best Regards, Laurentiu On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Ioana Radulescu > > Add the command build/parse APIs for operating on DPIO objects through > the DPAA2 Management Complex. > > Signed-off-by: Ioana Radulescu

[PATCH v3 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

2016-12-01 Thread Stuart Yoder
From: Ioana Radulescu Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder