Re: [PATCH] Staging: nvec: fix line should not end with a open parenthesis.

[Dan Carpenter]

On Fri, Feb 16, 2018 at 05:06:34PM +0530, Yash Omer wrote:
> This patch fix line should not end with open parenthesis found by 
> checkpatch.plscript.
> 
> Signed-off-by: Yash Omer 
> ---
>  drivers/staging/nvec/nvec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 52054a528723..39fb737543b5 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -383,8 +383,8 @@ static void nvec_request_master(struct work_struct *work)
>   msg = list_first_entry(>tx_data, struct nvec_msg, node);
>   spin_unlock_irqrestore(>tx_lock, flags);
>   nvec_gpio_set_value(nvec, 0);
> - err = wait_for_completion_interruptible_timeout(
> - >ec_transfer, msecs_to_jiffies(5000));
> + err = wait_for_completion_interruptible_timeout
> + (>ec_transfer, msecs_to_jiffies(5000));

The original code is basically fine...  It's OK to ignore checkpatch in
this situation.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] Staging: nvec: fix line should not end with a open parenthesis.

[David Laight]

From: Yash Omer
> Sent: 16 February 2018 11:37
> This patch fix line should not end with open parenthesis found by 
> checkpatch.plscript.
> 
> Signed-off-by: Yash Omer 
> ---
>  drivers/staging/nvec/nvec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 52054a528723..39fb737543b5 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -383,8 +383,8 @@ static void nvec_request_master(struct work_struct *work)
>   msg = list_first_entry(>tx_data, struct nvec_msg, node);
>   spin_unlock_irqrestore(>tx_lock, flags);
>   nvec_gpio_set_value(nvec, 0);
> - err = wait_for_completion_interruptible_timeout(
> - >ec_transfer, msecs_to_jiffies(5000));
> + err = wait_for_completion_interruptible_timeout
> + (>ec_transfer, msecs_to_jiffies(5000));

Ugg...
Isn't the correct fix to reduce the length of the function name?

David

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel