Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-06 Thread Julia Lawall
On Tue, 6 Mar 2018, Arushi Singhal wrote: > > > On Mon, Mar 5, 2018 at 1:07 PM, Julia Lawall wrote: > > > On Mon, 5 Mar 2018, Arushi Singhal wrote: > > > Replace printk having a log level with the appropriate > > net_*macro_ratelimited. > > It's

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. I asked several questions about the above two lines, which as far as I can see haven't been