Re: [PATCH] Delete the goldfish_nand driver.
On Wed, May 16, 2018 at 10:31:26AM -0700, Roman Kiryanov wrote: > Hi, thank you for looking. > > I see goldfish_audio.c in drivers/staging/goldfish. There > is arch/mips/configs/generic/board-ranchu.config referencing this driver > (CONFIG_GOLDFISH_AUDIO=y). I believe we need to keep goldfish to keep this > config. Does anyone actually use that config? Is it a "real" device? > I can move the goldfish folder to a more appropriate place and add more > goldfish drivers there. Will drivers/goldfish work for you? It has a long effort to be cleaned up properly before it can get out of drivers/staging/, it's not a matter of just moving it to a new directory. It is in staging for a good reason :) Again, are these even needed now that the cuttlefish build target is present? Who is even using these drivers? Why has no one worked on cleaning up the upstream code in the past few years? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Delete the goldfish_nand driver.
On Tue, May 15, 2018 at 01:58:45PM -0700, r...@google.com wrote: > From: Roman Kiryanov> > This driver was inherited from qemu1 and not used anymore. > > Signed-off-by: Roman Kiryanov > --- > drivers/staging/goldfish/Kconfig | 7 - > drivers/staging/goldfish/Makefile| 1 - > drivers/staging/goldfish/goldfish_nand.c | 441 --- > drivers/staging/goldfish/goldfish_nand_reg.h | 76 > 4 files changed, 525 deletions(-) > delete mode 100644 drivers/staging/goldfish/goldfish_nand.c > delete mode 100644 drivers/staging/goldfish/goldfish_nand_reg.h Now that we have the drivers/staging/android/vsoc.c driver, are any of the goldfish drivers needed anymore? I can run a virtual android system on my laptop using the vsoc driver only, no goldfish needed at all. If not, and goldfish is still needed, what's the plans on getting this code out of staging? It's been living there for a while with no forward progress or updates in a long time. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel