Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-19 Thread Greg KH
On Wed, Oct 19, 2016 at 01:34:44AM +0530, Shyam Saini wrote: > On Tue, 2016-10-18 at 14:36 +0200, Greg KH wrote: > > On Tue, Oct 18, 2016 at 05:52:21PM +0530, Shyam Saini wrote: > > > > > > On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote: > > > > > > > > On Mon, Oct 17, 2016 at 10:10:08PM +0530,

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-18 Thread Shyam Saini
On Tue, 2016-10-18 at 14:36 +0200, Greg KH wrote: > On Tue, Oct 18, 2016 at 05:52:21PM +0530, Shyam Saini wrote: > > > > On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote: > > > > > > On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote: > > > > > > > > > > > > On Mon, 2016-10-17 at 18:07

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-18 Thread Greg KH
On Tue, Oct 18, 2016 at 05:52:21PM +0530, Shyam Saini wrote: > On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote: > > On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote: > > > > > > On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > > > > > > > > On Mon, Oct 17, 2016 at 09:24:19PM +0530,

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-18 Thread Shyam Saini
On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote: > On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote: > > > > On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > > > > > > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > > > > > > > > > > > > Fixed following checkpatch

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-17 Thread Greg KH
On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote: > On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > > > > > > Fixed following checkpatch warning > > > Symbolic permissions 'S_IRUGO' are not preferred. Consider using >

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-17 Thread Shyam Saini
On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > > > > Fixed following checkpatch warning > > Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > octal > > permissions '0444' > > > > Signed-off-by: Shyam Saini > >

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-17 Thread Greg KH
On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > Fixed following checkpatch warning > Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal > permissions '0444' > > Signed-off-by: Shyam Saini > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 18 +-