Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT
On Tue, Feb 12, 2019 at 12:28 AM Alistair Strachan wrote: > > On Mon, Feb 11, 2019 at 9:22 AM Todd Kjos wrote: > > > > +Alistair Strachan > > > > On Mon, Feb 11, 2019 at 9:11 AM Greg KH wrote: > > > > > > On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > > > > On Mon, Feb 11, 2019 at 9:27 PM Greg KH > > > > wrote: > > > > > > > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH > > > > > > wrote: > > > > > > > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > > > > As mentioned in TODO list, Removed > > > > > > > > VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > > > > ioctl. This functionality has been superseded by the futex and > > > > > > > > is > > > > > > > > there for legacy reasons. > > > > > > > > > > > > > > > > Signed-off-by: Souptick Joarder > > > > > > > > --- > > > > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 --- > > > > > > > > drivers/staging/android/vsoc.c | 5 - > > > > > > > > 2 files changed, 12 deletions(-) > > > > > > > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? > > > > > > > Any > > > > > > > pointers to the userspace commit that did this? > > The ioctl is still being used and cannot be removed. I think, it's good to add this info in TODO file. I can edit it if you are ok. > > > > > > > > > > > > > I am not sure about user space part. > > > > > > > > > > Then we can not just delete the ioctl :) > > > > > > > > Agree, but where to verify the user space commit ? > > > > Any pointer to the source code path ? > > The userspace code using the Linux 'vsoc' staging driver can be cloned > from here: > > https://android.googlesource.com/device/google/cuttlefish_common Thanks. > > > > > > > Please work with the android developers to solve this. It should be in > > > AOSP "somewhere" :( > > I'm working on documenting this better on source.android.com. Stay tuned. > > > > > > > good luck, > > > > > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT
On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:27 PM Greg KH wrote: > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH > > > wrote: > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > ioctl. This functionality has been superseded by the futex and is > > > > > there for legacy reasons. > > > > > > > > > > Signed-off-by: Souptick Joarder > > > > > --- > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 --- > > > > > drivers/staging/android/vsoc.c | 5 - > > > > > 2 files changed, 12 deletions(-) > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > > pointers to the userspace commit that did this? > > > > > > I am not sure about user space part. > > > > Then we can not just delete the ioctl :) > > Agree, but where to verify the user space commit ? > Any pointer to the source code path ? Please work with the android developers to solve this. It should be in AOSP "somewhere" :( good luck, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT
On Mon, Feb 11, 2019 at 9:27 PM Greg KH wrote: > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH wrote: > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > ioctl. This functionality has been superseded by the futex and is > > > > there for legacy reasons. > > > > > > > > Signed-off-by: Souptick Joarder > > > > --- > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 --- > > > > drivers/staging/android/vsoc.c | 5 - > > > > 2 files changed, 12 deletions(-) > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > pointers to the userspace commit that did this? > > > > I am not sure about user space part. > > Then we can not just delete the ioctl :) Agree, but where to verify the user space commit ? Any pointer to the source code path ? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT
On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:10 PM Greg KH wrote: > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > ioctl. This functionality has been superseded by the futex and is > > > there for legacy reasons. > > > > > > Signed-off-by: Souptick Joarder > > > --- > > > drivers/staging/android/uapi/vsoc_shm.h | 7 --- > > > drivers/staging/android/vsoc.c | 5 - > > > 2 files changed, 12 deletions(-) > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > pointers to the userspace commit that did this? > > I am not sure about user space part. Then we can not just delete the ioctl :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT
On Mon, Feb 11, 2019 at 9:10 PM Greg KH wrote: > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > ioctl. This functionality has been superseded by the futex and is > > there for legacy reasons. > > > > Signed-off-by: Souptick Joarder > > --- > > drivers/staging/android/uapi/vsoc_shm.h | 7 --- > > drivers/staging/android/vsoc.c | 5 - > > 2 files changed, 12 deletions(-) > > So userspace is all fixed up now and this ioctl can be dropped? Any > pointers to the userspace commit that did this? I am not sure about user space part. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT
On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > ioctl. This functionality has been superseded by the futex and is > there for legacy reasons. > > Signed-off-by: Souptick Joarder > --- > drivers/staging/android/uapi/vsoc_shm.h | 7 --- > drivers/staging/android/vsoc.c | 5 - > 2 files changed, 12 deletions(-) So userspace is all fixed up now and this ioctl can be dropped? Any pointers to the userspace commit that did this? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
