Re: [PATCH] staging: iio/meter: add name to function definition arguments

2018-02-19 Thread Rodrigo Siqueira
Hi Jonathan, > On Fri, 16 Feb 2018 11:16:58 -0200 > Rodrigo Siqueira wrote: > > > Hi Daniel > > > > > Hi Rodrigo, > > > > > > I think this is a nice finding. One comment inline: > > > > > > On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > > > > This

Re: [PATCH] staging: iio/meter: add name to function definition arguments

2018-02-17 Thread Jonathan Cameron
On Fri, 16 Feb 2018 11:16:58 -0200 Rodrigo Siqueira wrote: > Hi Daniel > > > Hi Rodrigo, > > > > I think this is a nice finding. One comment inline: > > > > On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > > > This patch fixes the checkpatch.pl

Re: [PATCH] staging: iio/meter: add name to function definition arguments

2018-02-16 Thread Daniel Baluta
Hi Rodrigo, I think this is a nice finding. One comment inline: On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > This patch fixes the checkpatch.pl warning: > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > argument 'struct device *' should also have an

Re: [PATCH] staging: iio/meter: add name to function definition arguments

2018-02-16 Thread Rodrigo Siqueira
Hi Daniel > Hi Rodrigo, > > I think this is a nice finding. One comment inline: > > On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > > This patch fixes the checkpatch.pl warning: > > > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > > argument 'struct device