Re: [PATCH] staging: ks7010: pass 'int' instead of 'bool' to 'hostif_mib_set_request_bool'

2018-07-12 Thread Sergio Paracuellos
On Thu, Jul 12, 2018 at 10:11:25PM +0300, Dan Carpenter wrote: > On Thu, Jul 12, 2018 at 08:20:16PM +0200, Sergio Paracuellos wrote: > > On Thu, Jul 12, 2018 at 2:13 PM, Dan Carpenter > > wrote: > > > On Thu, Jul 12, 2018 at 06:57:42AM +0200, Sergio Paracuellos wrote: > > >>

Re: [PATCH] staging: ks7010: pass 'int' instead of 'bool' to 'hostif_mib_set_request_bool'

2018-07-12 Thread Dan Carpenter
On Thu, Jul 12, 2018 at 08:20:16PM +0200, Sergio Paracuellos wrote: > On Thu, Jul 12, 2018 at 2:13 PM, Dan Carpenter > wrote: > > On Thu, Jul 12, 2018 at 06:57:42AM +0200, Sergio Paracuellos wrote: > >> 'hostif_mib_set_request_bool' function receives a bool as value and > >> send the received

Re: [PATCH] staging: ks7010: pass 'int' instead of 'bool' to 'hostif_mib_set_request_bool'

2018-07-12 Thread Sergio Paracuellos
On Thu, Jul 12, 2018 at 2:13 PM, Dan Carpenter wrote: > On Thu, Jul 12, 2018 at 06:57:42AM +0200, Sergio Paracuellos wrote: >> 'hostif_mib_set_request_bool' function receives a bool as value and >> send the received value with MIB_VALUE_TYPE_BOOL type. There is >> one case where the value passed

Re: [PATCH] staging: ks7010: pass 'int' instead of 'bool' to 'hostif_mib_set_request_bool'

2018-07-12 Thread Dan Carpenter
On Thu, Jul 12, 2018 at 06:57:42AM +0200, Sergio Paracuellos wrote: > 'hostif_mib_set_request_bool' function receives a bool as value and > send the received value with MIB_VALUE_TYPE_BOOL type. There is > one case where the value passed is not a boolean one but > 'MCAST_FILTER_PROMISC' which is