Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

On Thu, Sep 15, 2016 at 07:22:40PM +0200, Sergio Paracuellos wrote: > That's true. It seems that checkpatch script is getting a false > positive. Just trying to do checkpatch happy. Also the old code was better than new code so leave it alone. regards, dan carpenter

Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

On Thu, 2016-09-15 at 19:22 +0200, Sergio Paracuellos wrote: > That's true. It seems that checkpatch script is getting a false > positive. Just trying to do checkpatch happy. Sorry for inconvenience. Keeping the style consistent instead of taking the simplest path to quiet the checkpatch

Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

That's true. It seems that checkpatch script is getting a false positive. Just trying to do checkpatch happy. Sorry for inconvenience. I'll be careful with Changelog stuff from now. Thanks for advice. Cheers, Sergio Paracuellos El 2016年09月15日 a las 16:51, Greg KH escribió: On Thu,

Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

On Thu, Sep 15, 2016 at 04:29:54PM +0200, Sergio Paracuellos wrote: > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/rts5208/rtsx_card.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_card.c >