Re: [PATCH] staging:iio:accel:adis16240: sign extend function avoiding code duplication

2018-06-12 Thread Jonathan Cameron
On Tue, 12 Jun 2018 02:57:48 +0200 Karim Eshapa wrote: > Use sign_extend32 kernel function instead of code duplication. > Safe also for 16 bit. > > Signed-off-by: Karim Eshapa Please resend as a fresh patch marked at V2 with a change log below the --- so we can easily see what has changed.

Re: [PATCH] staging:iio:accel:adis16240: sign extend function avoiding code duplication

2018-06-11 Thread Joe Perches
On Tue, 2018-06-12 at 01:38 +0200, Karim Eshapa wrote: > Use sign_extend32 kernel function instead of code duplication. > Safe also for 16 bit. Perhaps remove the bits declaration and assignments and just use 9 directly. > diff --git a/drivers/staging/iio/accel/adis16240.c >

Re: [PATCH] staging:iio:accel:adis16240: sign extend function avoiding code duplication

2018-06-11 Thread Karim Eshapa
Use sign_extend32 kernel function instead of code duplication. Safe also for 16 bit. Signed-off-by: Karim Eshapa --- drivers/staging/iio/accel/adis16240.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/accel/adis16240.c