Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-12-01 Thread Greg KH 
On Wed, Nov 30, 2016 at 11:06:39PM +0330, Saber Rezvani wrote:
> Fix the checkpatch.pl issue:
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> 
> Signed-off-by: Saber Rezvani 
> Reviewed-by: Ian Abbott 
> ---
>  drivers/staging/comedi/drivers/s626.c | 30 +++---
>  1 file changed, 15 insertions(+), 15 deletions(-)

Is this a v3 or v4 or some version of a patch?  Please read
Documentation/SubmttingPatches for how to properly version a patch, and
then resend all of them with the correct information.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-30 Thread Dan Carpenter 
On Wed, Nov 30, 2016 at 06:04:14PM +0330, Saber Rezvani wrote:
> @@ -1035,7 +1035,7 @@ static int s626_dio_set_irq(struct comedi_device *dev, 
> unsigned int chan)
>   return 0;
>  }
>  
> -static int s626_dio_reset_irq(struct comedi_device *dev, unsigned int group,
> +static int s626_dio_reset_irq(struct comedi_device *dev, u8 group,
> unsigned int mask)
>  {
>   /* disable edge capture write command */

This change isn't wrong, but it should be in a different patch or at the
very least mentioned in the changelog.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-29 Thread Greg KH 
On Fri, Nov 25, 2016 at 12:01:21AM +0330, Saber Rezvani wrote:
> >From c3dd43f3d43e7bec8f7f1140519ffc1f3b727b01 Mon Sep 17 00:00:00 2001
> From: Saber 

This doesn't match up with your signed-off-by: or your email from: line.

Please fix this up by using git send-email to send the patches, don't
include the whole header inline like this.

> Date: Thu, 24 Nov 2016 23:15:21 +0330
> Subject: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

Yes, it does work (git is smart), but it's messy, and no one else does
it for kernel patches, so please fix up and resend all 3 of these, with
Ian's reviewed-by: line added.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-25 Thread Ian Abbott 

On 24/11/16 20:31, Saber Rezvani wrote:

From c3dd43f3d43e7bec8f7f1140519ffc1f3b727b01 Mon Sep 17 00:00:00 2001
From: Saber 
Date: Thu, 24 Nov 2016 23:15:21 +0330
Subject: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8



All that extra header stuff above will have to be removed.  I'm not sure 
if Greg will take care of that.  The same goes for the other patches in 
this series.



Fix the checkpatch.pl issue:
CHECK: Prefer kernel type 'u8' over 'uint8_t'

Signed-off-by: Saber Rezvani 
---
 drivers/staging/comedi/drivers/s626.c | 32 
 1 file changed, 16 insertions(+), 16 deletions(-)


Thanks!

Reviewed-by: Ian Abbott 

--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel