Re: [PATCH 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info_t

2019-10-11 Thread Wambui Karuga
On Fri, Oct 11, 2019 at 11:02:13AM +0200, Greg KH wrote: > On Fri, Oct 11, 2019 at 09:02:39AM +0300, Wambui Karuga wrote: > > -typedef union { > > +union cvmx_helper_link_info_t { > > I agree with Julia, all of the "_t" needs to be dropped as that is > pointless. It's a holdover from the original

Re: [PATCH 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info_t

2019-10-11 Thread Greg KH
On Fri, Oct 11, 2019 at 09:02:39AM +0300, Wambui Karuga wrote: > -typedef union { > +union cvmx_helper_link_info_t { I agree with Julia, all of the "_t" needs to be dropped as that is pointless. It's a holdover from the original name where "_t" was trying to say that this is a typedef. Gotta lov