Re: [PATCH v2] staging: rtl8188eu: remove dead code/vestigial do..while loop

2019-09-27 Thread Dan Carpenter
Looks good. Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging: rtl8188eu: remove dead code/vestigial do..while loop

2019-09-26 Thread Larry Finger
On 9/24/19 9:28 AM, Connor Kuehl wrote: The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning that the second operand is never reached