subject:"Re\: \[PATCH v2 1\/4\] staging\: greybus\: audio\: Avoid less than zero check for le32 variable"

Re: [PATCH v2 1/4] staging: greybus: audio: Avoid less than zero check for le32 variable

2017-01-18 Thread Vaibhav Agarwal

On Tue, Jan 17, 2017 at 10:56 PM, Mark Greer wrote: > Hi Vaibhav. > > On Tue, Jan 17, 2017 at 08:19:27PM +0530, Vaibhav Agarwal wrote: >> mixer control->info call back function checks for -ve values to rebase >> min and max values. However, le32 variable is used to fetch

Re: [PATCH v2 1/4] staging: greybus: audio: Avoid less than zero check for le32 variable

2017-01-17 Thread Mark Greer

Hi Vaibhav. On Tue, Jan 17, 2017 at 08:19:27PM +0530, Vaibhav Agarwal wrote: > mixer control->info call back function checks for -ve values to rebase > min and max values. However, le32 variable is used to fetch values from > GB module FW. Thus -ve value checking is not required. Fix this!! nit: