RE: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
er.kernel.org; Alexander Graf > <ag...@suse.de>; a...@arndb.de; Alexandru Marginean > <alexandru.margin...@nxp.com>; Ruxandra Ioana Ciocoi Radulescu > <ruxandra.radule...@nxp.com>; Ioana Ciornei <ioana.cior...@nxp.com>; > Laurentiu Tudor <laurentiu.tu...@nxp.com&

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-13 Thread Andrew Lunn
> Hello Andrew, > > The current driver implementation uses only a single FDB for the switch, > so it is not possible configure multiple flooding domains to accommodate > ports partitioning. Ah, O.K. Rather than break somebodies network by wrongly flooding, it would be better to return

RE: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-13 Thread Razvan Stefanescu
er.kernel.org; Alexander Graf > <ag...@suse.de>; a...@arndb.de; Alexandru Marginean > <alexandru.margin...@nxp.com>; Ruxandra Ioana Ciocoi Radulescu > <ruxandra.radule...@nxp.com>; Ioana Ciornei <ioana.cior...@nxp.com>; > Laurentiu Tudor <laurentiu.tu...@nxp.com&

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-13 Thread Andrew Lunn
> +/* For the moment, only flood setting needs to be updated */ > +static int port_bridge_join(struct net_device *netdev, > + struct net_device *upper_dev) > +{ > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > + struct ethsw_core *ethsw =