Hi Pavel,
On Thu, Aug 15, 2019 at 09:01:32AM +0200, Pavel Machek wrote:
> Hi!
>
> > > > + /*
> > > > +* on-disk error, let's only BUG_ON in the debugging mode.
> > > > +* otherwise, it will return 1 to just skip the invalid name
> > > > +* and go on (in
Hi!
> > > + /*
> > > + * on-disk error, let's only BUG_ON in the debugging mode.
> > > + * otherwise, it will return 1 to just skip the invalid name
> > > + * and go on (in consideration of the lookup performance).
> > > + */
> > > + DBG_BUGON(qd->name > qd->end);
> >
> > I believe you
On Tue, Aug 13, 2019 at 08:23:32PM +0800, Gao Xiang wrote:
> Hi Pavel,
>
> On Tue, Aug 13, 2019 at 01:48:21PM +0200, Pavel Machek wrote:
[]
> There is something needing to be concerned, is, whether namei() should
> report any potential on-disk issues or just return -ENOENT for these
> corrupted
Hi Pavel,
On Tue, Aug 13, 2019 at 01:48:21PM +0200, Pavel Machek wrote:
> Hi!
>
> > + /*
> > +* on-disk error, let's only BUG_ON in the debugging mode.
> > +* otherwise, it will return 1 to just skip the invalid name
> > +* and go on (in consideration of the lookup performance).
>
Hi!
> + /*
> + * on-disk error, let's only BUG_ON in the debugging mode.
> + * otherwise, it will return 1 to just skip the invalid name
> + * and go on (in consideration of the lookup performance).
> + */
> + DBG_BUGON(qd->name > qd->end);
I believe you should check
