Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

2016-09-01 Thread Javier Martinez Canillas
On 09/01/2016 05:32 PM, Greg Kroah-Hartman wrote: > On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote: >> Hello David, >> >> On 08/25/2016 12:01 PM, David Daney wrote: >>> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: The IS_ENABLED() macro checks if a Kconfig

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

2016-09-01 Thread Greg Kroah-Hartman
On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote: > Hello David, > > On 08/25/2016 12:01 PM, David Daney wrote: > > On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: > >> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > >> built-in or as a

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

2016-08-25 Thread Javier Martinez Canillas
Hello David, On 08/25/2016 12:01 PM, David Daney wrote: > On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: >> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either >> built-in or as a module, use that macro instead of open coding the same. >> >> Using the macro makes

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

2016-08-25 Thread David Daney
On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Using the macro makes the code more readable by helping abstract away some of the Kconfig