Re: ifndef_wrapper.sh required sed with "-E" which isn't available with old sed version.

2018-07-24 Thread Samuel Hsu
Thanks Matt, it looks good to me. Regards, Samuel On Tue, Jul 24, 2018 at 8:26 PM, Matt Johnston wrote: > On Mon, Jul 23, 2018 at 01:08:54PM +0800, Samuel Hsu wrote: > > As titled, can we use "sed -r" instead of "sed -E". > > Hi Samuel, > > Thanks, I hadn't noticed that problem. I've pushed a

Re: ifndef_wrapper.sh required sed with "-E" which isn't available with old sed version.

2018-07-24 Thread Matt Johnston
On Mon, Jul 23, 2018 at 01:08:54PM +0800, Samuel Hsu wrote: > As titled, can we use "sed -r" instead of "sed -E". Hi Samuel, Thanks, I hadn't noticed that problem. I've pushed a change to uses non-extended regexes which should work everywhere.