[
https://jira.duraspace.org/browse/DS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark H. Wood updated DS-494:
----------------------------
Attachment: DS-494.patch
Updated patch, adding the corresponding change to execute().
> DatabaseManager.process() unnecessarily limits range of DECIMAL or NUMERIC
> --------------------------------------------------------------------------
>
> Key: DS-494
> URL: https://jira.duraspace.org/browse/DS-494
> Project: DSpace 1.x
> Issue Type: Bug
> Components: DSpace API
> Affects Versions: 1.5.2, 1.6.0
> Environment: PostgreSQL
> Reporter: Mark H. Wood
> Assignee: Mark H. Wood
> Fix For: 1.7.0
>
> Attachments: DatabaseManager.patch, DS-494.patch
>
>
> INTEGER, DECIMAL, and NUMERIC are lumped together. In the case we are using
> Oracle, the code will set the column to an int or a long depending on the
> size of the value. (I would like to know why we bother.) Otherwise the
> value is assumed to be within the range of int. But DECIMAL and NUMERIC can
> be far larger than int, and are returned by e.g. sum(BIGINT).
> The attached patch widens the result, in the non-Oracle case, to long for all
> three SQL datatypes. Strictly speaking, DECIMAL and NUMERIC should be mapped
> to java.math.BigDecimal, but that requires the introduction of new methods to
> TableRow as well. Widening from int to long probably covers most of the
> real-world cases. The patch is against 1.5.2 but also applies to 1.6.0-rc2.
> I would appreciate comments on how this widening may affect other code. The
> patch is in test on a live system, but in a locally-developed webapp rather
> than any of the main DSpace UIs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
